Re: [Mesa-dev] [PATCH 2/3] radv: remove unnecessary FLUSH_AND_INV_CB when initializing DCC

2019-03-19 Thread Samuel Pitoiset
After having a deeper look at the cache flushes when initializing DCC, it seems like we are dumb. In case the compute path is used for clearing DCC, we set the following flags: - CS_PARTIAL_FLUSH - INV_VMEM_L1 - WRITEBACK_GLOBAL_L2 - FLUSH_AND_INV_CB - FLUSH_ANV_INV_CB_META On GFX9, the

Re: [Mesa-dev] [PATCH 2/3] radv: remove unnecessary FLUSH_AND_INV_CB when initializing DCC

2019-03-19 Thread Samuel Pitoiset
On 3/19/19 1:56 PM, Bas Nieuwenhuizen wrote: That it does not use it is exactly why we need to make sure the CB data is not in the CB cache by flushing it? Why only for DCC? On Tue, Mar 19, 2019 at 12:15 PM Samuel Pitoiset wrote: The clear operation (ie. compute) doesn't use the CB caches.

Re: [Mesa-dev] [PATCH 2/3] radv: remove unnecessary FLUSH_AND_INV_CB when initializing DCC

2019-03-19 Thread Bas Nieuwenhuizen
That it does not use it is exactly why we need to make sure the CB data is not in the CB cache by flushing it? On Tue, Mar 19, 2019 at 12:15 PM Samuel Pitoiset wrote: > > The clear operation (ie. compute) doesn't use the CB caches. > > Signed-off-by: Samuel Pitoiset > --- >

[Mesa-dev] [PATCH 2/3] radv: remove unnecessary FLUSH_AND_INV_CB when initializing DCC

2019-03-19 Thread Samuel Pitoiset
The clear operation (ie. compute) doesn't use the CB caches. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index