Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-26 Thread Kenneth Graunke
On Monday, January 23, 2017 9:13:38 AM PST Jason Ekstrand wrote: > On Mon, Jan 23, 2017 at 4:59 AM, Ilia Mirkin wrote: > > > On Mon, Jan 23, 2017 at 1:42 AM, Kenneth Graunke > > wrote: > > > + *ymin = MIN2(ndc_gb_ymin, ndc_gb_ymax); > > > > Should this be limited on the negative end of the

Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-26 Thread Kenneth Graunke
On Thursday, January 26, 2017 10:18:32 AM PST Pohjolainen, Topi wrote: > On Sun, Jan 22, 2017 at 10:42:17PM -0800, Kenneth Graunke wrote: > > From: Jason Ekstrand > > > > (Patch co-authored by Jason and Ken.) > > > > We scaled the guardband based on the viewport size, but failed to > > take into

Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-26 Thread Pohjolainen, Topi
On Sun, Jan 22, 2017 at 10:42:17PM -0800, Kenneth Graunke wrote: > From: Jason Ekstrand > > (Patch co-authored by Jason and Ken.) > > We scaled the guardband based on the viewport size, but failed to > take into account the translation portion of the viewport transform. > > This meant the guard

Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-23 Thread Jason Ekstrand
On Mon, Jan 23, 2017 at 4:59 AM, Ilia Mirkin wrote: > On Mon, Jan 23, 2017 at 1:42 AM, Kenneth Graunke > wrote: > > + *ymin = MIN2(ndc_gb_ymin, ndc_gb_ymax); > > Should this be limited on the negative end of the range? > > > + *ymax = MIN2(MAX2(ndc_gb_ymin, ndc_gb_ymax), 16383); > > An

Re: [Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-23 Thread Ilia Mirkin
On Mon, Jan 23, 2017 at 1:42 AM, Kenneth Graunke wrote: > + *ymin = MIN2(ndc_gb_ymin, ndc_gb_ymax); Should this be limited on the negative end of the range? > + *ymax = MIN2(MAX2(ndc_gb_ymin, ndc_gb_ymax), 16383); And should this be a different value for gen6? Perhaps based on gb_size

[Mesa-dev] [PATCH 2/4] i965: Use a better guardband calculation.

2017-01-22 Thread Kenneth Graunke
From: Jason Ekstrand (Patch co-authored by Jason and Ken.) We scaled the guardband based on the viewport size, but failed to take into account the translation portion of the viewport transform. This meant the guardband was always centered around the origin. We want it to be centered around the