Re: [Mesa-dev] [PATCH 3/3] st/mesa: don't mark the program as in cache_fallback when there is cache miss

2017-05-18 Thread Timothy Arceri
Actually no this will just cause us to load from the cache again. I'm not sure why this was working on the test I was using. We might need to try something else. We could maybe introduce another flag just for now that overrides the cache_fallback check in shader_cache_read_program_metadata()

Re: [Mesa-dev] [PATCH 3/3] st/mesa: don't mark the program as in cache_fallback when there is cache miss

2017-05-17 Thread Timothy Arceri
On 18/05/17 15:22, Timothy Arceri wrote: When we fallback currently the gl_program objects are re-allocated. This is likely to change when the i965 cache lands, but for now this fixes a crash when using MESA_GLSL=cache_fb. This env var simulates the fallback path taken when a tgsi cache item

[Mesa-dev] [PATCH 3/3] st/mesa: don't mark the program as in cache_fallback when there is cache miss

2017-05-17 Thread Timothy Arceri
When we fallback currently the gl_program objects are re-allocated. This is likely to change when the i965 cache lands, but for now this fixes a crash when using MESA_GLSL=cache_fb. This env var simulates the fallback path taken when a tgsi cache item doesn't exist due to being evicted previously