Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-10 Thread Brian Paul
On 11/08/2017 08:27 PM, Brian Paul wrote: On 11/08/2017 08:12 PM, Brian Paul wrote: On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-08 Thread Brian Paul
On 11/08/2017 08:12 PM, Brian Paul wrote: On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea will work for GCC and MSVC but only for C++

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-08 Thread Brian Paul
On 11/08/2017 06:28 PM, Ian Romanick wrote: Any thoughts about my data using __attribute__((__packed__))? Sorry, I didn't have time to dig into it. I took a look this evening. I think the ENUM_8BIT idea will work for GCC and MSVC but only for C++ sources. MSVC doesn't like the sized enum

Re: [Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-08 Thread Ian Romanick
Any thoughts about my data using __attribute__((__packed__))? On 11/07/2017 04:07 PM, Brian Paul wrote: > Declare glsl_type::sampled_type as glsl_base_type as we do for the > base_type field. And make base_type a bitfield to save a few bytes. > > Update glsl_type constructor to take

[Mesa-dev] [PATCH 3/4] glsl: s/unsigned/glsl_base_type/ in glsl type code (v2)

2017-11-07 Thread Brian Paul
Declare glsl_type::sampled_type as glsl_base_type as we do for the base_type field. And make base_type a bitfield to save a few bytes. Update glsl_type constructor to take glsl_base_type instead of unsigned and pass GLSL_TYPE_VOID instead of zero. No Piglit regressions with llvmpipe. v2: -