Re: [Mesa-dev] [PATCH 3/4] panfrost/midgard: Handle i2b constant

2019-03-26 Thread Alyssa Rosenzweig
> Just an observation... > > f2b(0x8000) == false > i2b(0x8000) == true > > I haven't read surrounding code, but if the handling of f2b and i2b is > entirely identical, you'll run into trouble. Both are being lowered to fne/ine instructions; this hunk is just to force the second

Re: [Mesa-dev] [PATCH 3/4] panfrost/midgard: Handle i2b constant

2019-03-26 Thread Ilia Mirkin
Just an observation... f2b(0x8000) == false i2b(0x8000) == true I haven't read surrounding code, but if the handling of f2b and i2b is entirely identical, you'll run into trouble. Cheers, -ilia On Tue, Mar 26, 2019 at 12:59 AM Alyssa Rosenzweig wrote: > > Fixes >

[Mesa-dev] [PATCH 3/4] panfrost/midgard: Handle i2b constant

2019-03-25 Thread Alyssa Rosenzweig
Fixes dEQP-GLES2.functional.shaders.conversions.scalar_to_scalar.int_to_bool_fragment Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/midgard/midgard_compile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git