Re: [Mesa-dev] [PATCH 3/8] st/mesa: add st_invalidate_buffers() helper

It would be better if the function wasn't inline and was placed before st_invalidate_state to keep those two together. Marek On Wed, Jun 7, 2017 at 8:02 AM, Timothy Arceri wrote: > --- > src/mesa/state_tracker/st_cb_fbo.c | 5 +++-- >

Re: [Mesa-dev] [PATCH 3/8] st/mesa: add st_invalidate_buffers() helper

It would be great if you could put a comment on the new function explaining what it's doing. Many readers would not know why invalidating framebuffer state requires invalidating all that other state. Thanks. -Brian On 06/07/2017 12:02 AM, Timothy Arceri wrote: ---

Re: [Mesa-dev] [PATCH 3/8] st/mesa: add st_invalidate_buffers() helper

Reviewed-by: Samuel Pitoiset On 06/07/2017 08:02 AM, Timothy Arceri wrote: --- src/mesa/state_tracker/st_cb_fbo.c | 5 +++-- src/mesa/state_tracker/st_context.c | 15 +++ src/mesa/state_tracker/st_context.h | 16 +++-

[Mesa-dev] [PATCH 3/8] st/mesa: add st_invalidate_buffers() helper

--- src/mesa/state_tracker/st_cb_fbo.c | 5 +++-- src/mesa/state_tracker/st_context.c | 15 +++ src/mesa/state_tracker/st_context.h | 16 +++- src/mesa/state_tracker/st_manager.c | 2 +- 4 files changed, 22 insertions(+), 16 deletions(-) diff --git