Re: [Mesa-dev] [PATCH 4/4] radeonsi: use SDMA for uploading data through const_uploader

2019-02-20 Thread Dieter Nützel
For the _rev2_ version (Patchwork Mesa) series is Tested-by: Dieter Nützel on Polaris 20 UH+UV working flawlessly, now. No 'measurable' speed decrease. - GREAT! Blender, FreeCAD, glmark2 all fine. But I had to have rebased part 4 (see attachment). Dieter Am 07.02.2019 02:22, schrieb Marek

Re: [Mesa-dev] [PATCH 4/4] radeonsi: use SDMA for uploading data through const_uploader

2019-02-19 Thread Marek Olšák
I'll remove the env var. Additionally, I'm amending this: diff --git a/src/gallium/drivers/radeonsi/si_buffer.c b/src/gallium/drivers/radeonsi/si_buffer.c index 3f8db7cf4f0..4936eb5a5b1 100644 --- a/src/gallium/drivers/radeonsi/si_buffer.c +++ b/src/gallium/drivers/radeonsi/si_buffer.c @@

Re: [Mesa-dev] [PATCH 4/4] radeonsi: use SDMA for uploading data through const_uploader

2019-02-11 Thread Nicolai Hähnle
On 07.02.19 02:22, Marek Olšák wrote: + bool use_sdma_upload = sscreen->info.has_dedicated_vram && sctx->dma_cs && debug_get_bool_option("SDMA", true); Could you please namespace the environment variable, e.g. RADEONSI_SDMA? Apart from that, series is Reviewed-by: Nicolai Hähnle +

Re: [Mesa-dev] [PATCH 4/4] radeonsi: use SDMA for uploading data through const_uploader

2019-02-07 Thread Alex Deucher
On Thu, Feb 7, 2019 at 2:47 PM Axel Davy wrote: > > On 07/02/2019 02:22, Marek Olšák wrote: > > > > + bool use_sdma_upload = sscreen->info.has_dedicated_vram && > > sctx->dma_cs && debug_get_bool_option("SDMA", true); > > + sctx->b.const_uploader = u_upload_create(>b, 256 * 1024, > > +

Re: [Mesa-dev] [PATCH 4/4] radeonsi: use SDMA for uploading data through const_uploader

2019-02-07 Thread Axel Davy
On 07/02/2019 02:22, Marek Olšák wrote: + bool use_sdma_upload = sscreen->info.has_dedicated_vram && sctx->dma_cs && debug_get_bool_option("SDMA", true); + sctx->b.const_uploader = u_upload_create(>b, 256 * 1024, +0, PIPE_USAGE_DEFAULT, +

[Mesa-dev] [PATCH 4/4] radeonsi: use SDMA for uploading data through const_uploader

2019-02-06 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_buffer.c | 56 ++-- src/gallium/drivers/radeonsi/si_dma_cs.c | 19 src/gallium/drivers/radeonsi/si_gfx_cs.c | 42 +++--- src/gallium/drivers/radeonsi/si_pipe.c | 23 ++