Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-14 Thread Erik Faye-Lund
Sounds perfect, thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-14 Thread Juan A. Suarez Romero
On Tue, 2018-12-11 at 15:29 +0100, Erik Faye-Lund wrote: > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > > Virglrenderer does the wrong thing when given an instance divisor; > > it tries to use the element-index rather than the binding-index as > > the argument to

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-13 Thread Gert Wollny
This fixes rendering in Supertuxkart, Serious Sam 3, and Shadow Warrior via virgl for me. So for the series: Tested-By: Gert Wollny Am Dienstag, den 11.12.2018, 15:26 +0100 schrieb Erik Faye-Lund: > Virglrenderer does the wrong thing when given an instance divisor; > it tries to use the

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-12 Thread Mathias Fröhlich
Good Morning, > > One thing, may be. Do you want to add some documentation beside the > > git log message why we do something surprising like replicating out > > the > > buffers and assigning new buffer indices? Just something that allows > > a reader to get an idea why non straight forward

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-12 Thread Erik Faye-Lund
On Wed, 2018-12-12 at 06:18 +0100, Mathias Fröhlich wrote: > Erik, > > On Tuesday, 11 December 2018 15:29:49 CET Erik Faye-Lund wrote: > > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > > > Virglrenderer does the wrong thing when given an instance > > > divisor; > > > it tries to use

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-11 Thread Mathias Fröhlich
Erik, On Tuesday, 11 December 2018 15:29:49 CET Erik Faye-Lund wrote: > On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > > Virglrenderer does the wrong thing when given an instance divisor; > > it tries to use the element-index rather than the binding-index as > > the argument to

Re: [Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-11 Thread Erik Faye-Lund
On Tue, 2018-12-11 at 15:26 +0100, Erik Faye-Lund wrote: > Virglrenderer does the wrong thing when given an instance divisor; > it tries to use the element-index rather than the binding-index as > the argument to glVertexBindingDivisor(). This worked fine as long > as there was a 1:1 relationship

[Mesa-dev] [PATCH 4/4] virgl: work around bad assumptions in virglrenderer

2018-12-11 Thread Erik Faye-Lund
Virglrenderer does the wrong thing when given an instance divisor; it tries to use the element-index rather than the binding-index as the argument to glVertexBindingDivisor(). This worked fine as long as there was a 1:1 relationship between elements and bindings, which was the case util