Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-09-27 Thread Emil Velikov
On 26 September 2017 at 18:08, Juan A. Suarez Romero wrote: > On Wed, 2017-09-06 at 15:07 +0100, Emil Velikov wrote: >> On 5 August 2017 at 00:25, Emil Velikov wrote: >> > From: Emil Velikov >> > >> > As mentioned in

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-09-26 Thread Juan A. Suarez Romero
On Wed, 2017-09-06 at 15:07 +0100, Emil Velikov wrote: > On 5 August 2017 at 00:25, Emil Velikov wrote: > > From: Emil Velikov > > > > As mentioned in previous commit the negative tests in dEQP expect the > > arguments to be evaluated in

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-09-06 Thread Emil Velikov
On 5 August 2017 at 00:25, Emil Velikov wrote: > From: Emil Velikov > > As mentioned in previous commit the negative tests in dEQP expect the > arguments to be evaluated in particular order. > > Namely - first the dpy, then the config,

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-09 Thread Tapani Pälli
On 08/09/2017 12:30 PM, Eric Engestrom wrote: On Wednesday, 2017-08-09 08:35:04 +0300, Tapani Pälli wrote: On 08/08/2017 08:07 PM, Emil Velikov wrote: On 8 August 2017 at 16:10, Eric Engestrom wrote: On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote:

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-09 Thread Eric Engestrom
On Wednesday, 2017-08-09 08:35:04 +0300, Tapani Pälli wrote: > On 08/08/2017 08:07 PM, Emil Velikov wrote: > > On 8 August 2017 at 16:10, Eric Engestrom wrote: > > > On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: > > > > From: Emil Velikov

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Tapani Pälli
On 08/08/2017 08:07 PM, Emil Velikov wrote: On 8 August 2017 at 16:10, Eric Engestrom wrote: On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: From: Emil Velikov As mentioned in previous commit the negative tests in dEQP

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Tapani Pälli
On 08/08/2017 05:20 PM, Emil Velikov wrote: On 8 August 2017 at 08:21, Tapani Pälli wrote: On 08/05/2017 02:25 AM, Emil Velikov wrote: From: Emil Velikov As mentioned in previous commit the negative tests in dEQP expect the arguments to

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 16:10, Eric Engestrom wrote: > On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> As mentioned in previous commit the negative tests in dEQP expect the >> arguments to be evaluated in

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Eric Engestrom
On Saturday, 2017-08-05 00:25:49 +0100, Emil Velikov wrote: > From: Emil Velikov > > As mentioned in previous commit the negative tests in dEQP expect the > arguments to be evaluated in particular order. The spec doesn't say that, so the test is wrong. Changing it in

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Emil Velikov
On 8 August 2017 at 08:21, Tapani Pälli wrote: > > > On 08/05/2017 02:25 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> As mentioned in previous commit the negative tests in dEQP expect the >> arguments to be evaluated in particular

Re: [Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-08 Thread Tapani Pälli
On 08/05/2017 02:25 AM, Emil Velikov wrote: From: Emil Velikov As mentioned in previous commit the negative tests in dEQP expect the arguments to be evaluated in particular order. Namely - first the dpy, then the config, followed by the surface/window. Move the

[Mesa-dev] [PATCH 4/8] egl: rework input validation order in _eglCreateWindowSurfaceCommon

2017-08-04 Thread Emil Velikov
From: Emil Velikov As mentioned in previous commit the negative tests in dEQP expect the arguments to be evaluated in particular order. Namely - first the dpy, then the config, followed by the surface/window. Move the check further down or executing the test below