Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-21 Thread Aaron Watry
On Wed, Mar 21, 2018 at 2:52 PM, Aaron Watry wrote: > On Wed, Mar 21, 2018 at 2:37 PM, Mark Janes wrote: >> Aaron, this patch breaks the meson build-test in our CI: >> >> ../src/gallium/state_trackers/clover/llvm/invocation.cpp:88:36: error: >>

Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-21 Thread Aaron Watry
On Wed, Mar 21, 2018 at 2:37 PM, Mark Janes wrote: > Aaron, this patch breaks the meson build-test in our CI: > > ../src/gallium/state_trackers/clover/llvm/invocation.cpp:88:36: error: > ‘lang_opencl10’ is not a member of ‘clang::LangStandard’ > { 100,

Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-21 Thread Mark Janes
Aaron, this patch breaks the meson build-test in our CI: ../src/gallium/state_trackers/clover/llvm/invocation.cpp:88:36: error: ‘lang_opencl10’ is not a member of ‘clang::LangStandard’ { 100, clang::LangStandard::lang_opencl10}, configured with: meson -Dbuild-tests=true

Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-21 Thread Jan Vesely
On Tue, 2018-03-20 at 20:23 -0500, Aaron Watry wrote: > ping. > > This is the last of the series that still needs review. Hi, sorry for the delay. I once again really dislike the approach of implement and enable in separate patches, because it breaks bisection (I think 4 and 5 should be

Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-21 Thread Pierre Moreau
Oops, sorry. Reviewed-by: Pierre Moreau Thanks again for the series! Pierre On 2018-03-20 — 20:23, Aaron Watry wrote: > ping. > > This is the last of the series that still needs review. > > --Aaron > > On Thu, Mar 1, 2018 at 1:39 PM, Aaron Watry

Re: [Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-20 Thread Aaron Watry
ping. This is the last of the series that still needs review. --Aaron On Thu, Mar 1, 2018 at 1:39 PM, Aaron Watry wrote: > Use get_language_version to calculate default cl standard based on > device capabilities and -cl-std specified in build options. > > v4: Squash the

[Mesa-dev] [PATCH 5/5] clover: Dynamically calculate __OPENCL_VERSION__ and CLC language version

2018-03-01 Thread Aaron Watry
Use get_language_version to calculate default cl standard based on device capabilities and -cl-std specified in build options. v4: Squash the __OPENCL_VERSION__ and CLC language version patches v3: (Jan) Allow device_version up to 2.2 while device_clc_version only goes to 2.0 Use