Re: [Mesa-dev] [PATCH 5/5 v2] i965: Add support for ARB_copy_image

2014-08-04 Thread Neil Roberts
One case where the memcpy path won't work is if the source and destination are the same buffer. In that case it tries to map the texture twice and hits an assert. I think this could be a legitimate use case if the source and destination rectangles don't overlap. The extension spec isn't very clear

Re: [Mesa-dev] [PATCH 5/5 v2] i965: Add support for ARB_copy_image

2014-08-04 Thread Jason Ekstrand
Thanks Neil, I'll make that change. Should be simple enough. --Jason On Mon, Aug 4, 2014 at 10:51 AM, Neil Roberts n...@linux.intel.com wrote: One case where the memcpy path won't work is if the source and destination are the same buffer. In that case it tries to map the texture twice and

[Mesa-dev] [PATCH 5/5 v2] i965: Add support for ARB_copy_image

2014-08-01 Thread Jason Ekstrand
This, together with the meta path, provides a almost-complete implemetation of ARB_copy_image. The only case that won't work is if one of the textures is compressed and has a pitch greater than INT16_MAX. I think that's good enough to justify turning on the extension. v2: Add a fallback memcpy