Re: [Mesa-dev] [PATCH 5/6] i965/vec4: Propagate conditional modifiers from compares to adds

Would be really good to extend the vec4 tests too. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 5/6] i965/vec4: Propagate conditional modifiers from compares to adds

On 22/03/18 19:05, Ian Romanick wrote: > On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: >> Any reason to not add tests on test_vec4_cmod_propagation as the fs >> equivalent did? > Laziness. :) Ok, I guess that those could be added later on a different patch, independently of this one. >> Also,

Re: [Mesa-dev] [PATCH 5/6] i965/vec4: Propagate conditional modifiers from compares to adds

On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: > Any reason to not add tests on test_vec4_cmod_propagation as the fs > equivalent did? Laziness. :) > Also, two small comments below. > > On 22/03/18 01:58, Ian Romanick wrote: >> From: Ian Romanick >> >> No changes on

Re: [Mesa-dev] [PATCH 5/6] i965/vec4: Propagate conditional modifiers from compares to adds

Any reason to not add tests on test_vec4_cmod_propagation as the fs equivalent did? Also, two small comments below. On 22/03/18 01:58, Ian Romanick wrote: > From: Ian Romanick > > No changes on Broadwell and later becuase those plaforms do not use the > vec4 backend at

[Mesa-dev] [PATCH 5/6] i965/vec4: Propagate conditional modifiers from compares to adds

From: Ian Romanick No changes on Broadwell and later becuase those plaforms do not use the vec4 backend at all. Ivy Bridge and Haswell had similar results. (Ivy Bridge shown) total instructions in shared programs: 11682119 -> 11681056 (<.01%) instructions in affected