Re: [Mesa-dev] [PATCH 5/7] intel: Remove silly check for !bufmgr.

2013-09-27 Thread Eric Anholt
Ian Romanick writes: > On 09/26/2013 09:19 PM, Kenneth Graunke wrote: >> On 09/26/2013 08:36 PM, Eric Anholt wrote: >>> If bufmgr didn't get created, then screen creation failed, and we never >>> should have got here in the first place. This was added by Chris Wilson >>> in 2010 with no explanat

Re: [Mesa-dev] [PATCH 5/7] intel: Remove silly check for !bufmgr.

2013-09-27 Thread Ian Romanick
On 09/26/2013 09:19 PM, Kenneth Graunke wrote: > On 09/26/2013 08:36 PM, Eric Anholt wrote: >> If bufmgr didn't get created, then screen creation failed, and we never >> should have got here in the first place. This was added by Chris Wilson >> in 2010 with no explanation for why it would be neede

Re: [Mesa-dev] [PATCH 5/7] intel: Remove silly check for !bufmgr.

2013-09-27 Thread Chris Wilson
On Thu, Sep 26, 2013 at 08:36:00PM -0700, Eric Anholt wrote: > If bufmgr didn't get created, then screen creation failed, and we never > should have got here in the first place. This was added by Chris Wilson > in 2010 with no explanation for why it would be needed. Because it prevented a segfaul

Re: [Mesa-dev] [PATCH 5/7] intel: Remove silly check for !bufmgr.

2013-09-26 Thread Kenneth Graunke
On 09/26/2013 08:36 PM, Eric Anholt wrote: > If bufmgr didn't get created, then screen creation failed, and we never > should have got here in the first place. This was added by Chris Wilson > in 2010 with no explanation for why it would be needed. > --- > src/mesa/drivers/dri/i915/intel_context.

[Mesa-dev] [PATCH 5/7] intel: Remove silly check for !bufmgr.

2013-09-26 Thread Eric Anholt
If bufmgr didn't get created, then screen creation failed, and we never should have got here in the first place. This was added by Chris Wilson in 2010 with no explanation for why it would be needed. --- src/mesa/drivers/dri/i915/intel_context.c | 6 -- src/mesa/drivers/dri/i965/intel_context