Re: [Mesa-dev] [PATCH 5/9] intel/compiler: relax brw_eu_validate for byte raw movs

2019-01-23 Thread Chema Casanova
El 23/1/19 a las 7:26, Matt Turner escribió: > On Sun, Jul 8, 2018 at 5:27 PM, Jose Maria Casanova Crespo > wrote: >> When the destination is a BYTE type allow raw movs >> even if the stride is not exact multiple of destination >> type and exec type, execution type is Word and its size is 2. >>

Re: [Mesa-dev] [PATCH 5/9] intel/compiler: relax brw_eu_validate for byte raw movs

2019-01-22 Thread Matt Turner
On Tue, Jan 22, 2019 at 10:26 PM Matt Turner wrote: > Was this just something that you noticed by inspection? With the patch reverted I see some validation failures in dEQP-VK.spirv_assembly.instruction.compute.8bit_storage.push_constant_8_to_16.scalar_uint and friends. mov(16) g10<4>B

Re: [Mesa-dev] [PATCH 5/9] intel/compiler: relax brw_eu_validate for byte raw movs

2019-01-22 Thread Matt Turner
On Sun, Jul 8, 2018 at 5:27 PM, Jose Maria Casanova Crespo wrote: > When the destination is a BYTE type allow raw movs > even if the stride is not exact multiple of destination > type and exec type, execution type is Word and its size is 2. > > This restriction was only allowing stride==2

[Mesa-dev] [PATCH 5/9] intel/compiler: relax brw_eu_validate for byte raw movs

2018-07-08 Thread Jose Maria Casanova Crespo
When the destination is a BYTE type allow raw movs even if the stride is not exact multiple of destination type and exec type, execution type is Word and its size is 2. This restriction was only allowing stride==2 destinations for 8-bit types. Reviewed-by: Jason Ekstrand ---