Re: [Mesa-dev] [PATCH 8/9] Revert "radeonsi: fix potential use-after-free of debug callbacks"

2018-04-24 Thread Marek Olšák
I just sent a patch that fixes the deadlock. Marek On Tue, Apr 24, 2018 at 4:40 PM, Marek Olšák wrote: > On Wed, Apr 18, 2018 at 6:11 AM, Nicolai Hähnle > wrote: > >> How can this possibly deadlock? Is this during process exit, like in the >> case where we got a deadlock when LLVM called abort

Re: [Mesa-dev] [PATCH 8/9] Revert "radeonsi: fix potential use-after-free of debug callbacks"

2018-04-24 Thread Marek Olšák
On Wed, Apr 18, 2018 at 6:11 AM, Nicolai Hähnle wrote: > How can this possibly deadlock? Is this during process exit, like in the > case where we got a deadlock when LLVM called abort()? > No. It deadlocks at the start. All threads are waiting on the barrier. The barrier should unblock all threa

Re: [Mesa-dev] [PATCH 8/9] Revert "radeonsi: fix potential use-after-free of debug callbacks"

2018-04-18 Thread Nicolai Hähnle
How can this possibly deadlock? Is this during process exit, like in the case where we got a deadlock when LLVM called abort()? The rest of the series is Reviewed-by: Nicolai Hähnle On 17.04.2018 02:52, Marek Olšák wrote: From: Marek Olšák This reverts commit b650fc09c3a35ca624aad5fe4b5c3

[Mesa-dev] [PATCH 8/9] Revert "radeonsi: fix potential use-after-free of debug callbacks"

2018-04-16 Thread Marek Olšák
From: Marek Olšák This reverts commit b650fc09c3a35ca624aad5fe4b5c34867708f116. There is a 100%-reproducible deadlock if I increase the number of compiler queues. Also: Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105379 Cc: 18.0 --- src/gallium/drivers/radeonsi/si_pipe.c | 4