Re: [Mesa-dev] [PATCH 9/9] nouveau: s/nv04_surface_/nouveau_surface_/

2017-05-19 Thread Francisco Jerez
Ilia Mirkin writes: > I kinda see it both ways - yeah, the functions are the same and it's > all shared, so your patch makes sense. OTOH, all of these functions > (which do anything) have a nv04/nv10/nv20 prefix, which makes it > easier to separate stuff out by generation

Re: [Mesa-dev] [PATCH 9/9] nouveau: s/nv04_surface_/nouveau_surface_/

2017-05-19 Thread Ilia Mirkin
I kinda see it both ways - yeah, the functions are the same and it's all shared, so your patch makes sense. OTOH, all of these functions (which do anything) have a nv04/nv10/nv20 prefix, which makes it easier to separate stuff out by generation if need be. So I think in a perfect world, the actual

[Mesa-dev] [PATCH 9/9] nouveau: s/nv04_surface_/nouveau_surface_/

2017-05-19 Thread Ian Romanick
From: Ian Romanick After moving the contents of nv04_surface.c to nouveau_surface.c, rename all the functions. Signed-off-by: Ian Romanick Cc: Ilia Mirkin --- src/mesa/drivers/dri/nouveau/nouveau_surface.c | 60