Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-10-01 Thread Daniel Stone
Hi Boris, On Tue, 1 Oct 2019 at 09:25, Boris Brezillon wrote: > On Mon, 2 Sep 2019 16:32:01 +0200 Michel Dänzer wrote: > > On 2019-08-30 7:00 p.m., Boris Brezillon wrote: > > > So, next question is, do you think it's acceptable to pass a > > > DRIcontext here, and if not, do you have any idea

Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-10-01 Thread Boris Brezillon
On Mon, 2 Sep 2019 16:32:01 +0200 Michel Dänzer wrote: > On 2019-08-30 7:00 p.m., Boris Brezillon wrote: > > > > So, next question is, do you think it's acceptable to pass a > > DRIcontext here, and if not, do you have any idea how to solve this > > problem? > > Hmm, not sure. Maybe it would

Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-09-02 Thread Michel Dänzer
On 2019-08-30 7:00 p.m., Boris Brezillon wrote: > > So, next question is, do you think it's acceptable to pass a > DRIcontext here, and if not, do you have any idea how to solve this > problem? Hmm, not sure. Maybe it would be better to explicitly pass in the __DRIimage* to which the damage

Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-08-30 Thread Boris Brezillon
On Fri, 30 Aug 2019 18:56:52 +0200 Michel Dänzer wrote: > On 2019-08-30 6:52 p.m., Boris Brezillon wrote: > > On Fri, 30 Aug 2019 18:43:59 +0200 > > Michel Dänzer wrote: > > > >>> diff --git a/include/GL/internal/dri_interface.h > >>> b/include/GL/internal/dri_interface.h > >>> index

Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-08-30 Thread Michel Dänzer
On 2019-08-30 6:52 p.m., Boris Brezillon wrote: > On Fri, 30 Aug 2019 18:43:59 +0200 > Michel Dänzer wrote: > >>> diff --git a/include/GL/internal/dri_interface.h >>> b/include/GL/internal/dri_interface.h >>> index 4c60d349ddd5..e04bed689219 100644 >>> --- a/include/GL/internal/dri_interface.h

Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-08-30 Thread Boris Brezillon
On Fri, 30 Aug 2019 18:43:59 +0200 Michel Dänzer wrote: > On 2019-08-29 1:54 p.m., Boris Brezillon wrote: > > So we can call st_validate_state() from dri2_set_damage_region() in > > order to update the BACK_LEFT attachement before using it. If we don't > > do that, the resource passed to

Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-08-30 Thread Michel Dänzer
On 2019-08-29 1:54 p.m., Boris Brezillon wrote: > So we can call st_validate_state() from dri2_set_damage_region() in > order to update the BACK_LEFT attachement before using it. If we don't > do that, the resource passed to pipe_screen->set_damage_region() might > be wrong. > > Signed-off-by:

Re: [Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-08-29 Thread The Rasterman
On Thu, 29 Aug 2019 13:54:16 +0200 Boris Brezillon said: These 2 do improve things, but once you start doing BindFramebuffer()'s as part of the render cycle ... its back to rendering artifacts. I am not quite sure exactly what yet. I need to capture some output and traces to get a better idea of

[Mesa-dev] [PATCH RFC 2/2] dri: Pass a __DRIcontext to ->set_damage_region()

2019-08-29 Thread Boris Brezillon
So we can call st_validate_state() from dri2_set_damage_region() in order to update the BACK_LEFT attachement before using it. If we don't do that, the resource passed to pipe_screen->set_damage_region() might be wrong. Signed-off-by: Boris Brezillon --- Hi, I honestly don't know if this is the