[Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

2014-01-21 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- src/glsl/ast.h | 44 +++ src/glsl/ast_array_index.cpp| 13 src/glsl/ast_to_hir.cpp | 160 +++- src/glsl/ast_type.cpp | 8 +-

Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

2014-01-21 Thread Timothy Arceri
Hi Paul Thanks for the thorough review and taking the time to explain how to make improvements. I can already see a number of improvements that can be made to patch 5 based on the suggestions you have already made so you could hold off reviewing that one if you havent started already and I've

Re: [Mesa-dev] [PATCH V2 3/8] glsl: Add array specifier to ast code

2014-01-21 Thread Paul Berry
On 21 January 2014 14:54, Timothy Arceri t_arc...@yahoo.com.au wrote: Hi Paul Thanks for the thorough review and taking the time to explain how to make improvements. I can already see a number of improvements that can be made to patch 5 based on the suggestions you have already made so you