Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-24 Thread Emil Velikov
On 23 May 2017 at 18:02, Daniel Stone wrote: > Hi Varad, > > On 23 May 2017 at 14:19, Varad Gautam wrote: >> On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote: >>> On 19 May 2017 at 10:37, Daniel Stone wrote: >>> > +

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-23 Thread Daniel Stone
Hi Varad, On 23 May 2017 at 14:19, Varad Gautam wrote: > On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote: >> On 19 May 2017 at 10:37, Daniel Stone wrote: >> > + if (external_only != NULL) { >> > + for (i = 0; i < *count && i < max;

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-23 Thread Varad Gautam
On Mon, 2017-05-22 at 14:03 +0100, Emil Velikov wrote: > Hi Dan, > > On 19 May 2017 at 10:37, Daniel Stone wrote: > > > > From: Varad Gautam > > > > query and return supported dmabuf format modifiers for > > EGL_EXT_image_dma_buf_import_modifiers.

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-22 Thread Emil Velikov
Hi Dan, On 19 May 2017 at 10:37, Daniel Stone wrote: > From: Varad Gautam > > query and return supported dmabuf format modifiers for > EGL_EXT_image_dma_buf_import_modifiers. > > v2: move format check to the driver instead of making format queries >

Re: [Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-19 Thread Jason Ekstrand
Just FYI: I'm not checking that you implement the EGL API correctly. I'm mostly checking for whether or not it's using DRI correctly. On Fri, May 19, 2017 at 2:37 AM, Daniel Stone wrote: > From: Varad Gautam > > query and return supported dmabuf

[Mesa-dev] [PATCH v13 07/36] egl: implement eglQueryDmaBufModifiersEXT

2017-05-19 Thread Daniel Stone
From: Varad Gautam query and return supported dmabuf format modifiers for EGL_EXT_image_dma_buf_import_modifiers. v2: move format check to the driver instead of making format queries here and then checking. v3: Check DRIimageExtension version before query (Daniel