Re: [Mesa-dev] [PATCH v13 24/36] i965/miptree: Add a return for updating of winsys

2017-05-19 Thread Jason Ekstrand
It's a bit annoying, but I think this would all make more sense if we moved 23 and 24 to before 19. Then we could drop no_aux from 21. Then again, I'm sure Ben has some good reason why that's not practical and I'm fine with leaving the order as-is. It's hard to review but there's a lot of

[Mesa-dev] [PATCH v13 24/36] i965/miptree: Add a return for updating of winsys

2017-05-19 Thread Daniel Stone
From: Ben Widawsky There is nothing particularly useful to do currently if the update fails, but there is no point carrying on either. As a result, this has a behavior change. v2: Make the return type a bool (Topi) v3: Don't leak the bo if update_winsys_renderbuffer fails.