Re: [Mesa-dev] [PATCH v2] anv: fix number of planes for depth & stencil

2018-04-16 Thread Lionel Landwerlin
Thanks a lot Juan, it looks all good to me :) On 16/04/18 04:09, Juan A. Suarez Romero wrote: On Thu, 2018-04-12 at 14:54 -0700, Lionel Landwerlin wrote: We're not counting correctly with depth & stencil images. Additionally we need to move an assert that is meant just for color attachments.

Re: [Mesa-dev] [PATCH v2] anv: fix number of planes for depth & stencil

2018-04-16 Thread Juan A. Suarez Romero
On Thu, 2018-04-12 at 14:54 -0700, Lionel Landwerlin wrote: > We're not counting correctly with depth & stencil images. > > Additionally we need to move an assert that is meant just for color > attachments. > > v2: Move an assert() (Reported by Craig) > Change aspect mask checks (Francesco)

Re: [Mesa-dev] [PATCH v2] anv: fix number of planes for depth & stencil

2018-04-12 Thread Nanley Chery
On Thu, Apr 12, 2018 at 02:54:59PM -0700, Lionel Landwerlin wrote: > We're not counting correctly with depth & stencil images. > > Additionally we need to move an assert that is meant just for color > attachments. > > v2: Move an assert() (Reported by Craig) > Change aspect mask checks

[Mesa-dev] [PATCH v2] anv: fix number of planes for depth & stencil

2018-04-12 Thread Lionel Landwerlin
We're not counting correctly with depth & stencil images. Additionally we need to move an assert that is meant just for color attachments. v2: Move an assert() (Reported by Craig) Change aspect mask checks (Francesco) Signed-off-by: Lionel Landwerlin Fixes: