Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-27 Thread Alejandro Piñeiro
On 27/08/18 12:08, Vadym Shovkoplias wrote: > I haven't got write permissions, so I'll appreciate if someone can > push it. > Thanks! Just done: https://gitlab.freedesktop.org/mesa/mesa/commit/4a8444d5bc865119218eca8674e5614535f4829e > > On Mon, Aug 27, 2018 at 12:52 PM, Alejandro Piñeiro >

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-27 Thread Vadym Shovkoplias
I haven't got write permissions, so I'll appreciate if someone can push it. Thanks! On Mon, Aug 27, 2018 at 12:52 PM, Alejandro Piñeiro wrote: > On 27/08/18 11:12, Vadym Shovkoplias wrote: > > Hi Timothy, Alejandro, Marek, > > Thanks for review! Can we merge the patch now ? > > > Yes, as soon

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-27 Thread Alejandro Piñeiro
On 27/08/18 11:12, Vadym Shovkoplias wrote: > Hi Timothy, Alejandro, Marek, > > Thanks for review! Can we merge the patch now ? Yes, as soon as a patch gets a Rb, it can be pushed to master. Do you have write permissions to do it by yourself, or do you need someone of do that in your behalf? > >

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-27 Thread Vadym Shovkoplias
Hi Timothy, Alejandro, Marek, Thanks for review! Can we merge the patch now ? On Mon, Aug 27, 2018 at 6:08 AM, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri > > > On 24/08/18 18:25, Alejandro Piñeiro wrote: > >> CCing Timothy just in case he still thinks that the original comment >>

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-26 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 24/08/18 18:25, Alejandro Piñeiro wrote: CCing Timothy just in case he still thinks that the original comment should remain as it is. In any case, it looks to me, so: Reviewed-by: Alejandro Piñeiro On 23/08/18 12:12, vadym.shovkoplias wrote: From Section

Re: [Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-24 Thread Alejandro Piñeiro
CCing Timothy just in case he still thinks that the original comment should remain as it is. In any case, it looks to me, so: Reviewed-by: Alejandro Piñeiro On 23/08/18 12:12, vadym.shovkoplias wrote: > From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: > > "Only the input variables that

[Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-23 Thread vadym.shovkoplias
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: "Only the input variables that are actually read need to be written by the previous stage; it is allowed to have superfluous declarations of input variables." Fixes: * interstage-multiple-shader-objects.shader_test v2:

[Mesa-dev] [PATCH v2] glsl/linker: Allow unused in blocks which are not declated on previous stage

2018-08-22 Thread vadym.shovkoplias
From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: "Only the input variables that are actually read need to be written by the previous stage; it is allowed to have superfluous declarations of input variables." Fixes: * interstage-multiple-shader-objects.shader_test v2: