Re: [Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers (v2)

2016-06-14 Thread Emil Velikov
Hi Tomasz On 13 June 2016 at 11:53, Tomasz Figa wrote: > The images struct is an uninitialized local variable on the stack. If the > callback returns 0, the struct might not have been updated and so should > be considered uninitialized. Currently the code ignores the return

[Mesa-dev] [PATCH v2] i965: Check return value of screen->image.loader->getBuffers (v2)

2016-06-13 Thread Tomasz Figa
The images struct is an uninitialized local variable on the stack. If the callback returns 0, the struct might not have been updated and so should be considered uninitialized. Currently the code ignores the return value, which (depending on stack contents) might end up in reading a non-zero value