Re: [Mesa-dev] [PATCH v2] radv: Support VK_EXT_inline_uniform_block.

2019-04-17 Thread Bas Nieuwenhuizen
So I have trouble making sense of what did you change but on its own the patch looks good to me. r-b On Tue, Apr 16, 2019 at 5:26 PM Samuel Pitoiset wrote: > > From: Bas Nieuwenhuizen > > Basically just reserve the memory in the descriptor sets. > > On the shader side we construct a buffer

[Mesa-dev] [PATCH v2] radv: Support VK_EXT_inline_uniform_block.

2019-04-16 Thread Samuel Pitoiset
From: Bas Nieuwenhuizen Basically just reserve the memory in the descriptor sets. On the shader side we construct a buffer descriptor, since AFAIU VGPR indexing on 32-bit pointers in LLVM is still broken. This fully supports update after bind and variable descriptor set sizes. However, the