Re: [Mesa-dev] [PATCH v2 01/12] ac: do not force enable IDXEN for 16-bit SSBO loads

2019-03-13 Thread Bas Nieuwenhuizen
NAK. The entire thing about an index being used and possibly still constant 0 (and hence the index being constant 0 is not a sign to use the raw intrinsics) is why we now have both structurized and raw intrinsics. Don't just introduce that mistake again On Wed, Mar 13, 2019 at 11:47 AM

[Mesa-dev] [PATCH v2 01/12] ac: do not force enable IDXEN for 16-bit SSBO loads

2019-03-13 Thread Samuel Pitoiset
The struct version enables IDXEN, while the raw one disables it. When vindex is unused, the raw version is enough. Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_llvm_build.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/amd/common/ac_llvm_build.c