Re: [Mesa-dev] [PATCH v2 01/14] glsl: Add new atomic_uint built-in GLSL type.

2013-10-22 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 10/01/2013 07:15 PM, Francisco Jerez wrote: v2: Fix GLSL version in which the type became available. Add contains_atomic() convenience method. Split off atomic counter comparison error checking to a separate patch that will handle

Re: [Mesa-dev] [PATCH v2 01/14] glsl: Add new atomic_uint built-in GLSL type.

2013-10-02 Thread Kenneth Graunke
On 10/01/2013 07:15 PM, Francisco Jerez wrote: v2: Fix GLSL version in which the type became available. Add contains_atomic() convenience method. Split off atomic counter comparison error checking to a separate patch that will handle all opaque types. Include new ir_variable

Re: [Mesa-dev] [PATCH v2 01/14] glsl: Add new atomic_uint built-in GLSL type.

2013-10-02 Thread Francisco Jerez
Kenneth Graunke kenn...@whitecape.org writes: On 10/01/2013 07:15 PM, Francisco Jerez wrote: [...] @@ -441,6 +442,27 @@ struct glsl_type { } /** +* Return the amount of atomic counter storage required for a type. +*/ + unsigned atomic_size() const + { + if

[Mesa-dev] [PATCH v2 01/14] glsl: Add new atomic_uint built-in GLSL type.

2013-10-01 Thread Francisco Jerez
v2: Fix GLSL version in which the type became available. Add contains_atomic() convenience method. Split off atomic counter comparison error checking to a separate patch that will handle all opaque types. Include new ir_variable fields for atomic types. --- src/glsl/ast_to_hir.cpp