Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Kenneth Graunke
On Friday, October 20, 2017 6:52:11 PM PDT Jordan Justen wrote: > I'm now doubting the uninitialized padding explanation. I tried the > memset in the glsl_struct_field constructor as Ken mentioned, but I > also tried adding initializers for the fields in the default > constructor, and it fixed

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Ilia Mirkin
On Fri, Oct 20, 2017 at 9:52 PM, Jordan Justen wrote: > On 2017-10-20 14:14:25, Jason Ekstrand wrote: >> On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke >> wrote: >> >> > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: >> > >

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Jordan Justen
On 2017-10-20 14:14:25, Jason Ekstrand wrote: > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke > wrote: > > > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > > --- > > >

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Jason Ekstrand
On Fri, Oct 20, 2017 at 4:14 PM, Kenneth Graunke wrote: > On Friday, October 20, 2017 4:11:20 PM PDT Kenneth Graunke wrote: > > On Friday, October 20, 2017 2:14:25 PM PDT Jason Ekstrand wrote: > > > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke < >

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Kenneth Graunke
On Friday, October 20, 2017 4:11:20 PM PDT Kenneth Graunke wrote: > On Friday, October 20, 2017 2:14:25 PM PDT Jason Ekstrand wrote: > > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke > > wrote: > > > > > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Kenneth Graunke
On Friday, October 20, 2017 2:14:25 PM PDT Jason Ekstrand wrote: > On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke > wrote: > > > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > > > Signed-off-by: Jordan Justen > > > --- >

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-20 Thread Jason Ekstrand
On Thu, Oct 19, 2017 at 4:51 PM, Kenneth Graunke wrote: > On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > > Signed-off-by: Jordan Justen > > --- > > src/compiler/glsl/builtin_variables.cpp | 1 + > > 1 file changed, 1

Re: [Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-19 Thread Kenneth Graunke
On Wednesday, October 18, 2017 10:31:53 PM PDT Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/compiler/glsl/builtin_variables.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/compiler/glsl/builtin_variables.cpp >

[Mesa-dev] [PATCH v2 05/32] glsl: Zero per_vertex_accumulator::fields for valgrind & nir_serialize

2017-10-18 Thread Jordan Justen
Signed-off-by: Jordan Justen --- src/compiler/glsl/builtin_variables.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/glsl/builtin_variables.cpp b/src/compiler/glsl/builtin_variables.cpp index ea2d897cc8..d3cf12475b 100644 ---