Re: [Mesa-dev] [PATCH v2 06/18] intel/compiler: fix brw_imm_w for negative 16-bit integers

2018-05-02 Thread Jason Ekstrand
On Wed, May 2, 2018 at 8:19 AM, Chema Casanova wrote: > > > El 01/05/18 a las 01:22, Jason Ekstrand escribió: > > On Mon, Apr 30, 2018 at 3:53 PM, Chema Casanova > > wrote: > > > > > > > > On 30/04/18 23:12, Jason

Re: [Mesa-dev] [PATCH v2 06/18] intel/compiler: fix brw_imm_w for negative 16-bit integers

2018-05-02 Thread Chema Casanova
El 01/05/18 a las 01:22, Jason Ekstrand escribió: > On Mon, Apr 30, 2018 at 3:53 PM, Chema Casanova > wrote: > > > > On 30/04/18 23:12, Jason Ekstrand wrote: > > On Mon, Apr 30, 2018 at 7:18 AM, Iago Toral Quiroga

Re: [Mesa-dev] [PATCH v2 06/18] intel/compiler: fix brw_imm_w for negative 16-bit integers

2018-04-30 Thread Jason Ekstrand
On Mon, Apr 30, 2018 at 3:53 PM, Chema Casanova wrote: > > > On 30/04/18 23:12, Jason Ekstrand wrote: > > On Mon, Apr 30, 2018 at 7:18 AM, Iago Toral Quiroga > > wrote: > > > > From: Jose Maria Casanova Crespo

Re: [Mesa-dev] [PATCH v2 06/18] intel/compiler: fix brw_imm_w for negative 16-bit integers

2018-04-30 Thread Chema Casanova
On 30/04/18 23:12, Jason Ekstrand wrote: > On Mon, Apr 30, 2018 at 7:18 AM, Iago Toral Quiroga > wrote: > > From: Jose Maria Casanova Crespo > > > 16-bit immediates need to

Re: [Mesa-dev] [PATCH v2 06/18] intel/compiler: fix brw_imm_w for negative 16-bit integers

2018-04-30 Thread Jason Ekstrand
On Mon, Apr 30, 2018 at 7:18 AM, Iago Toral Quiroga wrote: > From: Jose Maria Casanova Crespo > > 16-bit immediates need to replicate the 16-bit immediate value > in both words of the 32-bit value. This needs to be careful > to avoid sign-extension,

[Mesa-dev] [PATCH v2 06/18] intel/compiler: fix brw_imm_w for negative 16-bit integers

2018-04-30 Thread Iago Toral Quiroga
From: Jose Maria Casanova Crespo 16-bit immediates need to replicate the 16-bit immediate value in both words of the 32-bit value. This needs to be careful to avoid sign-extension, which the previous implementation was not handling properly. For example, with the previous