Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

On Mon, Jul 25, 2016 at 4:30 PM, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Thanks for testing :) >> >> On Monday, July 25, 2016, Andy Furniss wrote: >> >> Nayan Deshmukh wrote: >>> >>> Hi Christian, I have sent the new patches, they

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Nayan Deshmukh wrote: Thanks for testing :) On Monday, July 25, 2016, Andy Furniss wrote: Nayan Deshmukh wrote: Hi Christian, I have sent the new patches, they should fix all the artifacts. :) I have briefly tried these over time and v3 1/2 + v2 2/2 still show

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Thanks for testing :) On Monday, July 25, 2016, Andy Furniss wrote: > Nayan Deshmukh wrote: > >> Hi Christian, >> >> I have sent the new patches, they should fix all the artifacts. :) >> > > I have briefly tried these over time and v3 1/2 + v2 2/2 still show > artifacts for

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Nayan Deshmukh wrote: Hi Christian, I have sent the new patches, they should fix all the artifacts. :) I have briefly tried these over time and v3 1/2 + v2 2/2 still show artifacts for me. All versions have issues with 8/9, and I agree with the view that you shouldn't really use up all the

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Hi Christian, I have sent the new patches, they should fix all the artifacts. :) Regards, Nayan. On Sat, Jul 23, 2016 at 3:30 PM, Nayan Deshmukh wrote: > Hi Christian, > > I tried using the approach, the artifacts are gone. But for some videos > the output quality

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Hi Christian, I tried using the approach, the artifacts are gone. But for some videos the output quality has reduced. The quality for such videos is somewhere between nearest neighbor and linear interpolation. Regards, Nayan On Thu, Jul 21, 2016 at 7:48 PM, Christian König

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Am 21.07.2016 um 16:05 schrieb Nayan Deshmukh: Hi Christian, Yes, that is for pixel center adjustment. let me give you an example, for lanczos I need frac(x) where x is the original coordinate before scaling. To calculate that first I subtract half_pixel and then multiply by the original

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Hi Christian, Yes, that is for pixel center adjustment. let me give you an example, for lanczos I need frac(x) where x is the original coordinate before scaling. To calculate that first I subtract half_pixel and then multiply by the original surface size, which gives me the original coordinate.

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

This seems to be the reason for the artifacts. + ureg_SUB(shader, ureg_writemask(t_array[0], TGSI_WRITEMASK_XY), +i_vtex, half_pixel); On debugging I found that after removing this ^^^ instruction the artifacts are gone. Not sure why is this happening

Re: [Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

Hi Christian, Thanks for the review. On Tue, Jul 19, 2016 at 4:58 PM, Christian König wrote: > Am 18.07.2016 um 21:55 schrieb Nayan Deshmukh: > >> v2: avoiding dividing by zero when calculating lanczos >> >> Signed-off-by: Nayan Deshmukh >>

[Mesa-dev] [PATCH v2 1/2] vl: add a lanczos interpolation filter v2

v2: avoiding dividing by zero when calculating lanczos Signed-off-by: Nayan Deshmukh --- src/gallium/auxiliary/Makefile.sources | 2 + src/gallium/auxiliary/vl/vl_lanczos_filter.c | 447 +++ src/gallium/auxiliary/vl/vl_lanczos_filter.h