Re: [Mesa-dev] [PATCH v2 3/5] i965/clear: Remove an early return in fast_clear_depth

2018-04-25 Thread Nanley Chery
On Wed, Apr 25, 2018 at 11:43:23AM -0700, Rafael Antognolli wrote: > On Wed, Apr 25, 2018 at 11:40:15AM -0700, Nanley Chery wrote: > > On Wed, Apr 25, 2018 at 11:30:14AM -0700, Rafael Antognolli wrote: > > > On Tue, Apr 24, 2018 at 05:48:44PM -0700, Nanley Chery wrote: > > > > Reduce complexity

Re: [Mesa-dev] [PATCH v2 3/5] i965/clear: Remove an early return in fast_clear_depth

2018-04-25 Thread Rafael Antognolli
On Wed, Apr 25, 2018 at 11:40:15AM -0700, Nanley Chery wrote: > On Wed, Apr 25, 2018 at 11:30:14AM -0700, Rafael Antognolli wrote: > > On Tue, Apr 24, 2018 at 05:48:44PM -0700, Nanley Chery wrote: > > > Reduce complexity and allow the next patch to delete some code. With > > > this change, clear

Re: [Mesa-dev] [PATCH v2 3/5] i965/clear: Remove an early return in fast_clear_depth

2018-04-25 Thread Nanley Chery
On Wed, Apr 25, 2018 at 11:30:14AM -0700, Rafael Antognolli wrote: > On Tue, Apr 24, 2018 at 05:48:44PM -0700, Nanley Chery wrote: > > Reduce complexity and allow the next patch to delete some code. With > > this change, clear operations will still be skipped and setting the > > aux_state will

Re: [Mesa-dev] [PATCH v2 3/5] i965/clear: Remove an early return in fast_clear_depth

2018-04-25 Thread Rafael Antognolli
On Tue, Apr 24, 2018 at 05:48:44PM -0700, Nanley Chery wrote: > Reduce complexity and allow the next patch to delete some code. With > this change, clear operations will still be skipped and setting the > aux_state will cause no side-effects. It's going to skip the fast clear, but if I understood

[Mesa-dev] [PATCH v2 3/5] i965/clear: Remove an early return in fast_clear_depth

2018-04-24 Thread Nanley Chery
Reduce complexity and allow the next patch to delete some code. With this change, clear operations will still be skipped and setting the aux_state will cause no side-effects. Remove the associated comment which implies an early return. --- src/mesa/drivers/dri/i965/brw_clear.c | 5 - 1 file