Re: [Mesa-dev] [PATCH v3] anv/blorp: multisample resolve all attachment layers

2018-02-20 Thread Iago Toral
Hi Nanley, thanks for having a look at this, you're right that we should use the framebuffer dimensions to decide on the number of layers to resolve. I'll send a new version with the fix. Iago On Tue, 2018-02-20 at 15:18 -0800, Nanley Chery wrote: > On Thu, Feb 15, 2018 at 09:40:16AM +0100,

Re: [Mesa-dev] [PATCH v3] anv/blorp: multisample resolve all attachment layers

2018-02-20 Thread Nanley Chery
On Thu, Feb 15, 2018 at 09:40:16AM +0100, Iago Toral Quiroga wrote: > We were only resolving the first. > > v2: > - Do not require that the number of layers on dst and src are an > exact match, it is okay if the dst has more layers so long as > it has at least the same that we are going

[Mesa-dev] [PATCH v3] anv/blorp: multisample resolve all attachment layers

2018-02-15 Thread Iago Toral Quiroga
We were only resolving the first. v2: - Do not require that the number of layers on dst and src are an exact match, it is okay if the dst has more layers so long as it has at least the same that we are going to resolve. - Do not always resolve array_len layers, we should resolve