Re: [Mesa-dev] [PATCH v3 10/13] mesa/st/glsl_to_tgsi: move evaluation of read mask up in the call hierarchy

2018-05-01 Thread Gert Wollny
Hello Nicolai, many thanks for the review. Am Dienstag, den 01.05.2018, 12:41 +0200 schrieb Nicolai Hähnle: > Again, I don't think having separate classes for tracking > temporaries and tracking arrays is a good idea. > > They do require some semantic differences, but the only one I can >

Re: [Mesa-dev] [PATCH v3 10/13] mesa/st/glsl_to_tgsi: move evaluation of read mask up in the call hierarchy

2018-05-01 Thread Nicolai Hähnle
Again, I don't think having separate classes for tracking temporaries and tracking arrays is a good idea. They do require some semantic differences, but the only one I can really think of can be summarized as "there are no unconditional writes into arrays". If you think about it that way, it

[Mesa-dev] [PATCH v3 10/13] mesa/st/glsl_to_tgsi: move evaluation of read mask up in the call hierarchy

2018-04-28 Thread Gert Wollny
In preparation of the array live range tracking the evaluation of the read mask is moved out the register live range tracking to the enclosing call of the reneralized read access tracking. Signed-off-by: Gert Wollny --- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp