Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Juan A. Suarez Romero
On Fri, 2019-02-22 at 10:04 -0600, Jason Ekstrand wrote: > On Fri, Feb 22, 2019 at 9:58 AM Jason Ekstrand wrote: > > On Fri, Feb 22, 2019 at 9:57 AM Lionel Landwerlin > > wrote: > > > On 22/02/2019 15:51, Juan A. Suarez Romero wrote: > > > > > > > On one side, when emitting 3DSTATE_SF,

Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 9:58 AM Jason Ekstrand wrote: > On Fri, Feb 22, 2019 at 9:57 AM Lionel Landwerlin < > lionel.g.landwer...@intel.com> wrote: > >> On 22/02/2019 15:51, Juan A. Suarez Romero wrote: >> > On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is >> > used to

Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Jason Ekstrand
On Fri, Feb 22, 2019 at 9:57 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 22/02/2019 15:51, Juan A. Suarez Romero wrote: > > On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is > > used to select between 8 bit subpixel precision (value 0) or 4 bit > >

Re: [Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Lionel Landwerlin
On 22/02/2019 15:51, Juan A. Suarez Romero wrote: On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is used to select between 8 bit subpixel precision (value 0) or 4 bit subpixel precision (value 1). As this value is not set, means it is taking the value 0, so 8 bit are used.

[Mesa-dev] [PATCH v3 2/2] anv: advertise 8 subpixel precision bits

2019-02-22 Thread Juan A. Suarez Romero
On one side, when emitting 3DSTATE_SF, VertexSubPixelPrecisionSelect is used to select between 8 bit subpixel precision (value 0) or 4 bit subpixel precision (value 1). As this value is not set, means it is taking the value 0, so 8 bit are used. On the other side, in the Vulkan CTS tests, if the