Re: [Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Daniel Stone
Hi, On 13 January 2017 at 14:09, Emil Velikov wrote: > Please use conditional as the one during setup. Namely: > disp->PlatformDisplay == NULL > dri2_initialize_wayland_swrast needs a similar hunk, as well as > platform_drm.c. Can you address those as with later patches

Re: [Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Emil Velikov
On 13 January 2017 at 09:05, Jonas Ådahl wrote: > When failing to initializing the Wayland EGL driver, don't leak the > display server connection if it was us who created it. > > Signed-off-by: Jonas Ådahl > --- > > Changes since v2 (where it was part of PATCH

[Mesa-dev] [PATCH v3 2/2] egl/wayland: Cleanup private display connection when init fails

2017-01-13 Thread Jonas Ådahl
When failing to initializing the Wayland EGL driver, don't leak the display server connection if it was us who created it. Signed-off-by: Jonas Ådahl --- Changes since v2 (where it was part of PATCH 1/2): * Fixed use-after-free src/egl/drivers/dri2/platform_wayland.c | 2