Re: [Mesa-dev] [PATCH v3 3/3] mapi: export all GLES 3.2 functions in libGLESv2.so

2016-09-22 Thread Dylan Baker 
Quoting Ilia Mirkin (2016-09-22 14:37:05)
> On Thu, Sep 22, 2016 at 5:16 PM, Dylan Baker  wrote:
> > See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of
> > this commit.
> >
> > Signed-off-by: Dylan Baker 
> > ---
> >
> > Changes since v2:
> >
> > Re-sort the whole list, and remove duplicates, which there were several.
> > I've also checked that there are no duplicates by importing the list in
> > python and asserting that len(functions) == len(set(functions)), since 
> > set()
> > will drop duplicates.
> >
> >  src/mapi/glapi/gen/static_data.py | 13 +
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/src/mapi/glapi/gen/static_data.py 
> > b/src/mapi/glapi/gen/static_data.py
> > index bb11c1d..6aa1716 100644
> > --- a/src/mapi/glapi/gen/static_data.py
> > +++ b/src/mapi/glapi/gen/static_data.py
> > @@ -484,17 +484,22 @@ functions = [
> >  "BindVertexBuffer",
> >  "BindVertexBuffers",
> >  "Bitmap",
> > +"BlendBarrier",
> >  "BlendColor",
> >  "BlendColorEXT",
> >  "BlendEquation",
> >  "BlendEquationEXT",
> >  "BlendEquationSeparate",
> > +"BlendEquationSeparatei",
> >  "BlendEquationSeparateiARB",
> > +"BlendEquationi",
> >  "BlendEquationiARB",
> >  "BlendFunc",
> >  "BlendFuncSeparate",
> >  "BlendFuncSeparateEXT",
> > +"BlendFuncSeparatei",
> >  "BlendFuncSeparateiARB",
> > +"BlendFunci",
> >  "BlendFunciARB",
> >  "BlitFramebuffer",
> >  "BufferData",
> > @@ -825,6 +830,7 @@ functions = [
> >  "GetFramebufferAttachmentParameteriv",
> >  "GetFramebufferAttachmentParameterivEXT",
> >  "GetFramebufferParameteriv",
> > +"GetGraphicsResetStatus",
> >  "GetGraphicsResetStatusARB",
> >  "GetHandleARB",
> >  "GetHistogram",
> > @@ -887,6 +893,7 @@ functions = [
> >  "GetSamplerParameterIiv",
> >  "GetSamplerParameterIuiv",
> >  "GetSamplerParameterfv",
> > +"GetSamplerParameteri",
> 
> That's not a function that's defined anywhere that I can see. Unless
> I'm somehow obviously wrong, please remove it. Otherwise this patch is

You're right, and I'll remove it. I'm going to assume I typoed
"GetSamplerParameteriv".

> 
> Reviewed-by: Ilia Mirkin 
> 
> The other patches in the series appear mechanical and I didn't look at
> them carefully, but are Acked-by: Ilia Mirkin 

Thanks for putting up with all of my silly mistakes and getting this reviewed.

> 
> >  "GetSamplerParameteriv",
> >  "GetSeparableFilter",
> >  "GetShaderInfoLog",
> > @@ -951,8 +958,11 @@ functions = [
> >  "GetnSeparableFilterARB",
> >  "GetnTexImageARB",
> >  "GetnUniformdvARB",
> > +"GetnUniformfv",
> >  "GetnUniformfvARB",
> > +"GetnUniformiv",
> >  "GetnUniformivARB",
> > +"GetnUniformuiv",
> >  "GetnUniformuivARB",
> >  "Hint",
> >  "Histogram",
> > @@ -1160,6 +1170,7 @@ functions = [
> >  "Orthof",
> >  "Orthox",
> >  "PassThrough",
> > +"PatchParameteri"
> >  "PauseTransformFeedback",
> >  "PixelMapfv",
> >  "PixelMapuiv",
> > @@ -1191,6 +1202,7 @@ functions = [
> >  "PopDebugGroup",
> >  "PopMatrix",
> >  "PopName",
> > +"PrimitiveBoundingBox",
> >  "PrimitiveRestartIndex",
> >  "PrimitiveRestartIndexNV",
> >  "PrimitiveRestartNV",
> > @@ -1274,6 +1286,7 @@ functions = [
> >  "RasterPos4sv",
> >  "ReadBuffer",
> >  "ReadPixels",
> > +"ReadnPixels",
> >  "ReadnPixelsARB",
> >  "Rectd",
> >  "Rectdv",
> > --
> > 2.10.0
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v3 3/3] mapi: export all GLES 3.2 functions in libGLESv2.so

2016-09-22 Thread Ilia Mirkin 
On Thu, Sep 22, 2016 at 5:16 PM, Dylan Baker  wrote:
> See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of
> this commit.
>
> Signed-off-by: Dylan Baker 
> ---
>
> Changes since v2:
>
> Re-sort the whole list, and remove duplicates, which there were several.
> I've also checked that there are no duplicates by importing the list in
> python and asserting that len(functions) == len(set(functions)), since 
> set()
> will drop duplicates.
>
>  src/mapi/glapi/gen/static_data.py | 13 +
>  1 file changed, 13 insertions(+)
>
> diff --git a/src/mapi/glapi/gen/static_data.py 
> b/src/mapi/glapi/gen/static_data.py
> index bb11c1d..6aa1716 100644
> --- a/src/mapi/glapi/gen/static_data.py
> +++ b/src/mapi/glapi/gen/static_data.py
> @@ -484,17 +484,22 @@ functions = [
>  "BindVertexBuffer",
>  "BindVertexBuffers",
>  "Bitmap",
> +"BlendBarrier",
>  "BlendColor",
>  "BlendColorEXT",
>  "BlendEquation",
>  "BlendEquationEXT",
>  "BlendEquationSeparate",
> +"BlendEquationSeparatei",
>  "BlendEquationSeparateiARB",
> +"BlendEquationi",
>  "BlendEquationiARB",
>  "BlendFunc",
>  "BlendFuncSeparate",
>  "BlendFuncSeparateEXT",
> +"BlendFuncSeparatei",
>  "BlendFuncSeparateiARB",
> +"BlendFunci",
>  "BlendFunciARB",
>  "BlitFramebuffer",
>  "BufferData",
> @@ -825,6 +830,7 @@ functions = [
>  "GetFramebufferAttachmentParameteriv",
>  "GetFramebufferAttachmentParameterivEXT",
>  "GetFramebufferParameteriv",
> +"GetGraphicsResetStatus",
>  "GetGraphicsResetStatusARB",
>  "GetHandleARB",
>  "GetHistogram",
> @@ -887,6 +893,7 @@ functions = [
>  "GetSamplerParameterIiv",
>  "GetSamplerParameterIuiv",
>  "GetSamplerParameterfv",
> +"GetSamplerParameteri",

That's not a function that's defined anywhere that I can see. Unless
I'm somehow obviously wrong, please remove it. Otherwise this patch is

Reviewed-by: Ilia Mirkin 

The other patches in the series appear mechanical and I didn't look at
them carefully, but are Acked-by: Ilia Mirkin 

>  "GetSamplerParameteriv",
>  "GetSeparableFilter",
>  "GetShaderInfoLog",
> @@ -951,8 +958,11 @@ functions = [
>  "GetnSeparableFilterARB",
>  "GetnTexImageARB",
>  "GetnUniformdvARB",
> +"GetnUniformfv",
>  "GetnUniformfvARB",
> +"GetnUniformiv",
>  "GetnUniformivARB",
> +"GetnUniformuiv",
>  "GetnUniformuivARB",
>  "Hint",
>  "Histogram",
> @@ -1160,6 +1170,7 @@ functions = [
>  "Orthof",
>  "Orthox",
>  "PassThrough",
> +"PatchParameteri"
>  "PauseTransformFeedback",
>  "PixelMapfv",
>  "PixelMapuiv",
> @@ -1191,6 +1202,7 @@ functions = [
>  "PopDebugGroup",
>  "PopMatrix",
>  "PopName",
> +"PrimitiveBoundingBox",
>  "PrimitiveRestartIndex",
>  "PrimitiveRestartIndexNV",
>  "PrimitiveRestartNV",
> @@ -1274,6 +1286,7 @@ functions = [
>  "RasterPos4sv",
>  "ReadBuffer",
>  "ReadPixels",
> +"ReadnPixels",
>  "ReadnPixelsARB",
>  "Rectd",
>  "Rectdv",
> --
> 2.10.0
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH v3 3/3] mapi: export all GLES 3.2 functions in libGLESv2.so

2016-09-22 Thread Dylan Baker 
See commit 5921f372c89a68fac6ddefc009442721d9df4db2 for the rational of
this commit.

Signed-off-by: Dylan Baker 
---

Changes since v2:

Re-sort the whole list, and remove duplicates, which there were several.
I've also checked that there are no duplicates by importing the list in
python and asserting that len(functions) == len(set(functions)), since set()
will drop duplicates.

 src/mapi/glapi/gen/static_data.py | 13 +
 1 file changed, 13 insertions(+)

diff --git a/src/mapi/glapi/gen/static_data.py 
b/src/mapi/glapi/gen/static_data.py
index bb11c1d..6aa1716 100644
--- a/src/mapi/glapi/gen/static_data.py
+++ b/src/mapi/glapi/gen/static_data.py
@@ -484,17 +484,22 @@ functions = [
 "BindVertexBuffer",
 "BindVertexBuffers",
 "Bitmap",
+"BlendBarrier",
 "BlendColor",
 "BlendColorEXT",
 "BlendEquation",
 "BlendEquationEXT",
 "BlendEquationSeparate",
+"BlendEquationSeparatei",
 "BlendEquationSeparateiARB",
+"BlendEquationi",
 "BlendEquationiARB",
 "BlendFunc",
 "BlendFuncSeparate",
 "BlendFuncSeparateEXT",
+"BlendFuncSeparatei",
 "BlendFuncSeparateiARB",
+"BlendFunci",
 "BlendFunciARB",
 "BlitFramebuffer",
 "BufferData",
@@ -825,6 +830,7 @@ functions = [
 "GetFramebufferAttachmentParameteriv",
 "GetFramebufferAttachmentParameterivEXT",
 "GetFramebufferParameteriv",
+"GetGraphicsResetStatus",
 "GetGraphicsResetStatusARB",
 "GetHandleARB",
 "GetHistogram",
@@ -887,6 +893,7 @@ functions = [
 "GetSamplerParameterIiv",
 "GetSamplerParameterIuiv",
 "GetSamplerParameterfv",
+"GetSamplerParameteri",
 "GetSamplerParameteriv",
 "GetSeparableFilter",
 "GetShaderInfoLog",
@@ -951,8 +958,11 @@ functions = [
 "GetnSeparableFilterARB",
 "GetnTexImageARB",
 "GetnUniformdvARB",
+"GetnUniformfv",
 "GetnUniformfvARB",
+"GetnUniformiv",
 "GetnUniformivARB",
+"GetnUniformuiv",
 "GetnUniformuivARB",
 "Hint",
 "Histogram",
@@ -1160,6 +1170,7 @@ functions = [
 "Orthof",
 "Orthox",
 "PassThrough",
+"PatchParameteri"
 "PauseTransformFeedback",
 "PixelMapfv",
 "PixelMapuiv",
@@ -1191,6 +1202,7 @@ functions = [
 "PopDebugGroup",
 "PopMatrix",
 "PopName",
+"PrimitiveBoundingBox",
 "PrimitiveRestartIndex",
 "PrimitiveRestartIndexNV",
 "PrimitiveRestartNV",
@@ -1274,6 +1286,7 @@ functions = [
 "RasterPos4sv",
 "ReadBuffer",
 "ReadPixels",
+"ReadnPixels",
 "ReadnPixelsARB",
 "Rectd",
 "Rectdv",
-- 
2.10.0

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev