Re: [Mesa-dev] [PATCH v3 4/4] i965: Avoid problems from referencing orphaned BOs after growing.

2018-01-10 Thread Iago Toral
On Wed, 2018-01-10 at 08:54 -0800, Kenneth Graunke wrote: > On Wednesday, January 10, 2018 5:11:21 AM PST Iago Toral wrote: > > On Mon, 2018-01-08 at 13:30 -0800, Kenneth Graunke wrote: > > > Growing the batch/state buffer is a lot more dangerous than I > > > thought. > > > > > > A number of

Re: [Mesa-dev] [PATCH v3 4/4] i965: Avoid problems from referencing orphaned BOs after growing.

2018-01-10 Thread Kenneth Graunke
On Wednesday, January 10, 2018 5:11:21 AM PST Iago Toral wrote: > On Mon, 2018-01-08 at 13:30 -0800, Kenneth Graunke wrote: > > Growing the batch/state buffer is a lot more dangerous than I > > thought. > > > > A number of places emit multiple state buffer sections, and then > > write > > data to

Re: [Mesa-dev] [PATCH v3 4/4] i965: Avoid problems from referencing orphaned BOs after growing.

2018-01-10 Thread Iago Toral
On Mon, 2018-01-08 at 13:30 -0800, Kenneth Graunke wrote: > Growing the batch/state buffer is a lot more dangerous than I > thought. > > A number of places emit multiple state buffer sections, and then > write > data to the returned pointer, or save a pointer to brw- > >batch.state.bo > and then

[Mesa-dev] [PATCH v3 4/4] i965: Avoid problems from referencing orphaned BOs after growing.

2018-01-08 Thread Kenneth Graunke
Growing the batch/state buffer is a lot more dangerous than I thought. A number of places emit multiple state buffer sections, and then write data to the returned pointer, or save a pointer to brw->batch.state.bo and then use it in relocations. If each call can grow, this can result in stale map