Re: [Mesa-dev] [PATCH v3 5/6] i965: Upload binding tables in hw-generated binding table format.

2015-07-17 Thread Abdiel Janulgue
On 07/17/2015 05:41 AM, Kenneth Graunke wrote: +static uint32_t +reserve_hw_bt_space(struct brw_context *brw, unsigned bytes) +{ + if (brw-hw_bt_pool.next_offset + bytes = brw-hw_bt_pool.bo-size - 128) { Why -128? I don't see why we should have to subtract anything... This is

Re: [Mesa-dev] [PATCH v3 5/6] i965: Upload binding tables in hw-generated binding table format.

2015-07-17 Thread Kenneth Graunke
On Friday, July 17, 2015 09:22:26 AM Abdiel Janulgue wrote: On 07/17/2015 05:41 AM, Kenneth Graunke wrote: +static uint32_t +reserve_hw_bt_space(struct brw_context *brw, unsigned bytes) +{ + if (brw-hw_bt_pool.next_offset + bytes = brw-hw_bt_pool.bo-size - 128) { Why

Re: [Mesa-dev] [PATCH v3 5/6] i965: Upload binding tables in hw-generated binding table format.

2015-07-16 Thread Kenneth Graunke
On Tuesday, July 07, 2015 11:53:29 AM Abdiel Janulgue wrote: When hardware-generated binding tables are enabled, use the hw-generated binding table format when uploading binding table state. Normally, the CS will will just consume the binding table pointer commands as pipelined state. When

[Mesa-dev] [PATCH v3 5/6] i965: Upload binding tables in hw-generated binding table format.

2015-07-07 Thread Abdiel Janulgue
When hardware-generated binding tables are enabled, use the hw-generated binding table format when uploading binding table state. Normally, the CS will will just consume the binding table pointer commands as pipelined state. When the RS is enabled however, the RS flushes whatever edited surface