Re: [Mesa-dev] [PATCH v4 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-03-20 Thread Caio Marcelo de Oliveira Filho
Hi Iago, > Fixes: > dEQP-VK.multiview.readback_implicit_clear.* Applied locally and verified this. Thanks for fixing those. I have a couple of comments after reading the patch, feel free to take them only if make sense to you :-) > + /* When multiview is active, attachments with a

Re: [Mesa-dev] [PATCH v4 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-03-13 Thread Iago Toral
Hi Jason, can you have a look at these two? We have some tests failing because of this. Iago On Wed, 2018-03-07 at 10:33 +0100, Iago Toral wrote: > This patches are still waiting for review. > > On Wed, 2018-02-28 at 09:57 +0100, Iago Toral Quiroga wrote: > > When multiview is active a subpass

Re: [Mesa-dev] [PATCH v4 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-03-07 Thread Iago Toral
This patches are still waiting for review. On Wed, 2018-02-28 at 09:57 +0100, Iago Toral Quiroga wrote: > When multiview is active a subpass clear may only clear a subset of > the > attachment layers. Other subpasses in the same render pass may also > clear too and we want to honor those clears

[Mesa-dev] [PATCH v4 1/2] anv/cmd_buffer: consider multiview masks for tracking pending clear aspects

2018-02-28 Thread Iago Toral Quiroga
When multiview is active a subpass clear may only clear a subset of the attachment layers. Other subpasses in the same render pass may also clear too and we want to honor those clears as well, however, we need to ensure that we only clear a layer once, on the first subpass that uses a particular