Re: [Mesa-dev] [RFC] Consolidate the remaining source files to Makefile.sources
On 12/09/13 18:04, Jakob Bornecrantz wrote:
On Thu, Aug 15, 2013 at 7:04 PM, Emil Velikov emil.l.veli...@gmail.comwrote:
Hello list
Feeling inspired by the automake work done in mesa, I felt like
finishing a few things that did not receive too much attention
* use Makefile.sources wherever possible
* cleanup the duplicated C{,PP,XX}FLAGS and factor out the the common
ones into Automake.inc
If anyone is interested I have pushed my preliminary work to the
makefile.sources branch at https://github.com/evelikov/Mesa/
Currently I have gone through the following:
gallium/drivers
gallium/state_trackers/dri/drm
gallium/state_trackers/dri/sw
gallium/state_trackers/vega
gallium/state_trackers/xorg
Producing the following diff stat:
54 files changed, 352 insertions(+), 552 deletions(-)
Pros:
* patches such as gallium/dri-targets: hide all symbols except for
__driDriverExtensions will be brought down to changing only with 2-3 lines
* one less chance of breaking builds when someone forgets to update the
SCons/Makefile.am/etc build, after adding/removing a file
Cons:
* Non nouveau changes will be only(lacking any other the hardware atm).
Note that I will check the symbols for all drivers, to ensure that I do
not cause chaos.
Curious if anyone is interested and have any comments on this.
Note: there may be some git rebase fails as I've started this ~3months ago
This seems to be have dropped on the floor.
The Makefile.sources patches looks good, can't comment on the other ones.
If you rebase them and you clobber the Makefile.sources ones, then send that
along with the reset of the patches on that branch out I'm sure they will
get reviewed.
Indeed, I was away for a few weeks and I'm just getting back to this.
While doing the Makefile.sources for the st/glx and st/egl I started
tearing my hairs out so I guess I'll leave that for later. The further
changes compacting the common flags/etc into drivers/targets/st specific
Automake.inc is in the works although I assume that some fun stuff may
happen around radeon/llvm.
First things first I'll send the Makefile.sources (plus a couple of
small fixes) later on tonight.
Cheers,
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [RFC] Consolidate the remaining source files to Makefile.sources
On Thu, Aug 15, 2013 at 7:04 PM, Emil Velikov emil.l.veli...@gmail.comwrote:
Hello list
Feeling inspired by the automake work done in mesa, I felt like
finishing a few things that did not receive too much attention
* use Makefile.sources wherever possible
* cleanup the duplicated C{,PP,XX}FLAGS and factor out the the common
ones into Automake.inc
If anyone is interested I have pushed my preliminary work to the
makefile.sources branch at https://github.com/evelikov/Mesa/
Currently I have gone through the following:
gallium/drivers
gallium/state_trackers/dri/drm
gallium/state_trackers/dri/sw
gallium/state_trackers/vega
gallium/state_trackers/xorg
Producing the following diff stat:
54 files changed, 352 insertions(+), 552 deletions(-)
Pros:
* patches such as gallium/dri-targets: hide all symbols except for
__driDriverExtensions will be brought down to changing only with 2-3 lines
* one less chance of breaking builds when someone forgets to update the
SCons/Makefile.am/etc build, after adding/removing a file
Cons:
* Non nouveau changes will be only(lacking any other the hardware atm).
Note that I will check the symbols for all drivers, to ensure that I do
not cause chaos.
Curious if anyone is interested and have any comments on this.
Note: there may be some git rebase fails as I've started this ~3months ago
This seems to be have dropped on the floor.
The Makefile.sources patches looks good, can't comment on the other ones.
If you rebase them and you clobber the Makefile.sources ones, then send that
along with the reset of the patches on that branch out I'm sure they will
get reviewed.
Cheers, Jakob.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [RFC] Consolidate the remaining source files to Makefile.sources
Hello list
Feeling inspired by the automake work done in mesa, I felt like
finishing a few things that did not receive too much attention
* use Makefile.sources wherever possible
* cleanup the duplicated C{,PP,XX}FLAGS and factor out the the common
ones into Automake.inc
If anyone is interested I have pushed my preliminary work to the
makefile.sources branch at https://github.com/evelikov/Mesa/
Currently I have gone through the following:
gallium/drivers
gallium/state_trackers/dri/drm
gallium/state_trackers/dri/sw
gallium/state_trackers/vega
gallium/state_trackers/xorg
Producing the following diff stat:
54 files changed, 352 insertions(+), 552 deletions(-)
Pros:
* patches such as gallium/dri-targets: hide all symbols except for
__driDriverExtensions will be brought down to changing only with 2-3 lines
* one less chance of breaking builds when someone forgets to update the
SCons/Makefile.am/etc build, after adding/removing a file
Cons:
* Non nouveau changes will be only(lacking any other the hardware atm).
Note that I will check the symbols for all drivers, to ensure that I do
not cause chaos.
Curious if anyone is interested and have any comments on this.
Note: there may be some git rebase fails as I've started this ~3months ago
Cheers
Emil
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
