Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-24 Thread Marek Olšák
On Thu, May 24, 2018 at 4:11 AM, Nicolai Hähnle wrote: > On 18.05.2018 06:05, Marek Olšák wrote: > >> From: Marek Olšák >> >> The interface only uses general MSAA terms, so it's "advanced MSAA" and >> not >> something vendor-specific. >> >> It's a proper

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-24 Thread Nicolai Hähnle
On 18.05.2018 06:05, Marek Olšák wrote: From: Marek Olšák The interface only uses general MSAA terms, so it's "advanced MSAA" and not something vendor-specific. It's a proper subset of EQAA, and a proper superset of CSAA, so it's neither. Changes: - pipe_resource is

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Marek Olšák
It was marketed that way because D3D didn't have API to do anything else. In practice, EQAA can do arbitrary color coverage, color storage, and Z/S sample counts, and each color render target can have different values too. So everything is allowed, but the combinations that don't make sense only

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Roland Scheidegger
I was under the (apparently wrong) impression EQAA always worked like that too. Even AMD's marketing said EQAA has the same number of stencil/depth/color samples as regular MSAA (when the feature was new, HD 6900,

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Marek Olšák
Your understanding is correct. I misunderstood CSAA. So it looks like that CSAA is more useless than I thought. You get the coverage-samples level of quality for back-to-front rendering, but you may get the depth-samples level of quality for front-to-back rendering, because "edges" generated by

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Axel Davy
Hi, I get the impression when looking at online documentation about EQAA and CSAA, like http://www.nvidia.fr/object/coverage-sampled-aa.html that the number of stored samples is the same for the color and depth buffers. Only the samples used for coverage is greater. With your proposal,

Re: [Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-21 Thread Roland Scheidegger
This looks reasonable to me. Roland Am 18.05.2018 um 06:05 schrieb Marek Olšák: > From: Marek Olšák > > The interface only uses general MSAA terms, so it's "advanced MSAA" and not > something vendor-specific. > > It's a proper subset of EQAA, and a proper superset of

[Mesa-dev] [RFC PATCH] gallium: add interface for advanced MSAA

2018-05-17 Thread Marek Olšák
From: Marek Olšák The interface only uses general MSAA terms, so it's "advanced MSAA" and not something vendor-specific. It's a proper subset of EQAA, and a proper superset of CSAA, so it's neither. Changes: - pipe_resource is changed - is_format_supported is changed - a