Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-16 Thread John Brooks
On 05/15/2017 06:52 PM, John Brooks wrote: On 2017-05-15 06:04 PM, Ian Romanick wrote: On 05/12/2017 06:39 AM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-15 Thread John Brooks
On 2017-05-15 06:04 PM, Ian Romanick wrote: On 05/12/2017 06:39 AM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root of the problem is that their vertex shaders

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-15 Thread Ian Romanick
On 05/12/2017 06:39 AM, John Brooks wrote: > Since release, Dying Light and Dead Island Definitive Edition have been broken > on Mesa, producing at best only a black screen after loading. I found that the > root of the problem is that their vertex shaders redeclare the GLSL builtin > gl_VertexID,

[Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-14 Thread Benedikt Schemmer
Hi all, Dying Light really works (Radeon RX460 4GB, Ubuntu 17.04, Mesa git patches applied plus some minor changes that i have locally to get rid of compiler warnings). I did have to jump through some additional hoops to get it working: Dying Light only launches from within Steam, Launch

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-14 Thread Marek Olšák
On Sat, May 13, 2017 at 1:55 AM, John Brooks wrote: > On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: >> On 13/05/17 00:11, John Brooks wrote: >> >On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: >> >> >> >> >> >>On 05/12/2017 03:39 PM, John

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-13 Thread Samuel Pitoiset
In an ideal world, I would prefer the compiler to be less strict for dump things like that, but it might require more work, so your solution is fine by me. I can confirm this fixes Dying Light, not sure why we didn't find this before (we probably followed a wrong path), but it's a nice find.

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
On Sat, May 13, 2017 at 10:47:17AM +1000, Timothy Arceri wrote: > On 13/05/17 09:55, John Brooks wrote: > >On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: > >>On 13/05/17 00:11, John Brooks wrote: > >>>On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > > >

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread Timothy Arceri
On 13/05/17 09:55, John Brooks wrote: On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: On 13/05/17 00:11, John Brooks wrote: On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: On 05/12/2017 03:39 PM, John Brooks wrote: Since release, Dying Light and Dead Island

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: > On 13/05/17 00:11, John Brooks wrote: > >On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > >> > >> > >>On 05/12/2017 03:39 PM, John Brooks wrote: > >>>Since release, Dying Light and Dead Island Definitive Edition

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread Timothy Arceri
On 13/05/17 00:11, John Brooks wrote: On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: On 05/12/2017 03:39 PM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: > > > On 05/12/2017 03:39 PM, John Brooks wrote: > >Since release, Dying Light and Dead Island Definitive Edition have been > >broken > >on Mesa, producing at best only a black screen after loading. I found that > >the > >root of

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread Samuel Pitoiset
On 05/12/2017 03:39 PM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root of the problem is that their vertex shaders redeclare the GLSL builtin gl_VertexID,

[Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-12 Thread John Brooks
Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root of the problem is that their vertex shaders redeclare the GLSL builtin gl_VertexID, which Mesa's compiler considers to be an error: