Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

2019-04-23 Thread Kenneth Graunke
On Monday, April 22, 2019 3:21:22 PM PDT Eric Anholt wrote: > Jason Ekstrand writes: > > > All, > > > > I've seen discussions come up several times lately about whether you should > > use MAYBE_UNUSED or UNUSED in what scenario and why do we have two of them > > anyway. That got me thinking a

Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

2019-04-22 Thread Kristian Høgsberg
On Mon, Apr 22, 2019 at 3:11 PM Matt Turner wrote: > > On Mon, Apr 22, 2019 at 1:09 PM Kristian Høgsberg wrote: > > > > On Mon, Apr 22, 2019 at 12:11 PM Jason Ekstrand > > wrote: > > > > > > All, > > > > > > I've seen discussions come up several times lately about whether you > > > should use

Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

2019-04-22 Thread Eric Anholt
Jason Ekstrand writes: > All, > > I've seen discussions come up several times lately about whether you should > use MAYBE_UNUSED or UNUSED in what scenario and why do we have two of them > anyway. That got me thinking a bit. Maybe what we actually want instead > of MAYBE_UNUSED is something

Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

2019-04-22 Thread Matt Turner
On Mon, Apr 22, 2019 at 1:09 PM Kristian Høgsberg wrote: > > On Mon, Apr 22, 2019 at 12:11 PM Jason Ekstrand wrote: > > > > All, > > > > I've seen discussions come up several times lately about whether you should > > use MAYBE_UNUSED or UNUSED in what scenario and why do we have two of them >

Re: [Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

2019-04-22 Thread Kristian Høgsberg
On Mon, Apr 22, 2019 at 12:11 PM Jason Ekstrand wrote: > > All, > > I've seen discussions come up several times lately about whether you should > use MAYBE_UNUSED or UNUSED in what scenario and why do we have two of them > anyway. That got me thinking a bit. Maybe what we actually want

[Mesa-dev] Add an ASSERTED macro to use in place of MAYBE_UNUSED?

2019-04-22 Thread Jason Ekstrand
All, I've seen discussions come up several times lately about whether you should use MAYBE_UNUSED or UNUSED in what scenario and why do we have two of them anyway. That got me thinking a bit. Maybe what we actually want instead of MAYBE_UNUSED is something like this: #ifdef NDEBUG #define