Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-05-01 Thread Dave Airlie
On Thu, 2 May 2019 at 05:36, Viktor Jaegerskuepper wrote: > > Dave Airlie: > > On Wed, 1 May 2019 at 12:34, Ilia Mirkin wrote: > >> > >> On Tue, Apr 30, 2019 at 10:42 AM Ilia Mirkin wrote: > >>> > >>> On Tue, Apr 30, 2019 at 2:48 AM Dave Airlie wrote: > > On Tue, 30 Apr 2019 at

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-05-01 Thread Viktor Jaegerskuepper
Dave Airlie: > On Wed, 1 May 2019 at 12:34, Ilia Mirkin wrote: >> >> On Tue, Apr 30, 2019 at 10:42 AM Ilia Mirkin wrote: >>> >>> On Tue, Apr 30, 2019 at 2:48 AM Dave Airlie wrote: On Tue, 30 Apr 2019 at 08:47, Dave Airlie wrote: > > On Tue, 30 Apr 2019 at 08:42, Ilia Mirkin

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-30 Thread Dave Airlie
On Wed, 1 May 2019 at 12:34, Ilia Mirkin wrote: > > On Tue, Apr 30, 2019 at 10:42 AM Ilia Mirkin wrote: > > > > On Tue, Apr 30, 2019 at 2:48 AM Dave Airlie wrote: > > > > > > On Tue, 30 Apr 2019 at 08:47, Dave Airlie wrote: > > > > > > > > On Tue, 30 Apr 2019 at 08:42, Ilia Mirkin wrote: > >

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-30 Thread Ilia Mirkin
On Tue, Apr 30, 2019 at 10:42 AM Ilia Mirkin wrote: > > On Tue, Apr 30, 2019 at 2:48 AM Dave Airlie wrote: > > > > On Tue, 30 Apr 2019 at 08:47, Dave Airlie wrote: > > > > > > On Tue, 30 Apr 2019 at 08:42, Ilia Mirkin wrote: > > > > > > > > Thing is, I think that would not be enough - with the

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-30 Thread Ilia Mirkin
On Tue, Apr 30, 2019 at 2:48 AM Dave Airlie wrote: > > On Tue, 30 Apr 2019 at 08:47, Dave Airlie wrote: > > > > On Tue, 30 Apr 2019 at 08:42, Ilia Mirkin wrote: > > > > > > Thing is, I think that would not be enough - with the "recent" (like > > > past 2 years) CSO/state change detection

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-30 Thread Dave Airlie
On Tue, 30 Apr 2019 at 08:47, Dave Airlie wrote: > > On Tue, 30 Apr 2019 at 08:42, Ilia Mirkin wrote: > > > > Thing is, I think that would not be enough - with the "recent" (like > > past 2 years) CSO/state change detection changes, I think that you can > > end up with no sampler set for a

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-29 Thread Dave Airlie
On Tue, 30 Apr 2019 at 08:42, Ilia Mirkin wrote: > > Thing is, I think that would not be enough - with the "recent" (like > past 2 years) CSO/state change detection changes, I think that you can > end up with no sampler set for a buffer view. Perhaps someone with the > hw can investigate what

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-29 Thread Ilia Mirkin
Thing is, I think that would not be enough - with the "recent" (like past 2 years) CSO/state change detection changes, I think that you can end up with no sampler set for a buffer view. Perhaps someone with the hw can investigate what goes wrong? On Mon, Apr 29, 2019 at 5:42 PM Marek Olšák

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-29 Thread Marek Olšák
Reverting the st/mesa commit would be fine. Marek On Mon, Apr 29, 2019 at 3:20 PM Ilia Mirkin wrote: > On Mon, Apr 29, 2019 at 3:06 PM Viktor Jaegerskuepper > wrote: > > > > Hi Ilia, > > > > Ilia Mirkin: > > > If you can reproduce the issue > > > at will, could I recommend you try undoing

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-29 Thread Viktor Jaegerskuepper
Hi Ilia, Ilia Mirkin: > If you can reproduce the issue > at will, could I recommend you try undoing this hunk: > > @@ -1192,7 +1192,6 @@ try_pbo_upload_common(struct gl_context *ctx, >return false; > > cso_save_state(cso, (CSO_BIT_FRAGMENT_SAMPLER_VIEWS | > -

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-29 Thread Ilia Mirkin
On Mon, Apr 29, 2019 at 3:06 PM Viktor Jaegerskuepper wrote: > > Hi Ilia, > > Ilia Mirkin: > > If you can reproduce the issue > > at will, could I recommend you try undoing this hunk: > > > > @@ -1192,7 +1192,6 @@ try_pbo_upload_common(struct gl_context *ctx, > >return false; > > > >

Re: [Mesa-dev] Change in Mesa triggers bug in Firefox Nightly with WebRender on old AMD hardware

2019-04-28 Thread Ilia Mirkin
Hi Viktor, I'm not intimately familiar with AMD hardware (but Marek is, I'm sure he'll opine when he gets a chance). Note that RV7xx is among the DX10-class hardware which is older less tested nowadays compared to the DX11-class r600-derived hardware (EG/NI), which admittedly is also not exactly