Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-12 Thread Michel Dänzer
On 2019-12-11 7:35 p.m., Marek Olšák wrote: > > Merging a branch: > 1*) Check that all CI pipelines have succeeded. > 2) Rebase your local branch and force-push to your private branch. > 3) Wait ~10 seconds. > 4) Push that branch to master (git push origin HEAD:master). Gitlab will >

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Dylan Baker
Quoting Nathan Kidd (2019-12-11 06:41:12) > On 2019-12-10 7:10 p.m., Jason Ekstrand wrote: > > Quoting Zebediah Figura (2019-12-10 10:58:45) > > > On 12/10/19 12:21 PM, Matt Turner wrote: > > > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > > > > I think its time we discussed whether

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Marek Olšák
On Wed, Dec 11, 2019 at 12:02 PM Brian Paul wrote: > On 12/09/2019 04:07 PM, Dylan Baker wrote: > > Hi everyone, > > > > I think its time we discussed whether we're going to continue to do > patch review > > on the mailing list, or if it it should all go through gitlab. I think > we should > >

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Rob Clark
On Wed, Dec 11, 2019 at 9:58 AM Brian Paul wrote: > > On 12/11/2019 10:42 AM, Jason Ekstrand wrote: > > On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer > > wrote: > > > > On 2019-12-11 5:47 p.m., Brian Paul wrote: > > > > > > I've had little time for Mesa

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Brian Paul
On 12/11/2019 10:42 AM, Jason Ekstrand wrote: On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer > wrote: On 2019-12-11 5:47 p.m., Brian Paul wrote: > > I've had little time for Mesa work the past 18 months. That makes me sad, I hope you'll have more

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Jason Ekstrand
On Wed, Dec 11, 2019 at 11:33 AM Michel Dänzer wrote: > On 2019-12-11 5:47 p.m., Brian Paul wrote: > > > > I've had little time for Mesa work the past 18 months. > > That makes me sad, I hope you'll have more time again in the future. > > > > 1. I don't think the mesa-dev list should be shut

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Michel Dänzer
On 2019-12-11 5:47 p.m., Brian Paul wrote: > > I've had little time for Mesa work the past 18 months. That makes me sad, I hope you'll have more time again in the future. > 1. I don't think the mesa-dev list should be shut down nor purged from > the documentation. Yeah, I don't think anybody

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Brian Paul
On 12/09/2019 04:07 PM, Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing list, here are some reasons: 1) Most development is

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-11 Thread Nathan Kidd
On 2019-12-10 7:10 p.m., Jason Ekstrand wrote: > Quoting Zebediah Figura (2019-12-10 10:58:45) > > On 12/10/19 12:21 PM, Matt Turner wrote: > > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > > > I think its time we discussed whether we're going to continue to do > > > > patch review > >

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Jason Ekstrand
On Tue, Dec 10, 2019 at 4:59 PM Dylan Baker wrote: > Quoting Zebediah Figura (2019-12-10 10:58:45) > > On 12/10/19 12:21 PM, Matt Turner wrote: > > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker > wrote: > > >> > > >> Hi everyone, > > >> > > >> I think its time we discussed whether we're going to

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Timothy Arceri
On 11/12/19 8:54 am, Alex Deucher wrote: On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker wrote: Do we have those and does anyone notice? I personally rarely look at the list now unless I'm CC'd on something. That seems really bad for drive by contributors. But frankly I wouldn't submit to a

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Timothy Arceri
On 11/12/19 5:58 am, Zebediah Figura wrote: On 12/10/19 12:21 PM, Matt Turner wrote: On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Dylan Baker
Quoting Zebediah Figura (2019-12-10 10:58:45) > On 12/10/19 12:21 PM, Matt Turner wrote: > > On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > >> > >> Hi everyone, > >> > >> I think its time we discussed whether we're going to continue to do patch > >> review > >> on the mailing list, or if it

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Dylan Baker
Quoting Alex Deucher (2019-12-10 13:54:02) > On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker wrote: > > > > Do we have those and does anyone notice? I personally rarely look at the > > list > > now unless I'm CC'd on something. That seems really bad for drive by > > contributors. > > > > But frankly

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Alex Deucher
On Tue, Dec 10, 2019 at 1:13 PM Dylan Baker wrote: > > Do we have those and does anyone notice? I personally rarely look at the list > now unless I'm CC'd on something. That seems really bad for drive by > contributors. > > But frankly I wouldn't submit to a mailing list as a drive by, it's more

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Zebediah Figura
On 12/10/19 12:21 PM, Matt Turner wrote: On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Matt Turner
On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > Hi everyone, > > I think its time we discussed whether we're going to continue to do patch > review > on the mailing list, or if it it should all go through gitlab. I think we > should > stop using the mailing list, here are some reasons: >

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Dylan Baker
Adding Daniel (since he could actually turn patchwork off), but I doubt anyone in mesa is using patchwork at this point, I think all of the people who were interested have moved to gitlab. We could probably dump it even if we decide to keep the list. Just my 2¢. Dylan Quoting Marek Olšák

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Dylan Baker
Do we have those and does anyone notice? I personally rarely look at the list now unless I'm CC'd on something. That seems really bad for drive by contributors. But frankly I wouldn't submit to a mailing list as a drive by, it's more work to get subscribed to mail man (so my patch goes through),

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-10 Thread Alex Deucher
How do we deal with drive by fixes? E.g., some random user submits a fix but doesn't want to create a gitlab account just to submit a fix? Whoever reviews the patch should submit an MR? Alex On Mon, Dec 9, 2019 at 6:07 PM Dylan Baker wrote: > > Hi everyone, > > I think its time we discussed

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-09 Thread Marek Olšák
Do we plan to remove the patchwork action on push? Marek On Mon, Dec 9, 2019 at 9:10 PM Roland Scheidegger wrote: > So, I'm guilty of being one of the few still using the mailing list... > But in any case, certainly I can switch to using MRs if everybody > prefers that now (meaning, I'm really

Re: [Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-09 Thread Roland Scheidegger
So, I'm guilty of being one of the few still using the mailing list... But in any case, certainly I can switch to using MRs if everybody prefers that now (meaning, I'm really indifferent to this). Roland Am 10.12.19 um 00:07 schrieb Dylan Baker: > Hi everyone, > > I think its time we discussed

[Mesa-dev] Is it time to stop using the mailing list for patch review?

2019-12-09 Thread Dylan Baker
Hi everyone, I think its time we discussed whether we're going to continue to do patch review on the mailing list, or if it it should all go through gitlab. I think we should stop using the mailing list, here are some reasons: 1) Most development is happening on gitlab at this point, patches on