Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 08/15/2011 01:41 PM, Kenneth Graunke wrote: > The new repo is up now (thanks Eric!): > git://git.freedesktop.org/git/mesa/glw Apparently what I meant to say was: git://anongit.freedesktop.org/mesa/glw ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 08/08/2011 08:04 AM, Brian Paul wrote: > On 08/05/2011 06:21 PM, Kenneth Graunke wrote: >> On 08/05/2011 06:45 AM, Brian Paul wrote: >>> On Thu, Aug 4, 2011 at 4:26 PM, Kenneth >>> Graunke wrote: Hey, I'd like to remove libGLw from the main Mesa repository. It never changes, and almost noone uses it...because GL and Motif is awesome, right? Since Debian still packages it, I pulled it into its own git repository, preserving history, and then autotooled it. You can get it here: git://people.freedesktop.org/~kwg/glw >>> >>> Sounds good to me. Please scan through the Mesa docs for any mention >>> of libGLw and update/remove as needed. There should at least be a >>> pointer to the new home of libGLw too. >>> >>> -Brian >> >> Thanks, Brian. I've done so in this branch: >> http://cgit.freedesktop.org/~kwg/mesa/log/?h=die-glw-die > > > Reviewed-by: Brian Paul Thanks! The new repo is up now (thanks Eric!): git://git.freedesktop.org/git/mesa/glw so I've pushed the removal. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 08/05/2011 06:21 PM, Kenneth Graunke wrote: On 08/05/2011 06:45 AM, Brian Paul wrote: On Thu, Aug 4, 2011 at 4:26 PM, Kenneth Graunke wrote: Hey, I'd like to remove libGLw from the main Mesa repository. It never changes, and almost noone uses it...because GL and Motif is awesome, right? Since Debian still packages it, I pulled it into its own git repository, preserving history, and then autotooled it. You can get it here: git://people.freedesktop.org/~kwg/glw Sounds good to me. Please scan through the Mesa docs for any mention of libGLw and update/remove as needed. There should at least be a pointer to the new home of libGLw too. -Brian Thanks, Brian. I've done so in this branch: http://cgit.freedesktop.org/~kwg/mesa/log/?h=die-glw-die Reviewed-by: Brian Paul ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 04/08/2011 23:26, Kenneth Graunke wrote: Hey, I'd like to remove libGLw from the main Mesa repository. It never changes, and almost noone uses it...because GL and Motif is awesome, right? Since Debian still packages it, I pulled it into its own git repository, preserving history, and then autotooled it. You can get it here: git://people.freedesktop.org/~kwg/glw fwiw, I need the attached patch to the autofoolery to build under cygwin. >From 9b36ff36e58233f7faf9f39d5337f2f74158aad9 Mon Sep 17 00:00:00 2001 From: Jon TURNEY Date: Sun, 7 Aug 2011 14:36:40 +0100 Subject: [PATCH] Use -no-undefined libtool flag, fix underlinking when configured --enable-motif Use -no-undefined to assure libtool that the library has no unresolved symbols at link time, so that libtool will build a shared library on platforms require that all symbols are resolved when the library is linked. This exposes the fact that we are underlinked when ./configured with --enable-motif, so also link with motif libs in that case. Signed-off-by: Jon TURNEY --- Makefile.am |2 +- configure.ac |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4f8bb04..b95438c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -29,7 +29,7 @@ lib_LTLIBRARIES = libGLw.la libGLw_la_SOURCES = GLwDrawA.c libGLw_la_CFLAGS = $(GLW_CLFAGS) libGLw_la_LIBADD = $(GLW_LIBS) -libGLw_la_LDFLAGS = -version-info $(GLW_LIBRARY_VERSION) +libGLw_la_LDFLAGS = -version-info $(GLW_LIBRARY_VERSION) -no-undefined if ENABLE_MOTIF libGLw_la_SOURCES += GLwMDrawA.c libGLw_la_CFLAGS += $(MOTIF_CFLAGS) diff --git a/configure.ac b/configure.ac index 8d46a11..da4d445 100644 --- a/configure.ac +++ b/configure.ac @@ -87,7 +87,7 @@ AC_SUBST([GLW_PC_LIB_PRIV]) AC_SUBST([GLW_PC_CFLAGS]) CFLAGS="$CFLAGS $GL_CFLAGS" -LIBS="$LIBS $GL_LIBS" +LIBS="$LIBS $GL_LIBS $MOTIF_LIBS" dnl Set up C warning flags. Copy of XORG_CWARNFLAGS. if test "x$GCC" = xyes ; then -- 1.7.5.1 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 08/05/2011 06:45 AM, Brian Paul wrote: > On Thu, Aug 4, 2011 at 4:26 PM, Kenneth Graunke wrote: >> Hey, >> >> I'd like to remove libGLw from the main Mesa repository. It never >> changes, and almost noone uses it...because GL and Motif is awesome, right? >> >> Since Debian still packages it, I pulled it into its own git repository, >> preserving history, and then autotooled it. >> >> You can get it here: >> git://people.freedesktop.org/~kwg/glw > > Sounds good to me. Please scan through the Mesa docs for any mention > of libGLw and update/remove as needed. There should at least be a > pointer to the new home of libGLw too. > > -Brian Thanks, Brian. I've done so in this branch: http://cgit.freedesktop.org/~kwg/mesa/log/?h=die-glw-die ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 08/05/2011 11:05 AM, Dan Nicholson wrote: > On Fri, Aug 5, 2011 at 7:25 AM, Benjamin Franzke > wrote: >> There is nothing compiled since GLW_SOURCES is not substituted by configure: >> Makefile.am:29 >> libGLw_la_SOURCES = $(GLW_SOURCES) >> >> This would need AC_SUBST([GLW_SOURCES]) in configure.ac, >> but thats not allowed for _SOURCES variables, see automake output: >> >> configure.ac:96: `GLW_SOURCES' includes configure substitution >> `@GLW_SOURCES@' >> configure.ac:96: and is referred to from `libGLw_la_SOURCES'; >> configure.ac:96: configure substitutions are not allowed in _SOURCES >> variables D'oh! Thanks for finding that, Ben. As you can see, I haven't actually tried to use libGLw. :) > With automake, we can do this a lot cleaner with an AM_CONDITIONAL. > Shortened version: > > configure.ac: > AM_CONDITIONAL([ENABLE_MOTIF], [test "$enable_motif" = yes]) > > Makefile.am: > libGLw_la_SOURCES = GLwDrawA.c > libGLw_la_CFLAGS = $(GLW_CFLAGS) > libGLw_la_LIBADD = $(GLW_LIBS) > if ENABLE_MOTIF > libGLw_la_SOURCES += GLwMDrawA.c > libGLw_la_CFLAGS += $(MOTIF_CFLAGS) > libGLw_la_LIBADD += $(MOTIF_LIBS) > endif > > Dan Thanks Dan! That's -much- nicer. I knew there had to be a way to do this cleanly! I've pushed a rebased branch to ~kwg/glw with these fixes, as well as some glw.pc fixes and configure.ac cleanups. I'm not really sure what we want to do about tarballs. We probably ought to make a release at some point...and then never touch it again. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 08/05/2011 10:58 AM, Dan Nicholson wrote: > On Fri, Aug 5, 2011 at 6:45 AM, Brian Paul wrote: >> On Thu, Aug 4, 2011 at 4:26 PM, Kenneth Graunke >> wrote: >>> Hey, >>> >>> I'd like to remove libGLw from the main Mesa repository. It never >>> changes, and almost noone uses it...because GL and Motif is awesome, right? >>> >>> Since Debian still packages it, I pulled it into its own git repository, >>> preserving history, and then autotooled it. >>> >>> You can get it here: >>> git://people.freedesktop.org/~kwg/glw >> >> Sounds good to me. Please scan through the Mesa docs for any mention >> of libGLw and update/remove as needed. There should at least be a >> pointer to the new home of libGLw too. > > Can we make this mesa/glw eventually to live alongside glut? > > Dan Yes, of course. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On 08/05/2011 06:55 AM, Maxim Levitsky wrote: > On Fri, 2011-08-05 at 07:45 -0600, Brian Paul wrote: >> On Thu, Aug 4, 2011 at 4:26 PM, Kenneth Graunke >> wrote: >>> Hey, >>> >>> I'd like to remove libGLw from the main Mesa repository. It never >>> changes, and almost noone uses it...because GL and Motif is awesome, right? >>> >>> Since Debian still packages it, I pulled it into its own git repository, >>> preserving history, and then autotooled it. >>> >>> You can get it here: >>> git://people.freedesktop.org/~kwg/glw >> >> Sounds good to me. Please scan through the Mesa docs for any mention >> of libGLw and update/remove as needed. There should at least be a >> pointer to the new home of libGLw too. > > While at it, why not to remove libGLU from mesa as well? > > Best regards, > Maxim Levitsky Agreed. That's next on the list. --Kenneth ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On Fri, Aug 5, 2011 at 7:25 AM, Benjamin Franzke wrote: > There is nothing compiled since GLW_SOURCES is not substituted by configure: > Makefile.am:29 > libGLw_la_SOURCES = $(GLW_SOURCES) > > This would need AC_SUBST([GLW_SOURCES]) in configure.ac, > but thats not allowed for _SOURCES variables, see automake output: > > configure.ac:96: `GLW_SOURCES' includes configure substitution `@GLW_SOURCES@' > configure.ac:96: and is referred to from `libGLw_la_SOURCES'; > configure.ac:96: configure substitutions are not allowed in _SOURCES variables With automake, we can do this a lot cleaner with an AM_CONDITIONAL. Shortened version: configure.ac: AM_CONDITIONAL([ENABLE_MOTIF], [test "$enable_motif" = yes]) Makefile.am: libGLw_la_SOURCES = GLwDrawA.c libGLw_la_CFLAGS = $(GLW_CFLAGS) libGLw_la_LIBADD = $(GLW_LIBS) if ENABLE_MOTIF libGLw_la_SOURCES += GLwMDrawA.c libGLw_la_CFLAGS += $(MOTIF_CFLAGS) libGLw_la_LIBADD += $(MOTIF_LIBS) endif -- Dan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On Fri, Aug 5, 2011 at 6:45 AM, Brian Paul wrote: > On Thu, Aug 4, 2011 at 4:26 PM, Kenneth Graunke wrote: >> Hey, >> >> I'd like to remove libGLw from the main Mesa repository. It never >> changes, and almost noone uses it...because GL and Motif is awesome, right? >> >> Since Debian still packages it, I pulled it into its own git repository, >> preserving history, and then autotooled it. >> >> You can get it here: >> git://people.freedesktop.org/~kwg/glw > > Sounds good to me. Please scan through the Mesa docs for any mention > of libGLw and update/remove as needed. There should at least be a > pointer to the new home of libGLw too. Can we make this mesa/glw eventually to live alongside glut? -- Dan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
There is nothing compiled since GLW_SOURCES is not substituted by configure: Makefile.am:29 libGLw_la_SOURCES = $(GLW_SOURCES) This would need AC_SUBST([GLW_SOURCES]) in configure.ac, but thats not allowed for _SOURCES variables, see automake output: configure.ac:96: `GLW_SOURCES' includes configure substitution `@GLW_SOURCES@' configure.ac:96: and is referred to from `libGLw_la_SOURCES'; configure.ac:96: configure substitutions are not allowed in _SOURCES variables 2011/8/5 Kenneth Graunke : > Hey, > > I'd like to remove libGLw from the main Mesa repository. It never > changes, and almost noone uses it...because GL and Motif is awesome, right? > > Since Debian still packages it, I pulled it into its own git repository, > preserving history, and then autotooled it. > > You can get it here: > git://people.freedesktop.org/~kwg/glw > > --Kenneth > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On Fri, 2011-08-05 at 07:45 -0600, Brian Paul wrote: > On Thu, Aug 4, 2011 at 4:26 PM, Kenneth Graunke wrote: > > Hey, > > > > I'd like to remove libGLw from the main Mesa repository. It never > > changes, and almost noone uses it...because GL and Motif is awesome, right? > > > > Since Debian still packages it, I pulled it into its own git repository, > > preserving history, and then autotooled it. > > > > You can get it here: > > git://people.freedesktop.org/~kwg/glw > > Sounds good to me. Please scan through the Mesa docs for any mention > of libGLw and update/remove as needed. There should at least be a > pointer to the new home of libGLw too. While at it, why not to remove libGLU from mesa as well? Best regards, Maxim Levitsky ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] Removing GLw from the main Mesa repository
On Thu, Aug 4, 2011 at 4:26 PM, Kenneth Graunke wrote: > Hey, > > I'd like to remove libGLw from the main Mesa repository. It never > changes, and almost noone uses it...because GL and Motif is awesome, right? > > Since Debian still packages it, I pulled it into its own git repository, > preserving history, and then autotooled it. > > You can get it here: > git://people.freedesktop.org/~kwg/glw Sounds good to me. Please scan through the Mesa docs for any mention of libGLw and update/remove as needed. There should at least be a pointer to the new home of libGLw too. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] Removing GLw from the main Mesa repository
Hey, I'd like to remove libGLw from the main Mesa repository. It never changes, and almost noone uses it...because GL and Motif is awesome, right? Since Debian still packages it, I pulled it into its own git repository, preserving history, and then autotooled it. You can get it here: git://people.freedesktop.org/~kwg/glw --Kenneth ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev