Re: [Mesa-dev] [PATCH 2/3] gallium: add texture gather support to gallium (v3)

2014-02-24 Thread Dave Airlie
On Wed, Feb 12, 2014 at 9:10 AM, Roland Scheidegger srol...@vmware.com wrote: Am 11.02.2014 22:58, schrieb Dave Airlie: dst.z = texture_depth(unit, lod) +.. opcode:: TG4 - Texture Gather (as per ARB_texture_gather) + Gathers the four texels to be used in a bi-linear +

[Mesa-dev] [RFC PATCH] i965/gs: add snb support

2014-02-24 Thread Ilia Mirkin
Before you read any further, this is nowhere close to working. However it's in a state where I think most of the structure is there, albeit with a lot of XXX comments. And I haven't actually implemented the new opcodes I've added. I was hoping one or two Intel people could take a look at this and

[Mesa-dev] gallium and ARB_texture_query_levels

2014-02-24 Thread Dave Airlie
I've taken a quick look at ARB_texture_query_levels, and the HW generally seems to implement this by returning it in the W channel of RESINFO, which would map to the TXQ instruction, So my initial implementation added a LEVQ TGSI instruction but I do think this isn't representative of the hw and

[Mesa-dev] [PATCH 2/2] R600/SI: Optimize SI_KILL for constant operands

2014-02-24 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com If the SI_KILL operand is constant, we can either clear the exec mask if the operand is negative, or do nothing otherwise. Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SIInstructions.td | 4 ++--

[Mesa-dev] [PATCH 1/2] R600/SI: Allow SI_KILL for geometry shaders

2014-02-24 Thread Michel Dänzer
From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SILowerControlFlow.cpp | 50 ++ test/CodeGen/R600/llvm.AMDGPU.kill.ll | 18 2 files changed, 50 insertions(+), 18 deletions(-) create

Re: [Mesa-dev] gallium and ARB_texture_query_levels

2014-02-24 Thread Ilia Mirkin
On Mon, Feb 24, 2014 at 3:38 AM, Dave Airlie airl...@gmail.com wrote: I've taken a quick look at ARB_texture_query_levels, and the HW generally seems to implement this by returning it in the W channel of RESINFO, which would map to the TXQ instruction, So my initial implementation added a

[Mesa-dev] [PATCH] radeonsi: Prevent geometry shader from emitting too many vertices

2014-02-24 Thread Michel Dänzer
From: Michel Daenzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- src/gallium/drivers/radeonsi/si_shader.c | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH] winsys/svga: Avoid calling drm getparam for max surface size on older kernels

2014-02-24 Thread Thomas Hellstrom
This avoids the kernel driver spewing out errors about the param not being supported. Also correct the max surface size used when the kernel does not support the query. Reported-by: Brian Paul bri...@vmware.com Signed-off-by: Thomas Hellstrom thellst...@vmware.com Reviewed-by: Charmaine Lee

Re: [Mesa-dev] gallium and ARB_texture_query_levels

2014-02-24 Thread Chia-I Wu
On Mon, Feb 24, 2014 at 5:03 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Feb 24, 2014 at 3:38 AM, Dave Airlie airl...@gmail.com wrote: I've taken a quick look at ARB_texture_query_levels, and the HW generally seems to implement this by returning it in the W channel of RESINFO, which

Re: [Mesa-dev] gallium and ARB_texture_query_levels

2014-02-24 Thread Marek Olšák
Using TXQ for this sounds good to me. Marek On Mon, Feb 24, 2014 at 9:38 AM, Dave Airlie airl...@gmail.com wrote: I've taken a quick look at ARB_texture_query_levels, and the HW generally seems to implement this by returning it in the W channel of RESINFO, which would map to the TXQ

[Mesa-dev] [PATCH] gallium/targets: resolve undefined reference to

2014-02-24 Thread Emil Velikov
With the introduction of the pipe_loader_sw_probe_dri helper we require the sw/dri winsys during linking stage despite it being unused by any of the targets. This will cause a minor increase in the resulting library which will be cleaned up via linker options with upcoming patches. Cc: Tom

[Mesa-dev] [Bug 75445] New: Mesa 10.2.0-devel implementation error: meta program compile failed:

2014-02-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75445 Priority: medium Bug ID: 75445 Assignee: mesa-dev@lists.freedesktop.org Summary: Mesa 10.2.0-devel implementation error: meta program compile failed: Severity: normal

Re: [Mesa-dev] [PATCH 1/3] targets/gbm: exit gracefully if pipe_loader_drm_probe_fd is not available

2014-02-24 Thread Tom Stellard
These four patches fix the OpenCL build errors. Tested-by: Tom Stellard thomas.stell...@amd.com On Sat, Feb 22, 2014 at 04:53:47PM +, Emil Velikov wrote: When one builds without gallium_drm_loader, the above function will not be available, thus we'll segfault in gallium_screen_create due

Re: [Mesa-dev] [PATCH] gallium/targets: resolve undefined reference to

2014-02-24 Thread Emil Velikov
On 24/02/14 14:26, Emil Velikov wrote: With the introduction of the pipe_loader_sw_probe_dri helper we require the sw/dri winsys during linking stage despite it being unused by any of the targets. This will cause a minor increase in the resulting library which will be cleaned up via linker

[Mesa-dev] [Bug 75335] Use of uninitialized pointer in 'gallium_screen_create()'

2014-02-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75335 Emil Velikov emil.l.veli...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 75356] pipe_loader_sw.c:64: undefined reference to `xlib_create_sw_winsys'

2014-02-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75356 Emil Velikov emil.l.veli...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-24 Thread Roland Scheidegger
Am 23.02.2014 16:26, schrieb Emil Velikov: On 22/02/14 21:46, Roland Scheidegger wrote: - Original Message - From: Emil Velikov emil.l.veli...@gmail.com To: Roland Scheidegger srol...@vmware.com, mesa-dev@lists.freedesktop.org Cc: emil l velikov emil.l.veli...@gmail.com Sent:

Re: [Mesa-dev] [PATCH 2/3] gallium: add texture gather support to gallium (v3)

2014-02-24 Thread Roland Scheidegger
Am 24.02.2014 09:33, schrieb Dave Airlie: On Wed, Feb 12, 2014 at 9:10 AM, Roland Scheidegger srol...@vmware.com wrote: Am 11.02.2014 22:58, schrieb Dave Airlie: dst.z = texture_depth(unit, lod) +.. opcode:: TG4 - Texture Gather (as per ARB_texture_gather) + Gathers the

Re: [Mesa-dev] [PATCH] winsys/svga: Avoid calling drm getparam for max surface size on older kernels

2014-02-24 Thread Brian Paul
On Mon, Feb 24, 2014 at 2:05 AM, Thomas Hellstrom thellst...@vmware.comwrote: This avoids the kernel driver spewing out errors about the param not being supported. Also correct the max surface size used when the kernel does not support the query. Reported-by: Brian Paul bri...@vmware.com

Re: [Mesa-dev] gallium and ARB_texture_query_levels

2014-02-24 Thread Roland Scheidegger
Am 24.02.2014 09:38, schrieb Dave Airlie: I've taken a quick look at ARB_texture_query_levels, and the HW generally seems to implement this by returning it in the W channel of RESINFO, which would map to the TXQ instruction, So my initial implementation added a LEVQ TGSI instruction but I

[Mesa-dev] [PATCH] nv50: correctly calculate the number of vertical blocks during transfer map

2014-02-24 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/drivers/nouveau/nv50/nv50_transfer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_transfer.c b/src/gallium/drivers/nouveau/nv50/nv50_transfer.c index a990682..f716052

Re: [Mesa-dev] [PATCH 3/3] dri3: Add GLX_EXT_buffer_age support

2014-02-24 Thread Robert Bragg
Hi Adel, Thanks for look at this; just a few comments... diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 978730c..afb4206 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx/glx_pbuffer.c @@ -373,6 +373,14 @@ GetDrawableAttribute(Display * dpy, GLXDrawable drawable,

Re: [Mesa-dev] [PATCH] nv50: correctly calculate the number of vertical blocks during transfer map

2014-02-24 Thread Ilia Mirkin
On Mon, Feb 24, 2014 at 11:46 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Nice catch! Does this fix any piglits, or just fixes some XY_OUT_OF_BOUNDS errors? ms_x == ms_y for ms = 4, which oddly enough is where copyteximage passed (should

Re: [Mesa-dev] [PATCH] nv50: correctly calculate the number of vertical blocks during transfer map

2014-02-24 Thread Emil Velikov
On 24/02/14 17:04, Ilia Mirkin wrote: On Mon, Feb 24, 2014 at 11:46 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Nice catch! Does this fix any piglits, or just fixes some XY_OUT_OF_BOUNDS errors? ms_x == ms_y for ms = 4, which oddly

Re: [Mesa-dev] [PATCH] meta: Use a #define for the vector type to avoid %svec4 everywhere.

2014-02-24 Thread Ian Romanick
On 02/21/2014 07:15 PM, Kenneth Graunke wrote: By adding #define gvec4 %svec4 to the top of our fragment shader, we can write generic code without needing to specialize it to vec4, ivec4, or uvec4 via asprintf. This also makes the INT and UNSIGNED_INT merge function code identical, so I

[Mesa-dev] [Bug 75445] Mesa 10.2.0-devel implementation error: meta program compile failed:

2014-02-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75445 Ian Romanick i...@freedesktop.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 1/2] glsl: Add is_horizontal() method to ir_expression.

2014-02-24 Thread Ian Romanick
On 02/22/2014 04:35 PM, Matt Turner wrote: Cc: 10.1 mesa-sta...@lists.freedesktop.org --- src/glsl/ir.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index e27e30a..55ec5ff 100644 --- a/src/glsl/ir.h +++ b/src/glsl/ir.h @@ -1458,6 +1458,16 @@

Re: [Mesa-dev] [PATCH 4/4] glsl: Delete LRP_TO_ARITH lowering pass flag.

2014-02-24 Thread Ian Romanick
On 02/23/2014 07:19 PM, Kenneth Graunke wrote: Tt's kind of a trap---calling do_common_optimization() after lower_instructions() may cause opt_algebraic() to reintroduce ir_triop_lrp expressions that were lowered, effectively defeating the point. Because of this, nobody uses it. Cc: 10.1

[Mesa-dev] [Bug 75226] Dark rendering of War for the Overworld

2014-02-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75226 --- Comment #13 from Erich Hoover erich.e.hoo...@gmail.com --- Created attachment 94676 -- https://bugs.freedesktop.org/attachment.cgi?id=94676action=edit Other user's logs Attached are the logs for the other user, it sounds like you guys

Re: [Mesa-dev] [PATCH 1/2] glsl: Add is_horizontal() method to ir_expression.

2014-02-24 Thread Matt Turner
On Mon, Feb 24, 2014 at 9:43 AM, Ian Romanick i...@freedesktop.org wrote: On 02/22/2014 04:35 PM, Matt Turner wrote: Cc: 10.1 mesa-sta...@lists.freedesktop.org --- src/glsl/ir.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/ir.h b/src/glsl/ir.h index

Re: [Mesa-dev] [PATCH 1/2] R600/SI: Allow SI_KILL for geometry shaders

2014-02-24 Thread Tom Stellard
On Mon, Feb 24, 2014 at 06:02:23PM +0900, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- lib/Target/R600/SILowerControlFlow.cpp | 50 ++ test/CodeGen/R600/llvm.AMDGPU.kill.ll | 18

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-24 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: When the vec4 backend encountered an ir_triop_lrp, it always emitted an actual LRP instruction, which only exists on Gen6+. Gen4-5 used lower_instructions() to decompose ir_triop_lrp at the IR level. Since commit 8d37e9915a3b21 (glsl: Optimize

Re: [Mesa-dev] [PATCH 1/2] mesa: Add core API support for GL_ARB_stencil_texturing (from 4.3).

2014-02-24 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: While the GL_ARB_stencil_texturing extension does not allow the creation of stencil textures, it does allow shaders to sample stencil values stored in packed depth/stencil textures. Specifically, applications can call glTexParameter* with a pname

Re: [Mesa-dev] [PATCH 2/4] i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-24 Thread Matt Turner
On Mon, Feb 24, 2014 at 10:15 AM, Eric Anholt e...@anholt.net wrote: I think we would do better by emitting ADD(y_minus_x, y, negate(x)) MAC(dst, x, y_minus_x, a) MAC only takes two arguments, so - if you meant MAD, there's no MAD on platforms that don't have LRP - if you meant MAC(dst, ...)

Re: [Mesa-dev] [PATCH 3/3] dri3: Add GLX_EXT_buffer_age support

2014-02-24 Thread Eric Anholt
Adel Gadllah adel.gadl...@gmail.com writes: --- src/glx/dri2_glx.c | 1 + src/glx/dri3_glx.c | 18 ++ src/glx/dri3_priv.h | 2 ++ src/glx/glx_pbuffer.c | 8 src/glx/glxclient.h | 1 + src/glx/glxextensions.c | 1 + src/glx/glxextensions.h

Re: [Mesa-dev] [RFC 01/27] i965: Remove unused sampler key fields

2014-02-24 Thread Ian Romanick
It seems very weird that these are unused. Are GL_YCBCR_MESA just completely broken on our driver? If so, we should probably disable that extension... On 02/22/2014 01:05 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com ---

Re: [Mesa-dev] [RFC 04/27] i965: Allow w-tiled miptree offsets to be resolved as y-tiled directly

2014-02-24 Thread Ian Romanick
On 02/22/2014 01:05 AM, Topi Pohjolainen wrote: This is not utilised yet but will be needed when W-tiled stencil is sampled as Y-tiled. Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/intel_fbo.h | 2 +-

Re: [Mesa-dev] [RFC 02/27] i965: Mark sources for offset getters as constants

2014-02-24 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 02/22/2014 01:05 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 6 +++--- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 4 ++--

Re: [Mesa-dev] [RFC 03/27] i965/vec4: Mark invariant members as constants in vec4_visitor

2014-02-24 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 02/22/2014 01:05 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_vec4.h | 6 +++--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 8 2 files

Re: [Mesa-dev] [RFC 05/27] i965/wm: Use resolved miptree consistently in surface setup

2014-02-24 Thread Ian Romanick
On 02/22/2014 01:05 AM, Topi Pohjolainen wrote: Most of the logic refers to the local variable 'mt' directly but a few cases use 'intelObj-mt' instead. These are the same for now but will be different once stencil miptree gets used. Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com ---

Re: [Mesa-dev] [RFC 01/27] i965: Remove unused sampler key fields

2014-02-24 Thread Kenneth Graunke
On 02/24/2014 10:48 AM, Ian Romanick wrote: It seems very weird that these are unused. Are GL_YCBCR_MESA just completely broken on our driver? If so, we should probably disable that extension... Yeah. The old fragment shader backend had code for this, which used these fields, but the new

Re: [Mesa-dev] [RFC 08/27] i965/fs: Configure w-tiled stencil surfaces as y-tiled on gen6/7

2014-02-24 Thread Eric Anholt
Topi Pohjolainen topi.pohjolai...@intel.com writes: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [RFC 01/27] i965: Remove unused sampler key fields

2014-02-24 Thread Chris Forbes
Ken, Just noticed -- all those fields that we're keeping need to be widened to uint32_t for 32 samplers. None of our sampler quirks get flagged correctly for `high` samplers on Haswell at present. I'll send some patches for that this evening if no one beats me to it. -- Chris On Tue, Feb 25,

Re: [Mesa-dev] [PATCH 3/3] dri3: Add GLX_EXT_buffer_age support

2014-02-24 Thread Adel Gadllah
Am 24.02.2014 17:58, schrieb Robert Bragg: Hi Adel, Hi, Thanks for look at this; just a few comments... diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 978730c..afb4206 100644 --- a/src/glx/glx_pbuffer.c +++ b/src/glx/glx_pbuffer.c @@ -373,6 +373,14 @@

[Mesa-dev] [PATCHv3 0/3] dri3: Add GLX_EXT_buffer_age support

2014-02-24 Thread Adel Gadllah
Hi, OK this version of the patches address the review comments from Ian and Robert. The first two ones are actually unmodified just signed them off and added Ian's reviewed-by. The third one now skips the redundant round trip and reports BadDrawable when the drawable isn't bound to the current

[Mesa-dev] [PATCHv3 1/3] glx: Update glxext.h to revision 25407

2014-02-24 Thread Adel Gadllah
Signed-off-by: Adel Gadllah adel.gadl...@gmail.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- include/GL/glxext.h | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/include/GL/glxext.h b/include/GL/glxext.h index 8c642f3..826fda5

[Mesa-dev] [PATCHv3 2/3] glx_pbuffer: Refactor GetDrawableAttribute

2014-02-24 Thread Adel Gadllah
Move the pdraw != NULL check out so that they don't have to be duplicated. Signed-off-by: Adel Gadllah adel.gadl...@gmail.com Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- src/glx/glx_pbuffer.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCHv3 3/3] dri3: Add GLX_EXT_buffer_age support

2014-02-24 Thread Adel Gadllah
Signed-off-by: Adel Gadllah adel.gadl...@gmail.com Reviewed-by: Robert Bragg rob...@sixbynine.org --- src/glx/dri2_glx.c | 1 + src/glx/dri3_glx.c | 18 ++ src/glx/dri3_priv.h | 2 ++ src/glx/glx_pbuffer.c | 33 ++---

Re: [Mesa-dev] [RFC PATCH] i965/gs: add snb support

2014-02-24 Thread Paul Berry
On 24 February 2014 00:36, Ilia Mirkin imir...@alum.mit.edu wrote: Before you read any further, this is nowhere close to working. However it's in a state where I think most of the structure is there, albeit with a lot of XXX comments. And I haven't actually implemented the new opcodes I've

[Mesa-dev] [PATCH] build: llvm libs may not be in system search path, add rpath

2014-02-24 Thread Ilia Mirkin
On my gentoo system, llvm libs are in /usr/lib64/llvm, and llvm-config --ldflags does not provide the rpath (it does, of course, provide a -L). This adds the llvm dir to the rpath. It should be harmless if the path is a system path, and should make things work when it's not. Signed-off-by: Ilia

Re: [Mesa-dev] [PATCH 09/25] dri/radeon: create radeon{Vendor, GetRenderer}String helpers

2014-02-24 Thread Marek Olšák
On Sat, Feb 22, 2014 at 4:03 AM, Emil Velikov emil.l.veli...@gmail.com wrote: To be used by the upcomming GLX_MESA_query_renderer implementation. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- .../drivers/dri/radeon/radeon_common_context.c | 50 +-

Re: [Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-24 Thread Marek Olšák
Roland, The version CAPs that Emil wants to add have very little to do with which features a driver supports. The versions cannot be derived from other CAPs, instead, it should match what you get after you create an OpenGL context. For example, if your driver can do GL 4.0, the driver cannot

Re: [Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-24 Thread Marek Olšák
On Sun, Feb 23, 2014 at 4:26 PM, Emil Velikov emil.l.veli...@gmail.com wrote: Now that I think about it, one could copy the extension list and (context) constants to pipe_screen. This way on st_api_create_context, we'll just copy the initial values over. FWIW we'll still be able to amend the

Re: [Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-24 Thread Roland Scheidegger
Am 24.02.2014 21:23, schrieb Marek Olšák: Roland, The version CAPs that Emil wants to add have very little to do with which features a driver supports. The versions cannot be derived from other CAPs, instead, it should match what you get after you create an OpenGL context. For example, if

Re: [Mesa-dev] [PATCH 21/25] gallium/r300/r600/radeonsi: handle query_renderer caps

2014-02-24 Thread Marek Olšák
The GTT size shouldn't be reported. I think it's 1 GB on r600 and later. It's not really important to know that, because the memory is quite slow. Marek On Sat, Feb 22, 2014 at 4:04 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

Re: [Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-24 Thread Marek Olšák
On Mon, Feb 24, 2014 at 9:43 PM, Roland Scheidegger srol...@vmware.com wrote: Am 24.02.2014 21:23, schrieb Marek Olšák: Roland, The version CAPs that Emil wants to add have very little to do with which features a driver supports. The versions cannot be derived from other CAPs, instead, it

Re: [Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-24 Thread Emil Velikov
On 24/02/14 20:43, Roland Scheidegger wrote: Am 24.02.2014 21:23, schrieb Marek Olšák: Roland, The version CAPs that Emil wants to add have very little to do with which features a driver supports. The versions cannot be derived from other CAPs, instead, it should match what you get after

Re: [Mesa-dev] [PATCH 13/25] gallium: Introduce max_gl*version pipe-caps

2014-02-24 Thread Roland Scheidegger
Am 24.02.2014 21:54, schrieb Marek Olšák: On Mon, Feb 24, 2014 at 9:43 PM, Roland Scheidegger srol...@vmware.com wrote: Am 24.02.2014 21:23, schrieb Marek Olšák: Roland, The version CAPs that Emil wants to add have very little to do with which features a driver supports. The versions

[Mesa-dev] [PATCH] r600g/compute: PIPE_CAP_COMPUTE should be false for pre-evergreen GPUs

2014-02-24 Thread Tom Stellard
This prevents clover from using unsupported devices. --- src/gallium/drivers/r600/r600_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 0f75a53..157d560 100644 ---

Re: [Mesa-dev] [PATCH] r600g/compute: PIPE_CAP_COMPUTE should be false for pre-evergreen GPUs

2014-02-24 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Mon, Feb 24, 2014 at 10:53 PM, Tom Stellard thomas.stell...@amd.com wrote: This prevents clover from using unsupported devices. --- src/gallium/drivers/r600/r600_pipe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] Add GPU BLIT of texture image to PBO in Intel driver

2014-02-24 Thread Jon Ashburn
Add Intel driver hook for glGetTexImage to accelerate the case of reading texture image into a PBO. This case gets huge performance gains by using GPU BLIT directly to PBO rather than GPU BLIT to temporary texture followed by memcpy. No regressions on Piglit tests with Intel driver. ---

[Mesa-dev] [PATCH 1/3] glsl: Optimize lrp(0, y, a) into y * a.

2014-02-24 Thread Matt Turner
Helps two programs in shader-db: instructions in affected programs: 254 - 234 (-7.87%) --- src/glsl/opt_algebraic.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 1b4d319..28f95a4 100644 --- a/src/glsl/opt_algebraic.cpp

[Mesa-dev] [PATCH 2/3] glsl: Optimize lrp(x, 0, a) into x - (x * a).

2014-02-24 Thread Matt Turner
Helps one program in shader-db: instructions in affected programs: 96 - 92 (-4.17%) --- src/glsl/opt_algebraic.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 28f95a4..778638c 100644 --- a/src/glsl/opt_algebraic.cpp +++

[Mesa-dev] [PATCH 3/3] glsl: Optimize division by two with a right shift.

2014-02-24 Thread Matt Turner
--- src/glsl/opt_algebraic.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 778638c..50342ac 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/src/glsl/opt_algebraic.cpp @@ -421,6 +421,9 @@

[Mesa-dev] [PATCH 4/4] configure: enable the drm pipe-loader for non swrast drivers

2014-02-24 Thread Emil Velikov
All hardware drivers including the virtual vmwgfx require the drm pipe-loader in order to be properly loaded by xa, gbm and opencl. Note this does _not_ add support for the above three it only allows the pipe driver to be loaded by the library. Eg. GBM will now properly open the pipe-i915

[Mesa-dev] [PATCH 2/4] configure: avoid setting variables as empty strings

2014-02-24 Thread Emil Velikov
Recent patch converted our logic to use test -n and test -z. An emptry string variable (empty_str=) return true for both thus making the check unreliable. Fix this by correctly setting the variable when applicable. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 6 +++---

[Mesa-dev] [PATCH 3/4] configure: error out when building xa only with swrast

2014-02-24 Thread Emil Velikov
Building to provide accelration using swrast does not make sense. Note: update your build script to explicitly mention svga in the gallium drivers list, if you are building the vmwgfx xa library. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 3 +++ 1 file changed, 3

[Mesa-dev] [PATCH 1/4] configure: avoid constantly building megadrivers 'core'

2014-02-24 Thread Emil Velikov
The issue is caused by a thinko that an empty string will be considered of zero length by 'test'. This is not the case, thus we were building the 'core' of megadrivers even when no classic drivers were built. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 11 +++

Re: [Mesa-dev] [PATCH 1/3] glsl: Optimize lrp(0, y, a) into y * a.

2014-02-24 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com Though we'll eventually want to generalize patch 3. On 02/24/2014 03:00 PM, Matt Turner wrote: Helps two programs in shader-db: instructions in affected programs: 254 - 234 (-7.87%) --- src/glsl/opt_algebraic.cpp | 2 ++ 1

Re: [Mesa-dev] [PATCH 3/3] glsl: Optimize division by two with a right shift.

2014-02-24 Thread Roland Scheidegger
Am 25.02.2014 00:00, schrieb Matt Turner: --- src/glsl/opt_algebraic.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 778638c..50342ac 100644 --- a/src/glsl/opt_algebraic.cpp +++ b/src/glsl/opt_algebraic.cpp @@

Re: [Mesa-dev] [PATCH 3/3] glsl: Optimize division by two with a right shift.

2014-02-24 Thread Ian Romanick
On 02/24/2014 03:36 PM, Roland Scheidegger wrote: Am 25.02.2014 00:00, schrieb Matt Turner: --- src/glsl/opt_algebraic.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 778638c..50342ac 100644 ---

Re: [Mesa-dev] [PATCH 3/3] glsl: Optimize division by two with a right shift.

2014-02-24 Thread Matt Turner
On Mon, Feb 24, 2014 at 3:36 PM, Roland Scheidegger srol...@vmware.com wrote: Am 25.02.2014 00:00, schrieb Matt Turner: --- src/glsl/opt_algebraic.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 778638c..50342ac 100644

[Mesa-dev] [PATCH 6/7] r300g, uvd, vce: set priorities for relocations

2014-02-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This updates all occurences of cs_add_reloc. --- src/gallium/drivers/r300/r300_emit.c | 27 +++ src/gallium/drivers/radeon/r600_cs.h | 3 ++- src/gallium/drivers/radeon/radeon_uvd.c | 3 ++-

[Mesa-dev] [PATCH 4/7] r600g, radeonsi: add a bunch of useful queries for the HUD

2014-02-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/r600_pipe_common.c | 6 - src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++ src/gallium/drivers/radeon/r600_query.c | 32 +++ src/gallium/winsys/radeon/drm/radeon_drm_cs.c |

[Mesa-dev] [PATCH 1/7] winsys/radeon: if there's VRAM-only usage, keep it

2014-02-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 40 +++ 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c index

[Mesa-dev] [PATCH 3/7] r600g, radeonsi: set correct initial domain for shared resources

2014-02-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This depends on the kernel patch. --- src/gallium/drivers/radeon/r600_texture.c | 2 +- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 51 +++ src/gallium/winsys/radeon/drm/radeon_winsys.h | 5 +++ 3 files changed, 51

[Mesa-dev] [PATCH 5/7] winsys/radeon: add interface for setting a priority number for each relocation

2014-02-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com The cs_add_reloc change is commented out not to break compilation. The highest priority of all cs_add_reloc calls is send to the kernel. --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 20 +---

[Mesa-dev] [PATCH 2/7] r600g, radeonsi: use current domain for deciding when to do blit-based transfer

2014-02-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/drivers/radeon/r600_texture.c | 3 ++- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 24 src/gallium/winsys/radeon/drm/radeon_winsys.h | 8 +++- 3 files changed, 33 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH V2 3/4] glsl: Link error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-24 Thread Anuj Phogat
GLSL 1.50 spec says: If gl_FragCoord is redeclared in any fragment shader in a program, it must be redeclared in all the fragment shaders in that program that have a static use gl_FragCoord. All redeclarations of gl_FragCoord in all fragment shaders in a single program must have

[Mesa-dev] [PATCH V2 1/4] glsl: Compile error if fs defines conflicting qualifiers for gl_FragCoord

2014-02-24 Thread Anuj Phogat
GLSL 1.50 spec says: If gl_FragCoord is redeclared in any fragment shader in a program, it must be redeclared in all the fragment shaders in that program that have a static use gl_FragCoord. All redeclarations of gl_FragCoord in all fragment shaders in a single program must have

[Mesa-dev] [PATCH V2 2/4] glsl: Compile error if fs uses gl_FragCoord before first redeclaration

2014-02-24 Thread Anuj Phogat
Section 4.3.8.1, page 39 of GLSL 1.50 spec says: Within any shader, the first redeclarations of gl_FragCoord must appear before any use of gl_FragCoord. GLSL compiler should generate an error in following case: vec4 p = gl_FragCoord; layout(origin_upper_left) in vec4 gl_FragCoord; void

[Mesa-dev] [PATCH V2 4/4] glsl: Apply the link error conditions to GL_ARB_fragment_coord_conventions

2014-02-24 Thread Anuj Phogat
Link error conditions added in previous patch are equally applicable to GL_ARB_fragment_coord_conventions implementation. Extension's spec says: If gl_FragCoord is redeclared in any fragment shader in a program, it must be redeclared in all the fragment shaders in that program that have

[Mesa-dev] [Bug 74010] mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-02-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 --- Comment #6 from Tibbo leclercq.thiba...@yahoo.fr --- I've encountered this segfault before, and i think i can give some useful informations. As stated in the file src/mesa/main/varray.c: /* Page 407 (page 423 of the PDF) of the OpenGL 3.0

Re: [Mesa-dev] [PATCH 2/7] r600g, radeonsi: use current domain for deciding when to do blit-based transfer

2014-02-24 Thread Michel Dänzer
On Die, 2014-02-25 at 00:48 +0100, Marek Olšák wrote: diff --git a/src/gallium/drivers/radeon/r600_texture.c b/src/gallium/drivers/radeon/r600_texture.c index 35ad97b..1966251 100644 --- a/src/gallium/drivers/radeon/r600_texture.c +++ b/src/gallium/drivers/radeon/r600_texture.c @@ -910,7

Re: [Mesa-dev] [PATCH 1/2] R600/SI: Allow SI_KILL for geometry shaders

2014-02-24 Thread Michel Dänzer
On Mon, 2014-02-24 at 10:06 -0800, Tom Stellard wrote: On Mon, Feb 24, 2014 at 06:02:23PM +0900, Michel Dänzer wrote: diff --git a/test/CodeGen/R600/llvm.AMDGPU.kill.ll b/test/CodeGen/R600/llvm.AMDGPU.kill.ll new file mode 100644 index 000..0abe694 --- /dev/null +++