Re: [Mesa-dev] [PATCH 3/6] nir: Try to make sense of the nir_shader_compiler_options code.

2015-03-06 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: The code in glsl_to_nir is entirely dead, as we translate from GLSL to NIR at link time, when there isn't a _mesa_glsl_parse_state to pass, so every caller passes NULL. glsl_to_nir seems like the wrong place to try and create the shader compiler

[Mesa-dev] Mesa 10.4.6

2015-03-06 Thread Emil Velikov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Mesa 10.4.6 has been released. Mesa 10.4.6 is a bug fix release fixing bugs since the 10.4.5 release, (see below for a list of changes). The tag in the git repository for Mesa 10.4.6 is 'mesa-10.4.6'. Mesa 10.4.6 is available for download at

Re: [Mesa-dev] [PATCH 2/2] radeonsi/compute: Use value from compiler for COMPUTE_PGM_RSRC1.FLOAT_MODE

2015-03-06 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Mar 6, 2015 at 4:53 PM, Tom Stellard thomas.stell...@amd.com wrote: --- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 1 + src/gallium/drivers/radeonsi/si_shader.h | 1 + 3 files

[Mesa-dev] [PATCH] glsl: Generate link error for non-matching gl_FragCoord redeclarations

2015-03-06 Thread Anuj Phogat
in different fragment shaders. This also applies to a case when gl_FragCoord is redeclared with no layout qualifiers in one fragment shader and not declared but used in other fragment shader. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Khronos Bug#12957 Cc: 10.5

[Mesa-dev] [PATCH] meta: Plug memory leak in blit shader creation

2015-03-06 Thread Ben Widawsky
It looks like this has existed since: commit f5a477ab76b6e0b268387699cd2253a43db0dfae Author: Ian Romanick ian.d.roman...@intel.com Date: Mon Dec 16 11:54:08 2013 -0800 meta: Refactor shader generation code out of mipmap generation path Valgrind was complaining on the piglit test:

Re: [Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chad Versace
On 03/06/2015 01:58 PM, Chris Wilson wrote: In order to facilitate the concurrency offered by triple buffering and to offset the latency induced by swapping via an external process, which may incur extra rendering itself, only throttle to the previous frame and not the last. The second issue

Re: [Mesa-dev] [PATCH 06/13] i965: Simplify generator code for untyped surface messages.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:49PM +0200, Francisco Jerez wrote: The generate_untyped_*() methods do nothing useful other than calling the corresponding function from brw_eu_emit.c. The calls to brw_mark_surface_used() will go away too in a future commit. ---

Re: [Mesa-dev] [PATCH 03/13] i965: Pass number of components explicitly to brw_untyped_atomic and _surface_read.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:46PM +0200, Francisco Jerez wrote: And calculate the message response size based on the number of components rather than the other way around. This simplifies their interface somewhat and allows the caller to request a writeback message with more than one vector

Re: [Mesa-dev] [PATCH 1/5] i915: Remove unused IS_MOBILE macro

2015-03-06 Thread Damien Lespiau
On Thu, Mar 05, 2015 at 11:49:54AM -0800, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Inspired by Damien's recent libdrm changes. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Damien Lespiau damien.lesp...@intel.com For the whole series (not that my r-b tag

[Mesa-dev] [PATCH 1/6] glsl: Mark array access when copying to a temporary for the ?: operator.

2015-03-06 Thread Kenneth Graunke
Piglit's spec/glsl-1.20/compiler/structure-and-array-operations/ array-selection.vert test contains the following code: gl_Position = (pick_from_a_or_b ? a : b)[i]; where a and b are uniform vec4[2] variables. ast_to_hir creates a temporary vec4[2] variable, conditional_tmp, and generates an

[Mesa-dev] [PATCH 6/6] nir: Only do gl_FrontFacing workaround in glsl_to_nir for the FS.

2015-03-06 Thread Kenneth Graunke
Vertex shaders can have shader inputs where location happens to be VARYING_SLOT_FACE. Without predicating this on the shader stage, we suddenly end up with load_front_face intrinsics in vertex shaders, which is nonsensical. Fixes spec/arb_vertex_buffer_object/pos-array when using NIR for VS.

[Mesa-dev] [PATCH 2/6] nir: Delete nir_shader::user_structures and num_user_structures.

2015-03-06 Thread Kenneth Graunke
Nothing actually uses these, and the only caller of glsl_to_nir() (brw_fs_nir.cpp) always passes NULL for the _mesa_glsl_parse_state pointer, meaning they'll always be NULL and 0, respectively. Just delete them. Signed-off-by: Kenneth Graunke kenn...@whitecape.org ---

[Mesa-dev] [PATCH 4/6] nir: Add native_integers to nir_shader_compiler_options.

2015-03-06 Thread Kenneth Graunke
glsl_to_nir, tgsi_to_nir, and prog_to_nir all want to know whether the driver supports native integers. Presumably other passes may as well. Adding this to nir_shader_compiler_options is an easy way to provide that information, as it's accessible via nir_shader::options. Signed-off-by: Kenneth

[Mesa-dev] [PATCH 3/6] nir: Try to make sense of the nir_shader_compiler_options code.

2015-03-06 Thread Kenneth Graunke
The code in glsl_to_nir is entirely dead, as we translate from GLSL to NIR at link time, when there isn't a _mesa_glsl_parse_state to pass, so every caller passes NULL. glsl_to_nir seems like the wrong place to try and create the shader compiler options structure anyway - tgsi_to_nir,

[Mesa-dev] [PATCH 5/6] nir: Plumb the shader stage into glsl_to_nir().

2015-03-06 Thread Kenneth Graunke
The next commit needs to know the shader stage in glsl_to_nir(). To facilitate that, we pass the gl_shader rather than the raw exec_list of instructions. This has both the exec_list and the stage. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/glsl/nir/glsl_to_nir.cpp

Re: [Mesa-dev] [PATCH 2/2] glx: remove unneeded ifdef _WIN32 guard

2015-03-06 Thread Brian Paul
On 03/06/2015 05:34 AM, Emil Velikov wrote: The C99 header exists on other platforms as well. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/glx/glxclient.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h index a140c87..122ae5d

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-06 Thread Daniel Vetter
On Thu, Mar 05, 2015 at 02:38:44PM -0800, Ian Romanick wrote: On 03/04/2015 10:28 AM, Chad Versace wrote: That text does not appear in the GL spec. When I read the manpage alongside the GL spec, to get a more complete context, I think the manpage contains that phrase simply to contrast with

Re: [Mesa-dev] [PATCH 3/6] nir: Try to make sense of the nir_shader_compiler_options code.

2015-03-06 Thread Jason Ekstrand
Acked-by: Jason Ekstrand jason.ekstr...@intel.com On Mar 6, 2015 2:18 AM, Kenneth Graunke kenn...@whitecape.org wrote: The code in glsl_to_nir is entirely dead, as we translate from GLSL to NIR at link time, when there isn't a _mesa_glsl_parse_state to pass, so every caller passes NULL.

Re: [Mesa-dev] [PATCH 1/2] util: rework _MSC_VER = 1200 checks

2015-03-06 Thread Jose Fonseca
On 06/03/15 14:26, Brian Paul wrote: On 03/06/2015 05:34 AM, Emil Velikov wrote: Replace the _MSC_VER = 1200 with defined (_MSC_VER) and compact if/else statements. We require MSVC 2008 or later with commit 46110c5d564. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

[Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chris Wilson
When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential callers avoid often glFinish for being too heavy

[Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chris Wilson
When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential callers avoid often glFinish for being too heavy

Re: [Mesa-dev] [PATCH 1/6] glsl: Mark array access when copying to a temporary for the ?: operator.

2015-03-06 Thread Jason Ekstrand
I gave you an back on 3; I'll let Eric actually review it. The rest are Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Mar 6, 2015 2:18 AM, Kenneth Graunke kenn...@whitecape.org wrote: Piglit's spec/glsl-1.20/compiler/structure-and-array-operations/ array-selection.vert test contains

Re: [Mesa-dev] [PATCH 1/2] util: rework _MSC_VER = 1200 checks

2015-03-06 Thread Brian Paul
On 03/06/2015 05:34 AM, Emil Velikov wrote: Replace the _MSC_VER = 1200 with defined (_MSC_VER) and compact if/else statements. We require MSVC 2008 or later with commit 46110c5d564. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/util/macros.h | 8 +++- 1 file changed, 3

[Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chris Wilson
In order to facilitate the concurrency offered by triple buffering and to offset the latency induced by swapping via an external process, which may incur extra rendering itself, only throttle to the previous frame and not the last. This doubles the maximum possible latency at the benefit of

Re: [Mesa-dev] [PATCH] Fix invalid extern C around header inclusion.

2015-03-06 Thread Jose Fonseca
On 06/03/15 00:11, Mark Janes wrote: Matt Turner matts...@gmail.com writes: On Thu, Mar 5, 2015 at 4:54 AM, Jose Fonseca jfons...@vmware.com wrote: Thanks for doing this. It looks great. Reviewed-by: Jose Fonseca jfons...@vmware.com Feel free to push my patch or I'll push it after you

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Mar 06, 2015 at 02:29:15PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead of a constant and to use brw_send_indirect_message() to emit the

[Mesa-dev] [PATCH 2/2] glx: remove unneeded ifdef _WIN32 guard

2015-03-06 Thread Emil Velikov
The C99 header exists on other platforms as well. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/glx/glxclient.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h index a140c87..122ae5d 100644 --- a/src/glx/glxclient.h +++

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 02:29:15PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 02:46:51PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Mar 06, 2015 at 02:29:15PM +0200, Francisco Jerez wrote: Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:48PM +0200,

Re: [Mesa-dev] [PATCH 05/13] i965: Fix the untyped surface opcodes to deal with indirect surface access.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:48PM +0200, Francisco Jerez wrote: Change brw_untyped_atomic() and brw_untyped_surface_read() to take the surface index as a register instead of a constant and to use brw_send_indirect_message() to emit the indirect variant of send with a dynamically calculated

[Mesa-dev] [PATCH 1/2] util: rework _MSC_VER = 1200 checks

2015-03-06 Thread Emil Velikov
Replace the _MSC_VER = 1200 with defined (_MSC_VER) and compact if/else statements. We require MSVC 2008 or later with commit 46110c5d564. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/util/macros.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_eu.h | 19 ++-- src/mesa/drivers/dri/i965/brw_eu_emit.c | 58 ++--

Re: [Mesa-dev] [PATCH 04/13] i965: Mask out unused Align16 components in brw_untyped_atomic.

2015-03-06 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:47PM +0200, Francisco Jerez wrote: This is currently not a problem because the vec4 visitor happens to mask out unused components from the destination, but it might become an issue when we start using atomics

Re: [Mesa-dev] [PATCH 08/13] i965/vec4: Add support for untyped surface message sends from GRF.

2015-03-06 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Feb 27, 2015 at 05:34:51PM +0200, Francisco Jerez wrote: This doesn't actually enable untyped surface message sends from GRF yet, the upcoming atomic counter and image intrinsic lowering code will. ---

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_eu.h | 19 ++-- src/mesa/drivers/dri/i965/brw_eu_emit.c | 58 ++-- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 55 +-

[Mesa-dev] [PATCH 4/6] dri/intel: the aligned_alloc/free over the _mesa_* wrappers

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/drivers/dri/i915/intel_buffer_objects.c | 19 ++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c| 5 +++-- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git

[Mesa-dev] [PATCH 2/5] egl/main: convert thread management to use c11 threads

2015-03-06 Thread Emil Velikov
Convert the code to use the C11 threads implementation, and nuke the Windows non-pthreads code-path. The c11/threads_win32.h abstraction should be better than the current code. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/main/eglcurrent.c | 48

[Mesa-dev] [PATCH 4/5] glx: remove final reference to THREADS

2015-03-06 Thread Emil Velikov
Left over from commit 18db13f5865(mapi: THREADS was always defined, remove it) Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/glx/glxcurrent.c | 4 1 file changed, 4 deletions(-) diff --git a/src/glx/glxcurrent.c b/src/glx/glxcurrent.c index dc2acd5..86fb658 100644 ---

[Mesa-dev] [PATCH 3/5] configure: require pthreads for POSIX builds

2015-03-06 Thread Emil Velikov
This has been an implicit rule for building mesa for a long time. Let's make it official and just bail out at configure time. This way we can cleaning up some of our glx code. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-06 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: On Thu, Mar 05, 2015 at 08:42:25PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: This means dropping CL_FP_DENORM from the current return value. --- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- 1 file

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
Hi all, Just accidently pushed the series to master. I'll revert them in a second. -Emil On 06/03/15 16:54, Emil Velikov wrote: Remove the inline wrappers/abstraction layer. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/main/Makefile.sources | 1 -

[Mesa-dev] [PATCH 0/6] Slimdown import.[ch] - add c11_stdlib.h wrapper

2015-03-06 Thread Emil Velikov
C11 introduces the aligned_alloc() function, while mesa already has it's own wrapper. Create a new header, and make use of it. I was aiming to convert gallium as well, although that code diverges depending on the debugging state required but wrapping around malloc and friends. #This series

Re: [Mesa-dev] [PATCH 5/6] st/mesa: don't use the mesa wrapper _mesa_align_free

2015-03-06 Thread Ilia Mirkin
On Fri, Mar 6, 2015 at 11:32 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Upon closer look it seems that TexData is no longer used. Perhaps we can nuke it ? http://patchwork.freedesktop.org/patch/43969/ Signed-off-by: Emil Velikov emil.l.veli...@gmail.com ---

[Mesa-dev] [PATCH 5/5] glx: remove support for non-multithreaded platforms

2015-03-06 Thread Emil Velikov
Implicitly required for a while, although commit 9385c592c68 (mapi: remove u_thread.h) was the one that put the final nail on the coffin. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- docs/dispatch.html| 7 ++- src/glx/glxclient.h | 18

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
On 06/03/15 17:05, Emil Velikov wrote: Hi all, Just accidently pushed the series to master. I'll revert them in a second. All done. Apologies for the noise. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH 6/6] mesa/main: remove _mesa_align_malloc/free

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/main/imports.c | 76 - src/mesa/main/imports.h | 6 2 files changed, 82 deletions(-) diff --git a/src/mesa/main/imports.c b/src/mesa/main/imports.c index 5961587..3937a02

[Mesa-dev] [PATCH 5/6] st/mesa: don't use the mesa wrapper _mesa_align_free

2015-03-06 Thread Emil Velikov
Upon closer look it seems that TexData is no longer used. Perhaps we can nuke it ? Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/state_tracker/st_cb_texture.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-06 Thread Tom Stellard
On Thu, Mar 05, 2015 at 08:42:25PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: This means dropping CL_FP_DENORM from the current return value. --- src/gallium/state_trackers/clover/api/device.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 2/2] radeonsi/compute: Use value from compiler for COMPUTE_PGM_RSRC1.FLOAT_MODE

2015-03-06 Thread Tom Stellard
--- src/gallium/drivers/radeonsi/si_compute.c | 3 ++- src/gallium/drivers/radeonsi/si_shader.c | 1 + src/gallium/drivers/radeonsi/si_shader.h | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute.c

[Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Tom Stellard
This means dropping CL_FP_DENORM from the current return value. v2: - Add comments about minimum values for OpenCL 1.2. --- src/gallium/state_trackers/clover/api/device.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/api/device.cpp

[Mesa-dev] [PATCH 3/6] mesa: use c11_stdlib.h' aligned_alloc/free

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/main/bufferobj.c | 8 +--- src/mesa/math/m_debug_norm.c | 6 -- src/mesa/math/m_debug_xform.c | 6 -- src/mesa/math/m_matrix.c | 10 ++ src/mesa/math/m_vector.c | 5 +++--

[Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Emil Velikov
Used for aligned_alloc and other C11 functions missing from the header. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- include/c11_stdlib.h | 118 +++ 1 file changed, 118 insertions(+) create mode 100644 include/c11_stdlib.h diff --git

[Mesa-dev] [PATCH 2/6] mesa: inline _mesa_align_{re, c}alloc into their only users

2015-03-06 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/mesa/main/imports.c | 74 +-- src/mesa/main/imports.h | 7 src/mesa/program/prog_parameter.c | 18 +++--- src/mesa/tnl/t_vertex.c | 5 ++- 4 files changed, 18

[Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
Remove the inline wrappers/abstraction layer. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/egl/main/Makefile.sources | 1 - src/egl/main/eglapi.c | 14 + src/egl/main/eglcurrent.c | 13 - src/egl/main/egldisplay.c | 13 +

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Emil Velikov
On 06/03/15 17:05, Emil Velikov wrote: Hi all, Just accidently pushed the series to master. I'll revert them in a second. All done. Apologies for the noise. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 1/5] i915: Remove unused IS_MOBILE macro

2015-03-06 Thread Jordan Justen
Series Reviewed-by: Jordan Justen jordan.l.jus...@intel.com On 2015-03-05 11:49:54, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Inspired by Damien's recent libdrm changes. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Damien Lespiau damien.lesp...@intel.com

Re: [Mesa-dev] [PATCH 09/13] i965: Pass the number of components as a source of the untyped surface read opcode.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:52PM +0200, Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 5 +++-- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 6 --

Re: [Mesa-dev] [PATCH] i965/nir: Resolve source modifiers on Gen8+ logic operations.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 01:33:05AM -0800, Kenneth Graunke wrote: On Gen8+, AND/OR/XOR/NOT don't support the abs() source modifier, and negate changes meaning to bitwise-not (~, not -). This isn't what NIR expects, so we should resolve the source modifers via a MOV. +30 Piglits

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Francisco Jerez
Pohjolainen, Topi topi.pohjolai...@intel.com writes: On Fri, Mar 06, 2015 at 10:37:06AM +0200, Pohjolainen, Topi wrote: On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: [..] +/** + * Send message to shared unit \p sfid with a possibly indirect descriptor \p + * desc.

Re: [Mesa-dev] [PATCH 10/13] i965: Reorder sources of the untyped atomic opcode.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:53PM +0200, Francisco Jerez wrote: This is consistent with the untyped surface read opcode. From now on all typed and untyped surface access opcodes will follow the same pattern: src[0] will be the message payload, src[1] will be the surface index and src[2] will

Re: [Mesa-dev] [PATCH 08/13] i965/vec4: Add support for untyped surface message sends from GRF.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:51PM +0200, Francisco Jerez wrote: This doesn't actually enable untyped surface message sends from GRF yet, the upcoming atomic counter and image intrinsic lowering code will. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 7 ---

Re: [Mesa-dev] [PATCH 01/13] i965: Factor out logic to build a send message instruction with indirect descriptor.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Mar 06, 2015 at 10:37:06AM +0200, Pohjolainen, Topi wrote: On Fri, Feb 27, 2015 at 05:34:44PM +0200, Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_eu.h | 19 ++-- src/mesa/drivers/dri/i965/brw_eu_emit.c | 58 ++--

[Mesa-dev] [PATCH] i965/nir: Resolve source modifiers on Gen8+ logic operations.

2015-03-06 Thread Kenneth Graunke
On Gen8+, AND/OR/XOR/NOT don't support the abs() source modifier, and negate changes meaning to bitwise-not (~, not -). This isn't what NIR expects, so we should resolve the source modifers via a MOV. +30 Piglits (fs-op-bit{and,or,xor}-not-abs-*). Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH] i965: Fix URB size for CHV

2015-03-06 Thread Ville Syrjälä
On Thu, Mar 05, 2015 at 01:48:29PM -0800, Kenneth Graunke wrote: On Thursday, March 05, 2015 07:41:29 PM Ville Syrjälä wrote: On Fri, Jan 23, 2015 at 12:12:56PM +0200, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com Increase the device info

Re: [Mesa-dev] [PATCH 04/13] i965: Mask out unused Align16 components in brw_untyped_atomic.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:47PM +0200, Francisco Jerez wrote: This is currently not a problem because the vec4 visitor happens to mask out unused components from the destination, but it might become an issue when we start using atomics without writeback message. In any case it seems

Re: [Mesa-dev] [PATCH 07/13] i965: Don't request untyped atomic writeback message if the destination is null.

2015-03-06 Thread Pohjolainen, Topi
On Fri, Feb 27, 2015 at 05:34:50PM +0200, Francisco Jerez wrote: --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 2 +- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com

Re: [Mesa-dev] [PATCH] i965/fs: Implement SIMD16 dual source blending.

2015-03-06 Thread Kenneth Graunke
On Thursday, March 05, 2015 09:39:58 PM Jason Ekstrand wrote: This looks fine to me. I just kicked off a build on our test farm and, assuming that looks good (I'll send another e-mail in the morning if it does), Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com I ran shader-db on the

Re: [Mesa-dev] [PATCH] i915: Fix GCC unused-variable warning in release build.

2015-03-06 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au On Tue, 2015-03-03 at 18:57 -0800, Vinson Lee wrote: i915_debug_fp.c: In function ‘i915_disassemble_program’: i915_debug_fp.c:302:11: warning: unused variable ‘size’ [-Wunused-variable] GLuint size = program[0] 0x1ff; ^

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptrRTDyldMemoryManager'

2015-03-06 Thread Emil Velikov
On 4 March 2015 at 18:07, Roland Scheidegger srol...@vmware.com wrote: Am 04.03.2015 um 12:38 schrieb Jose Fonseca: On 04/03/15 02:00, Emil Velikov wrote: On 27 February 2015 at 23:28, Sedat Dilek sedat.di...@gmail.com wrote: On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov

Re: [Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Jan Vesely
On Fri, 2015-03-06 at 15:53 +, Tom Stellard wrote: This means dropping CL_FP_DENORM from the current return value. v2: - Add comments about minimum values for OpenCL 1.2. --- src/gallium/state_trackers/clover/api/device.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH 1/2] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG v2

2015-03-06 Thread Francisco Jerez
Jan Vesely jan.ves...@rutgers.edu writes: On Fri, 2015-03-06 at 15:53 +, Tom Stellard wrote: This means dropping CL_FP_DENORM from the current return value. v2: - Add comments about minimum values for OpenCL 1.2. --- src/gallium/state_trackers/clover/api/device.cpp | 5 - 1

Re: [Mesa-dev] [PATCH 1/5] egl/main: use c11/threads' mutex directly

2015-03-06 Thread Brian Paul
On Fri, Mar 6, 2015 at 10:14 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 06/03/15 17:05, Emil Velikov wrote: Hi all, Just accidently pushed the series to master. I'll revert them in a second. All done. Apologies for the noise. Series looks OK to me. You can re-push with

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Brian Paul
On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Used for aligned_alloc and other C11 functions missing from the header. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- include/c11_stdlib.h | 118 ++ I wonder if this should

Re: [Mesa-dev] [PATCH] clover: Return the minimum required value for CL_DEVICE_SINGLE_FP_CONFIG

2015-03-06 Thread Matt Arsenault
On Mar 6, 2015, at 8:56 AM, Francisco Jerez curroje...@riseup.net wrote: Tom Stellard t...@stellard.net mailto:t...@stellard.net writes: On Thu, Mar 05, 2015 at 08:42:25PM +0200, Francisco Jerez wrote: Tom Stellard thomas.stell...@amd.com writes: This means dropping CL_FP_DENORM from

Re: [Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chad Versace
On 03/06/2015 06:56 AM, Chris Wilson wrote: When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential

[Mesa-dev] [Bug 89477] include/no_extern_c.h:47:1: error: template with C linkage

2015-03-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89477 Bug ID: 89477 Summary: include/no_extern_c.h:47:1: error: template with C linkage Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chad Versace
On 03/06/2015 06:56 AM, Chris Wilson wrote: In order to facilitate the concurrency offered by triple buffering and to offset the latency induced by swapping via an external process, which may incur extra rendering itself, only throttle to the previous frame and not the last. This doubles the

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

2015-03-06 Thread Mark Janes
Unfortunately, my build configuration does not build gallium. This caused me to miss some files which still have extern C includes. Due to this oversight, master encounters build errors. I'll send a patch asap. -Mark Mark Janes mark.a.ja...@intel.com writes: Assuming my patch to fix 'extern

[Mesa-dev] [PATCH] i965/skl: Fix the order of the arguments for the LD sampler message

2015-03-06 Thread Neil Roberts
In Skylake the order of the arguments for sample messages with the LD type are u, v, lod, r whereas previously they were u, lod, v, r. This fixes 82 Piglit tests using texelFetch. --- I have a feeling this probably isn't the right way to do this patch so maybe someone who knows the compiler

[Mesa-dev] [Bug 89477] include/no_extern_c.h:47:1: error: template with C linkage

2015-03-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89477 --- Comment #2 from Mark Janes mark.a.ja...@intel.com --- patch sent to list. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev

Re: [Mesa-dev] [PATCH] nouveau: Fix build, invalid extern C around header inclusion.

2015-03-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin imir...@alum.mit.edu However you should probably split off the r300_public.h change into a separate commit -- a little awkward to have 'nouveau:' as the subject of a change to r300. -ilia On Fri, Mar 6, 2015 at 4:16 PM, Mark Janes mark.a.ja...@intel.com wrote: The

[Mesa-dev] [PATCH] nouveau: Fix build, invalid extern C around header inclusion.

2015-03-06 Thread Mark Janes
The previous patch to fix header inclusion within extern C neglected to fix the occurences of this pattern in nouveau files. When the helper to detect this issue was pushed to master, it broke the build for the nouveau driver. This patch fixes the nouveau build. Bugzilla:

Re: [Mesa-dev] [PATCH, v2 1/2] nouveau: Fix build, invalid extern C around header inclusion.

2015-03-06 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu Thanks for splitting them up! On Fri, Mar 6, 2015 at 4:36 PM, Mark Janes mark.a.ja...@intel.com wrote: A previous patch to fix header inclusion within extern C neglected to fix the occurences of this pattern in nouveau files. When the

[Mesa-dev] [Bug 89477] include/no_extern_c.h:47:1: error: template with C linkage

2015-03-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89477 --- Comment #1 from Mark Janes mark.a.ja...@intel.com --- Can you please include your configure line? I'm having trouble reproducing your failure. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [PATCH, v2 2/2] r300g: Fix build, invalid extern C around header inclusion.

2015-03-06 Thread Mark Janes
A previous patch to fix header inclusion within extern C neglected to fix the occurences of this pattern in r300 files. When the helper to detect this issue was pushed to master, it broke the build for the r300 driver. This patch fixes the r300 build. Bugzilla:

[Mesa-dev] [PATCH, v2 1/2] nouveau: Fix build, invalid extern C around header inclusion.

2015-03-06 Thread Mark Janes
A previous patch to fix header inclusion within extern C neglected to fix the occurences of this pattern in nouveau files. When the helper to detect this issue was pushed to master, it broke the build for the nouveau driver. This patch fixes the nouveau build. Bugzilla:

[Mesa-dev] [PATCH 1/2] i965: Throttle rendering to an fbo

2015-03-06 Thread Chris Wilson
When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential callers avoid often glFinish for being too heavy

[Mesa-dev] [PATCH 2/2] i965: Throttle to the previous frame

2015-03-06 Thread Chris Wilson
In order to facilitate the concurrency offered by triple buffering and to offset the latency induced by swapping via an external process, which may incur extra rendering itself, only throttle to the previous frame and not the last. The second issue that mostly affects swap benchmarks, but also can

[Mesa-dev] [PATCH] i965: Silence GCC maybe-uninitialized warning.

2015-03-06 Thread Vinson Lee
brw_shader.cpp: In function ‘bool brw_saturate_immediate(brw_reg_type, brw_reg*)’: brw_shader.cpp:618:31: warning: ‘sat_imm.brw_saturate_immediate(brw_reg_type, brw_reg*)::anonymous union::ud’ may be used uninitialized in this function [-Wmaybe-uninitialized] reg-dw1.ud = sat_imm.ud;

[Mesa-dev] [PATCH] egl/dri2: Fix GCC maybe-uninitialized warning.

2015-03-06 Thread Vinson Lee
egl_dri2.c: In function ‘dri2_bind_tex_image’: egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*dri2_dpy-tex_buffer-setTexBuffer2)(dri2_ctx-dri_context, ^ Signed-off-by: Vinson Lee v...@freedesktop.org ---

Re: [Mesa-dev] [PATCH 1/6] c11: add c11 compatibility wrapper around stdlib.h

2015-03-06 Thread Jose Fonseca
On 07/03/15 07:23, Jose Fonseca wrote: On 06/03/15 18:26, Brian Paul wrote: On Fri, Mar 6, 2015 at 9:32 AM, Emil Velikov emil.l.veli...@gmail.com mailto:emil.l.veli...@gmail.com wrote: Used for aligned_alloc and other C11 functions missing from the header. Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH v2] nv30: Add unused attribute to function nv40_fp_bra.

2015-03-06 Thread Vinson Lee
Silences GCC unused-function warning. nv30/nvfx_fragprog.c:333:1: warning: ‘nv40_fp_bra’ defined but not used [-Wunused-function] nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) ^ Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 2 +- 1

[Mesa-dev] [PATCH] i915: Fix GCC unused-but-set-variable warning in release build.

2015-03-06 Thread Vinson Lee
i915_fragprog.c: In function ‘i915ValidateFragmentProgram’: i915_fragprog.c:1453:11: warning: variable ‘k’ set but not used [-Wunused-but-set-variable] int k; ^ Signed-off-by: Vinson Lee v...@freedesktop.org --- src/mesa/drivers/dri/i915/i915_fragprog.c | 5 + 1 file

[Mesa-dev] [PATCH] radeon: Fix GCC unused-but-set-variable warnings.

2015-03-06 Thread Vinson Lee
radeon_fbo.c: In function ‘radeon_map_renderbuffer_s8z24’: radeon_fbo.c:162:9: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret; ^ radeon_fbo.c: In function ‘radeon_map_renderbuffer_z16’: radeon_fbo.c:200:9: warning: variable ‘ret’ set but not used

[Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

2015-03-06 Thread Vinson Lee
egl_dri2.c: In function ‘dri2_bind_tex_image’: egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*dri2_dpy-tex_buffer-setTexBuffer2)(dri2_ctx-dri_context, ^ Suggested-by: Ilia Mirkin imir...@alum.mit.edu Signed-off-by: Vinson Lee

[Mesa-dev] [PATCH 4/4] Clover: use get_device_vendor instead of get_vendor

2015-03-06 Thread Giuseppe Bilotta
The pipe's get_vendor method returns something more akin to a driver vendor string in most cases, instead of the actual device vendor. Use get_device_vendor instead, which was introduced specifically for this purpose. --- src/gallium/state_trackers/clover/core/device.cpp | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 3/4] Implement get_device_vendor() for existing drivers

2015-03-06 Thread Giuseppe Bilotta
The only hackish ones are llvmpipe and softpipe, which currently return the same string as for get_vendor(), while ideally they should return the CPU vendor. --- src/gallium/drivers/freedreno/freedreno_screen.c | 8 src/gallium/drivers/galahad/glhd_screen.c| 10 ++

[Mesa-dev] [PATCH 2/4] Introduce get_device_vendor() entrypoint for pipes

2015-03-06 Thread Giuseppe Bilotta
This will be needed by Clover to return the correct information to CL_DEVICE_VENDOR info queries. --- src/gallium/include/pipe/p_screen.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/include/pipe/p_screen.h b/src/gallium/include/pipe/p_screen.h index 4018f8a..cba4c95

[Mesa-dev] [PATCHv2 0/4] Separate device from driver vendor

2015-03-06 Thread Giuseppe Bilotta
OpenCL (as opposed to OpenGL) has separate vendor strings for the implementation/driver/platform and the device. CL_PLATFORM_VENDOR is akin to the GL_VENDOR string, while CL_DEVICE_VENDOR is supposed to return the actual device vendor. (For example, the AMD OpenCL platform returns GenuineIntel as

  1   2   >