[Mesa-dev] [PATCH 4/6] gallium/drivers/ilo: Use unsigned for loop index

2016-01-05 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/ilo/core/ilo_builder.c | 8 src/gallium/drivers/ilo/shader/ilo_shader_fs.c | 16

[Mesa-dev] [PATCH 3/6] gallium: Use unsigned for loop index

2016-01-05 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 6/6] gallium/drivers/svga: Use unsigned for loop index

2016-01-05 Thread Edward O'Callaghan
Fix a 's/unsigned int/unsigned/' consistency case while here. Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/svga/svga_resource_buffer_upload.c | 2 +-

[Mesa-dev] [PATCH 2/6] gallium/drivers: Remove unnecessary semicolons

2016-01-05 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/i915/i915_state.c | 2 +- src/gallium/drivers/ilo/shader/ilo_shader_vs.c| 2 +- src/gallium/drivers/llvmpipe/lp_test_blend.c

[Mesa-dev] [PATCH 5/6] gallium/drivers/r600: Use unsigned for loop index

2016-01-05 Thread Edward O'Callaghan
Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/drivers/r600/r600_shader.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git

[Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2016-01-05 Thread Edward O'Callaghan
Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward O'Callaghan Reviewed-by: Brian Paul --- src/gallium/auxiliary/draw/draw_pipe_aaline.c | 2 +-

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Marek Olšák
On Tue, Jan 5, 2016 at 5:19 PM, Axel Davy wrote: > Hi Nicolas, > > I believe this patch doesn't fully solve the problem and could introduce > some bugs. > > For example you change dri2_create_image_from_name pitch argument to stride, > whereas this function is used as is to

Re: [Mesa-dev] [PATCH] i965: Use rcp in brw_lower_texture_gradients rather than 1.0 / x.

2016-01-05 Thread Pohjolainen, Topi
On Tue, Jan 05, 2016 at 05:33:09AM -0800, Kenneth Graunke wrote: > That's what it's for. Plus, we actually implement rcp. Reviewed-by: Topi Pohjolainen > > Signed-off-by: Kenneth Graunke > --- >

Re: [Mesa-dev] [PATCH shader-db 4/4] run.py: Add tessellation shader support.

2016-01-05 Thread Matt Turner
On Tue, Jan 5, 2016 at 6:04 AM, Kenneth Graunke wrote: > --- > run.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > in case you want to use the old runner to produce .out files. Thanks :) All four look good to me. Reviewed-by: Matt Turner

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Nicolas Dufresne
Le mardi 05 janvier 2016 à 17:19 +0100, Axel Davy a écrit : > Hi Nicolas, > > I believe this patch doesn't fully solve the problem and could > introduce some bugs. > > For example you change dri2_create_image_from_name pitch argument to > stride, > whereas this function is used as is to

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Axel Davy
Hi Nicolas, I believe this patch doesn't fully solve the problem and could introduce some bugs. For example you change dri2_create_image_from_name pitch argument to stride, whereas this function is used as is to implement createImageFromName from __DRIimageExtensionRec, which takes a pitch.

Re: [Mesa-dev] [PATCH 2/2] glsl: Relax ir_quadop_bitfield_insert type restrictions.

2016-01-05 Thread Matt Turner
Both look good to me. Thanks! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] glsl: Relax ir_quadop_bitfield_insert type restrictions.

2016-01-05 Thread Ilia Mirkin
On Tue, Jan 5, 2016 at 8:34 AM, Kenneth Graunke wrote: > While GLSL restricts bitfieldInsert's offset and bits parameters to > be scalars, we shouldn't require this in the IR. > > In particular, opt_vectorize() tries to combine > > result.x = bitfieldInsert(src0.x, src1.x,

Re: [Mesa-dev] [PATCH] i965: Use rcp in brw_lower_texture_gradients rather than 1.0 / x.

2016-01-05 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: add image_format check in cross_validate_globals()

2016-01-05 Thread Lofstedt, Marta
Thanks Samuel, I confirm that your patch fixes the testcase for both BDW and SKL. /Marta From: Samuel Iglesias Gonsálvez [sigles...@igalia.com] Sent: Tuesday, January 05, 2016 2:32 PM To: mesa-dev@lists.freedesktop.org Cc: Lofstedt, Marta; Samuel Iglesias

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #7 from Roland Scheidegger --- (In reply to Michael Harder from comment #6) > I am experiencing a crash with a SIGILL, Illegal instruction in Debian when > using Kodi. > > [Thread debugging using libthread_db

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

2016-01-05 Thread Nicolas Dufresne
Le me know if this patch needs an update. cheers, Nicolas Le jeudi 24 décembre 2015 à 15:15 -0500, Nicolas Dufresne a écrit : > In order to convert from stride to pitch, few functions were diving > by 4 > the stride. This is not valid for RGB565 and this conversion was not > needed anyway in

Re: [Mesa-dev] [PATCH shader-db] si-report: Track max waves per CU

2016-01-05 Thread Matt Arsenault
> On Jan 5, 2016, at 07:28, Marek Olšák wrote: > > Hi, > > I'd like us to do this computation in Mesa, because it can be more > accurate there. The pixel shader wave count depends heavily on LDS, > because each interpolated input occupies 12 dwords of LDS per > primitive and

Re: [Mesa-dev] [PATCH shader-db] si-report: Track max waves per CU

2016-01-05 Thread Marek Olšák
On Tue, Jan 5, 2016 at 4:04 PM, Matt Arsenault wrote: > >> On Jan 5, 2016, at 07:28, Marek Olšák wrote: >> >> Hi, >> >> I'd like us to do this computation in Mesa, because it can be more >> accurate there. The pixel shader wave count depends heavily on LDS,

Re: [Mesa-dev] [PATCH] i965: Only turn on ARB_compute_shader if we can write registers.

2016-01-05 Thread Francisco Jerez
Kenneth Graunke writes: > Compute shaders require reconfiguring the L3 for shared local memory > support. We have to be able to write the L3 registers to do that. > > This effectively turns off compute shaders prior to Kernel 4.2. > > (Previously, the extension enable was

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #8 from Michael Harder --- >From 'cat /proc/cpuinfo' model name : Intel(R) Pentium(R) 4 CPU 3.00GHz and from 'lspci' VGA compatible controller: Intel Corporation 82915G/GV/910GL Integrated Graphics

Re: [Mesa-dev] [PATCH 8/8] mesa: minor clean-up of some memcpy/sizeof() calls in m_matrix.c

2016-01-05 Thread Charmaine Lee
This series looks fine to me. Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, January 4, 2016 4:49 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH 8/8] mesa: minor clean-up of

Re: [Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread Patrick Baggett
Given that there is a _mesa_3dnow_transform_points4_2d in the x86-64 asm (using MMX/3DNow! is deprecated in x86-64), it appears that this code was copy-pasted. I wrote a quick patch to change prefetch[w] to prefetcht1, which is more or less the equivalent in SSE. However, I'm not actually sure

[Mesa-dev] [PATCH 2/2] glsl: Relax ir_quadop_bitfield_insert type restrictions.

2016-01-05 Thread Kenneth Graunke
While GLSL restricts bitfieldInsert's offset and bits parameters to be scalars, we shouldn't require this in the IR. In particular, opt_vectorize() tries to combine result.x = bitfieldInsert(src0.x, src1.x, src2.x, src3.x); result.y = bitfieldInsert(src0.y, src1.y, src2.y, src3.y); result.z =

[Mesa-dev] [PATCH 1/2] glsl: Disallow vectorization of vector_insert/extract.

2016-01-05 Thread Kenneth Graunke
vector_insert takes a vector, a scalar location, and a scalar value, and produces a new vector with that component updated. As such, it can't be vectorized properly. vector_extract takes a vector and a scalar location, and returns that scalar component of the vector. Vectorization doesn't

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #9 from Roland Scheidegger --- (In reply to Michael Harder from comment #8) > From 'cat /proc/cpuinfo' > model name : Intel(R) Pentium(R) 4 CPU 3.00GHz Using any special build flags? As said I can't see how

[Mesa-dev] [Bug 93577] Total war: Attila crashes at startup

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93577 Michel Dänzer changed: What|Removed |Added Component|Drivers/Gallium/r600|Mesa core

[Mesa-dev] [PATCH 1/5] mesa/bufferobj: make _mesa_delete_buffer_object externally accessible

2016-01-05 Thread Nicolai Hähnle
From: Nicolai Hähnle gl_buffer_object has grown more complicated and requires cleanup. Using this function from drivers will be more future-proof. --- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/bufferobj.h | 4 2 files changed, 5 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH 5/5] i965: use _mesa_delete_buffer_object

2016-01-05 Thread Nicolai Hähnle
From: Nicolai Hähnle This is more future-proof, plugs the memory leak of Label and properly destroys the buffer mutex. --- src/mesa/drivers/dri/i965/intel_buffer_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 4/5] i915: use _mesa_delete_buffer_object

2016-01-05 Thread Nicolai Hähnle
From: Nicolai Hähnle This is more future-proof, plugs the memory leak of Label and properly destroys the buffer mutex. --- src/mesa/drivers/dri/i915/intel_buffer_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 2/5] st/mesa: use _mesa_delete_buffer_object

2016-01-05 Thread Nicolai Hähnle
From: Nicolai Hähnle This is more future-proof than the current code. --- src/mesa/state_tracker/st_cb_bufferobjects.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c

[Mesa-dev] [PATCH 3/5] radeon: use _mesa_delete_buffer_object

2016-01-05 Thread Nicolai Hähnle
From: Nicolai Hähnle This is more future-proof, plugs the memory leak of Label and properly destroys the buffer mutex. --- src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] tgsi/scan: set if a fragment shader writes sample mask

2016-01-05 Thread eocallaghan
This series is, Reviewed-by: Edward O'Callaghan On 2016-01-06 12:46, Marek Olšák wrote: From: Marek Olšák This will be used by radeonsi. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2

[Mesa-dev] [Bug 93524] Clover doesn't build

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93524 --- Comment #1 from Michel Dänzer --- Please send the patch to the mesa-dev mailing list for review, with the commit log changed to something like: clover: Add libelf cflags Fixes the build when libelf is in a non default

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2016-01-05 Thread eocallaghan
On 2016-01-06 10:30, Brian Paul wrote: Series looks OK to me. Reviewed-by: Brian Paul Do you need someone to commit/push for you? I do yes, thank you kindly. Edward. -Brian On 01/05/2016 03:07 AM, Edward O'Callaghan wrote: Fix silly issue with MSVC case fall-though

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #14 from Michael Harder --- (In reply to Patrick Baggett from comment #11) > Created attachment 120822 [details] [review] > Use prefetcht1 instead of prefetch[w] > > This should fix the SIGILL when running this

[Mesa-dev] [Bug 93003] mesa 11.x with vmwgfx (vmware Fusion 8.x) graphical corruption under gnome-shell on GTK applications.

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93003 --- Comment #2 from le...@thefnords.org --- 1) Mesa version was originally 11.0.6, and I know I've tested the update to 11.0.7/8. I am not sure if I've tried it with the current F23 version (11.1.0). I'll check kernel version as soon as I'm

Re: [Mesa-dev] [PATCH V2] mesa: fix GL_MAX_NAME_LENGTH query for tessellation shaders

2016-01-05 Thread Timothy Arceri
ping This fixes some piglit subtests for ARB_program_interface_query. On Thu, 2015-12-24 at 13:16 +1100, Timothy Arceri wrote: > V2: fix alignment > --- > src/mesa/main/shader_query.cpp | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH] i965: quieten compiler warning about out-of-bounds access

2016-01-05 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Only turn on ARB_compute_shader if we can write registers.

2016-01-05 Thread Kenneth Graunke
Compute shaders require reconfiguring the L3 for shared local memory support. We have to be able to write the L3 registers to do that. This effectively turns off compute shaders prior to Kernel 4.2. (Previously, the extension enable was in an API_OPENGL_CORE conditional. However, that isn't

Re: [Mesa-dev] [PATCH v2] st/va: count number of slices

2016-01-05 Thread Christian König
On 04.01.2016 23:31, Julien Isorce wrote: From: Julien Isorce The counter was not set but used by the nouveau driver. It is required otherwise visual output is garbage. Signed-off-by: Julien Isorce Reviewed-by: Christian König

[Mesa-dev] [PATCH shader-db 3/4] report.py: Handle TCS and TES shaders.

2016-01-05 Thread Kenneth Graunke
VS/GS/FS match the regex '.S' but TCS/TES do not. Just match \S+. --- report.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/report.py b/report.py index 877e4ff..f9b1776 100755 --- a/report.py +++ b/report.py @@ -10,7 +10,7 @@ def get_results(filename): results = {}

[Mesa-dev] [PATCH shader-db 4/4] run.py: Add tessellation shader support.

2016-01-05 Thread Kenneth Graunke
--- run.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) in case you want to use the old runner to produce .out files. diff --git a/run.py b/run.py index 58bdbbf..ced8710 100755 --- a/run.py +++ b/run.py @@ -48,7 +48,7 @@ def run_test(filename): lines = (line for line in

[Mesa-dev] [PATCH shader-db 2/4] report.py: Explicitly require python3

2016-01-05 Thread Kenneth Graunke
This will prevent more python2isms from creeping in. --- report.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/report.py b/report.py index 1352f22..877e4ff 100755 --- a/report.py +++ b/report.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 import re

[Mesa-dev] [PATCH shader-db 1/4] Fix Python2ism that crept into report.py.

2016-01-05 Thread Kenneth Graunke
I ported this to Python 3 back in 2012. It's not supposed to be run with Python 2. --- report.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/report.py b/report.py index 409474a..1352f22 100755 --- a/report.py +++ b/report.py @@ -73,7 +73,7 @@ def main():

Re: [Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

2016-01-05 Thread Roland Scheidegger
Am 04.01.2016 um 22:00 schrieb Samuel Pitoiset: > > > On 01/04/2016 09:25 PM, Ilia Mirkin wrote: >> On Mon, Jan 4, 2016 at 3:13 PM, Samuel Pitoiset >> wrote: >>> On 01/03/2016 05:37 AM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #11 from Patrick Baggett --- Created attachment 120822 --> https://bugs.freedesktop.org/attachment.cgi?id=120822=edit Use prefetcht1 instead of prefetch[w] This should fix the SIGILL when running this

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 Lars Kellogg-Stedman changed: What|Removed |Added CC|l...@oddbit.com | -- You are

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #13 from Roland Scheidegger --- (In reply to Patrick Baggett from comment #11) > Created attachment 120822 [details] [review] > Use prefetcht1 instead of prefetch[w] > > This should fix the SIGILL when running

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #12 from Roland Scheidegger --- (In reply to Patrick Baggett from comment #10) > Created attachment 120821 [details] > attachment-30621-0.html > > Given that there is a _mesa_3dnow_transform_points4_2d in the

[Mesa-dev] [Bug 93003] mesa 11.x with vmwgfx (vmware Fusion 8.x) graphical corruption under gnome-shell on GTK applications.

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93003 Sinclair Yeh changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1

[Mesa-dev] [PATCH] glsl: add image_format check in cross_validate_globals()

2016-01-05 Thread Samuel Iglesias Gonsálvez
Fixes CTS test: ES31-CTS.shader_image_load_store.negative-linkErrors Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93410 Signed-off-by: Samuel Iglesias Gonsálvez --- src/glsl/linker.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Mesa-dev] [PATCH] i965: Use rcp in brw_lower_texture_gradients rather than 1.0 / x.

2016-01-05 Thread Kenneth Graunke
That's what it's for. Plus, we actually implement rcp. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] glsl: Relax ir_quadop_bitfield_insert type restrictions.

2016-01-05 Thread Jason Ekstrand
On Jan 5, 2016 5:34 AM, "Kenneth Graunke" wrote: > > While GLSL restricts bitfieldInsert's offset and bits parameters to > be scalars, we shouldn't require this in the IR. > > In particular, opt_vectorize() tries to combine > > result.x = bitfieldInsert(src0.x, src1.x,

Re: [Mesa-dev] [PATCH] i965: quieten compiler warning about out-of-bounds access

2016-01-05 Thread Jason Ekstrand
On Jan 4, 2016 8:30 PM, "Ilia Mirkin" wrote: > > gcc 4.9.3 shows the following error: > > brw_vue_map.c:260:20: warning: array subscript is above array bounds > [-Warray-bounds] > return brw_names[slot - VARYING_SLOT_MAX]; > > This is because BRW_VARYING_SLOT_COUNT is a

[Mesa-dev] [PATCH v2] mesa: remove link validation that should be done elsewhere

2016-01-05 Thread Timothy Arceri
Even if re-linking fails rendering shouldn't fail as the previous succesfully linked program will still be available. It also shouldn't be possible to have an unlinked program as part of the current rendering state. This fixes a subtest in: ES31-CTS.sepshaderobjs.StateInteraction This change

[Mesa-dev] [PATCH 2/2] llvmpipe: avoid most 64 bit math in rasterization

2016-01-05 Thread sroland
From: Roland Scheidegger The trick here is to recognize that in the c + n * dcdx calculations, not only can the lower FIXED_ORDER bits not change (as the dcdx values have those all zero) but that this means the sign bit of the calculations cannot be different as well, that is

[Mesa-dev] [PATCH 1/2] llvmpipe: scale up bounding box planes to subpixel precision

2016-01-05 Thread sroland
From: Roland Scheidegger Otherwise some planes we get in rasterization have subpixel precision, others not. Doesn't matter so far, but will soon. (OpenGL actually supports viewports with subpixel accuracy, so could even do bounding box calcs with that). ---

[Mesa-dev] [PATCH] nir: Add a lower_fdiv option, turn fdiv into fmul/frcp.

2016-01-05 Thread Kenneth Graunke
The nir_opt_algebraic rule (('fadd', ('flog2', a), ('fneg', ('flog2', b))), ('flog2', ('fdiv', a, b))), can produce new fdiv operations, which need to be lowered on i965, as we don't actually implement fdiv. (Normally, we handle this in GLSL IR's lower_instructions pass, but in the above case

Re: [Mesa-dev] [PATCH] nir: Add a lower_fdiv option, turn fdiv into fmul/frcp.

2016-01-05 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Jan 5, 2016 at 4:25 PM, Kenneth Graunke wrote: > The nir_opt_algebraic rule > > (('fadd', ('flog2', a), ('fneg', ('flog2', b))), ('flog2', ('fdiv', a, > b))), > > can produce new fdiv operations, which need to

Re: [Mesa-dev] [PATCH 2/2] glsl: Relax ir_quadop_bitfield_insert type restrictions.

2016-01-05 Thread Ilia Mirkin
On Tue, Jan 5, 2016 at 8:34 AM, Kenneth Graunke wrote: > While GLSL restricts bitfieldInsert's offset and bits parameters to > be scalars, we shouldn't require this in the IR. > > In particular, opt_vectorize() tries to combine > > result.x = bitfieldInsert(src0.x, src1.x,

Re: [Mesa-dev] [PATCH v2 5/5] llvmpipe: Optimize lp_rast_triangle_32_3_16 for POWER8

2016-01-05 Thread Roland Scheidegger
Am 03.01.2016 um 16:17 schrieb Oded Gabbay: > This patch converts the SSE-optimized lp_rast_triangle_32_3_16() > to VMX/VSX. > > I measured the results on POWER8 machine with 32 cores at 3.4GHz and > 16GB of RAM. > > FPS/Score > NameBefore AfterDelta >

[Mesa-dev] [Bug 27512] Illegal instruction _mesa_x86_64_transform_points4_general

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=27512 --- Comment #10 from Patrick Baggett --- Given that there is a _mesa_3dnow_transform_points4_2d in the x86-64 asm (using MMX/3DNow! is deprecated in x86-64), it appears that this code was copy-pasted. I wrote a quick

Re: [Mesa-dev] [PATCH 01/28] glsl: only add outward facing varyings to resourse list for SSO

2016-01-05 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > An SSO program can have multiple stages and we only want to add the externally > facing varyings. The current code was adding both the packed inputs and > outputs > for the first and last stage of each

Re: [Mesa-dev] [PATCH V2] mesa: fix GL_MAX_NAME_LENGTH query for tessellation shaders

2016-01-05 Thread Marek Olšák
Negating that expression would make it more readable. There are also a lot of unnecessary parentheses. If you at least remove the parentheses: Reviewed-by: Marek Olšák Marek On Tue, Jan 5, 2016 at 11:23 PM, Timothy Arceri wrote: > ping > >

Re: [Mesa-dev] [PATCH 02/28] glsl: move lowering after matching validation

2016-01-05 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > After lowering the matching flag is_unmatched_generic_inout is lost so > we need to move this validation before lowering. > --- > src/glsl/link_varyings.cpp | 22 +++--- > 1 file changed, 11

Re: [Mesa-dev] [PATCH 03/28] glsl: don't change the varying type in validation code

2016-01-05 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > There is a function dedicated to demoting unused varyings lets > trust it to do its job. > --- > src/glsl/link_varyings.cpp | 5 - > 1 file changed, 5 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/6] gallium: Remove unnecessary semicolons

2016-01-05 Thread Brian Paul
Series looks OK to me. Reviewed-by: Brian Paul Do you need someone to commit/push for you? -Brian On 01/05/2016 03:07 AM, Edward O'Callaghan wrote: Fix silly issue with MSVC case fall-though support to need a extra 'break;' Found-by: Coccinelle Signed-off-by: Edward

[Mesa-dev] [Bug 93003] mesa 11.x with vmwgfx (vmware Fusion 8.x) graphical corruption under gnome-shell on GTK applications.

2016-01-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93003 Sinclair Yeh changed: What|Removed |Added CC||s...@vmware.com -- You

Re: [Mesa-dev] [PATCH 04/28] glsl: remove unused varyings before packing them

2016-01-05 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > Previously we would pack varyings before trying to remove them, this > relied on the packing pass not packing varyings with a location of -1 > to avoid packing varyings that should be removed. > However this

Re: [Mesa-dev] [PATCH shader-db] si-report: Track max waves per CU

2016-01-05 Thread Marek Olšák
Hi, I'd like us to do this computation in Mesa, because it can be more accurate there. The pixel shader wave count depends heavily on LDS, because each interpolated input occupies 12 dwords of LDS per primitive and there can be 1-16 primitives per wave. With 32 inputs and 16 primitives, you can

[Mesa-dev] [PATCH 1/3] tgsi/scan: set if a fragment shader writes sample mask

2016-01-05 Thread Marek Olšák
From: Marek Olšák This will be used by radeonsi. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c

[Mesa-dev] [PATCH 3/3] tgsi/scan: set which color components are read by a fragment shader

2016-01-05 Thread Marek Olšák
From: Marek Olšák This will be used by radeonsi. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 30 ++ src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 + 2 files changed, 23 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] tgsi/scan: fix tgsi_shader_info::reads_z

2016-01-05 Thread Marek Olšák
From: Marek Olšák This has no users in Mesa. --- src/gallium/auxiliary/tgsi/tgsi_scan.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_scan.c b/src/gallium/auxiliary/tgsi/tgsi_scan.c index e3feed9..e3a6fb0 100644

Re: [Mesa-dev] [PATCH] nir: Add a lower_fdiv option, turn fdiv into fmul/frcp.

2016-01-05 Thread Matt Turner
Whoops. I think that was my fault. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/va: hardlink driver instances to gallium_drv_video.so

2016-01-05 Thread Jimmy Berry
I have been holding off v2 with correct spacing before \ (seemingly missed the first time) waiting for a review to confirm that this is the right approach as agreed in IRC. Let me know if anything else. -- Jimmy On Sat, Dec 19, 2015 at 10:57 PM, Jimmy Berry wrote: >