[Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region Restrictions, page 844: "When source or destination datatype is 64b or operation is integer DWord multiply, indirect addressing must not be used." v2: - Fix it for Broxton too. v3: - Simplify code by using

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

On Fri, 17 Jun 2016 08:26:04 -0400 Rob Clark wrote: > On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen wrote: > > On Thu, 16 Jun 2016 10:40:51 -0400 > > Rob Clark wrote: > > > >> So, if we wanted to extend this to support the

[Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

A pipe pointer in the screen allows for access to current device context in flush_frontbuffer and resource_destroy. This wasn't tracking current context in multi-context situations. --- src/gallium/drivers/swr/swr_context.cpp |6 -- src/gallium/drivers/swr/swr_state.cpp |4 2

Re: [Mesa-dev] [RFC] New dma_buf -> EGLImage EGL extension - Final spec published!

On Fri, Jun 17, 2016 at 3:59 AM, Pekka Paalanen wrote: > On Thu, 16 Jun 2016 10:40:51 -0400 > Rob Clark wrote: > >> So, if we wanted to extend this to support the fourcc-modifiers that >> we have on the kernel side for compressed/tiled/etc formats, what

Re: [Mesa-dev] [PATCH] swr: switch from overriding -march to selecting features

Using these adjusted flags, I can verify SWR running on Intel SandyBridge, Intel Haswell, and AMD Interlagos. Acked-by: Chuck Atkins Tested-by: Chuck Atkins - Chuck On Thu, Jun 16, 2016 at 4:07 PM, Tim Rowley

Re: [Mesa-dev] [PATCH] swr: Update screen->context pointer with multiple contexts.

> On Jun 17, 2016, at 8:58 AM, Bruce Cherniak wrote: > > A pipe pointer in the screen allows for access to current device context > in flush_frontbuffer and resource_destroy. This wasn't tracking current > context in multi-context situations. > --- >

[Mesa-dev] [PATCH 2/3] radeonsi: fix calculation of valid RB mask per SE

From: Nicolai Hähnle The old calculation treated too many RBs as disabled. Cc: 11.0 11.1 11.2 12.0 --- src/gallium/drivers/radeonsi/si_state.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] radeonsi: raise SI_PM4_MAX_DW

From: Nicolai Hähnle The old limit, introduced in commit afa752d3f03ac6697581ff5d324e8ac0512ef513, was exceeded by 4 SE configurations which hit si_write_harvested_raster_configs. Cc: 11.1 11.2 12.0 ---

Re: [Mesa-dev] [PATCH 2/2] i965/fs: indirect addressing with doubles is not supported in CHV/BSW

On Wednesday, June 15, 2016 9:25:45 AM PDT Samuel Iglesias Gonsálvez wrote: > From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region > Restrictions, page 844: > > "When source or destination datatype is 64b or operation is integer DWord >multiply, indirect addressing

Re: [Mesa-dev] [PATCH 2/4] i965: Fix multiplication of immediates on Cherryview/Broxton.

On Saturday, June 11, 2016 4:06:32 PM PDT Jordan Justen wrote: > On 2016-06-10 14:19:44, Kenneth Graunke wrote: > > Cherryview and Broxton don't support DW x DW multiplication. We have > > piles of code to handle this, but apparently weren't retyping in the > > immediate case. > > > > For

Re: [Mesa-dev] [PATCH 2/2] i965/fs: indirect addressing with doubles is not supported in CHV/BSW

On 17/06/16 08:57, Kenneth Graunke wrote: > On Wednesday, June 15, 2016 9:25:45 AM PDT Samuel Iglesias Gonsálvez wrote: >> From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region >> Restrictions, page 844: >> >> "When source or destination datatype is 64b or operation is

Re: [Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

On Friday, June 17, 2016 11:10:28 AM PDT Samuel Iglesias Gonsálvez wrote: > > On 17/06/16 10:43, Samuel Iglesias Gonsálvez wrote: > > From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region > > Restrictions, page 844: > > > > "When source or destination datatype is 64b or

Re: [Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

On 17/06/16 11:12, Kenneth Graunke wrote: > On Friday, June 17, 2016 11:10:28 AM PDT Samuel Iglesias Gonsálvez wrote: [...] >> What do you think Kenneth? >> >> Sam > > This sounds great to me. I like v4 (your suggestion above) the best. > Thanks for fixing this, and putting in the extra effort

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

Reviewed-by: Samuel Iglesias Gonsálvez On 17/06/16 07:12, Timothy Arceri wrote: > --- > src/mesa/main/api_validate.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/src/mesa/main/api_validate.c

Re: [Mesa-dev] [PATCH v3] i965/fs: indirect addressing with doubles is not supported in CHV/BSW/BXT

On 17/06/16 10:43, Samuel Iglesias Gonsálvez wrote: > From the Cherryview's PRM, Volume 7, 3D Media GPGPU Engine, Register Region > Restrictions, page 844: > > "When source or destination datatype is 64b or operation is integer DWord >multiply, indirect addressing must not be used." > >

Re: [Mesa-dev] [PATCH] swr: push/pop DEBUG macro around llvm includes

On 17/06/16 03:13, Tim Rowley wrote: llvm redefines DEBUG; adding push/pop prevents a undefined reference to debug_refcnt_state in llvm-3.7+. --- src/gallium/drivers/swr/swr_shader.cpp | 9 ++--- src/gallium/drivers/swr/swr_state.cpp | 6 +- 2 files changed, 11 insertions(+), 4

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

Now the subject no longer makes any sense. On Thu, Jun 16, 2016 at 7:02 AM, wrote: > From: Francesco Ansanelli > > --- > src/mesa/state_tracker/st_cb_fbo.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Mesa-dev] [RFC 3/7] Revert "virgl: reuse screen when fd is already open"

This reverts commit f87330dbce3f67cb531194f63a5db59685dcbbd3. Cc: Emil Velikov Cc: Dave Airlie --- src/gallium/auxiliary/target-helpers/drm_helper.h | 7 +- src/gallium/drivers/virgl/virgl_screen.c | 1 -

[Mesa-dev] [RFC 6/7] freedreno: remove screen ref counting

Now that the pipe-loader is reference counting the screen creation, it is unnecessary to do in it the winsys/driver. Signed-off-by: Rob Herring Cc: Rob Clark --- src/gallium/drivers/freedreno/freedreno_screen.c | 1 -

[Mesa-dev] [RFC 1/7] gallium: move pipe_screen destroy into pipe-loader

In preparation to add reference counting of pipe_screen in the pipe-loader, pipe_loader_release needs to destroy the pipe_screen instead of state trackers. Signed-off-by: Rob Herring Cc: Emil Velikov --- src/gallium/auxiliary/pipe-loader/pipe_loader.h

[Mesa-dev] [RFC 5/7] nouveau: remove screen ref counting

Now that the pipe-loader is reference counting the screen creation, it is unnecessary to do in it the winsys/driver. Signed-off-by: Rob Herring Cc: Alexandre Courbot --- src/gallium/drivers/nouveau/nouveau_screen.h | 2 -

Re: [Mesa-dev] [PATCH 09/14] swr: [rasterizer core] conservative rasterization frontend support

On 17 June 2016 at 20:25, Tim Rowley wrote: > create mode 100644 src/gallium/drivers/swr/rasterizer/core/conservativeRast.h > Please mention the new file in the CORE_CXX_SOURCES list in Makefile.sources (alphabetically). Thanks Emil

[Mesa-dev] [PATCH 03/11] mesa: Implement _mesa_all_varyings_in_vbos.

From: Mathias Fröhlich Implement the equivalent of vbo_all_varyings_in_vbos for vertex array objects. Signed-off-by: Mathias Fröhlich --- src/mesa/main/arrayobj.c | 35 +++ src/mesa/main/arrayobj.h | 4

Re: [Mesa-dev] [RFC 2/7] pipe-loader-drm: Add common pipe_screen refcounting

On 17 June 2016 at 19:28, Rob Clark wrote: > On Fri, Jun 17, 2016 at 2:23 PM, Emil Velikov > wrote: >> Hi Rob, >> >> On 17 June 2016 at 18:45, Rob Herring wrote: >> >>> struct pipe_screen { >>> + int refcnt; >> Can you please

[Mesa-dev] [PATCH 09/14] swr: [rasterizer core] conservative rasterization frontend support

--- src/gallium/drivers/swr/rasterizer/core/api.cpp| 13 +- src/gallium/drivers/swr/rasterizer/core/clip.h | 4 +- .../drivers/swr/rasterizer/core/conservativeRast.h | 120 +++ src/gallium/drivers/swr/rasterizer/core/context.h | 2 +

Re: [Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

On 17 June 2016 at 20:05, Rob Herring wrote: > On Fri, Jun 17, 2016 at 1:45 PM, Emil Velikov > wrote: >> On 17 June 2016 at 18:45, Rob Herring wrote: >>> Now that the pipe-loader is reference counting the screen creation, it >>> is

[Mesa-dev] [PATCH v2] swr: Update screen->context pointer with multiple contexts.

A pipe pointer in the screen allows for access to current device context in flush_frontbuffer and resource_destroy. This wasn't tracking current context in multi-context situations. v2: More caffeine. Corrected compare, removed unnecessary set of screen-pipe in create_context, and added a few

Re: [Mesa-dev] [RFC 2/7] pipe-loader-drm: Add common pipe_screen refcounting

On Fri, Jun 17, 2016 at 1:45 PM, Rob Herring wrote: > Some gallium drivers have implemented reference counting of pipe_screen > to avoid creating multiple screens for a device. Move this into the > pipe-loader where it can be shared. > > Not completely sure, but it should not

[Mesa-dev] [Bug 96410] [Perf] Pre validate _mesa_sampler_uniforms_pipeline_are_valid like _mesa_sampler_uniforms_are_valid

https://bugs.freedesktop.org/show_bug.cgi?id=96410 --- Comment #1 from gregory.hain...@gmail.com --- Currently looking at the code of single program flow namely _mesa_update_shader_textures_used The current check fails to detect wrongly reused sampler in multiple shader stage. The spec seems to

[Mesa-dev] [PATCH 1/3] egl/x11_dri3: disable WL_bind_wayland_display for devices without render nodes

Up until now, DRI3 was only used for devices that have render nodes, unless overridden via an environment variable, with it falling back to DRI2 otherwise. This limitation was there in order to support WL_bind_wayland_display as it requires client opened device node fds to be authenticated, which

[Mesa-dev] [PATCH 3/3] egl: only store device name when Wayland support is built

The device name is only needed for WL_bind_wayland_display so make this clear by only storing the device name when Wayland support is built. Signed-off-by: Frank Binns --- src/egl/drivers/dri2/egl_dri2.c | 5 - src/egl/drivers/dri2/egl_dri2.h | 2

[Mesa-dev] [PATCH 03/14] swr: [rasterizer] add support for building avx512 version

Currently, most code paths between AVX2 and AVX512 are identical (see changes to knobs.h). --- src/gallium/drivers/swr/rasterizer/common/simdintrin.h | 4 ++-- src/gallium/drivers/swr/rasterizer/core/format_types.h | 8 src/gallium/drivers/swr/rasterizer/core/knobs.h | 15

[Mesa-dev] [PATCH 01/14] swr: [rasterizer common] workaround clang for windows __cpuid() bug

--- src/gallium/drivers/swr/rasterizer/common/isa.hpp | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/isa.hpp b/src/gallium/drivers/swr/rasterizer/common/isa.hpp index ef38179..31ea787 100644 ---

[Mesa-dev] [PATCH 00/14] update swr rasterizer

Mostly bug fixes and cleanups. Tim Rowley (14): swr: [rasterizer common] workaround clang for windows __cpuid() bug swr: [rasterizer common] fix include for Intel compiler swr: [rasterizer] add support for building avx512 version swr: [rasterizer jitter] unitialized component fix in fetch

[Mesa-dev] [PATCH 14/14] swr: [rasterizer core] fix dependency bug

Never be dependent on "draw 0", instead have a bool that makes the draw dependent on the previous draw or not dependent at all. --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 6 +++--- src/gallium/drivers/swr/rasterizer/core/context.h| 6 +++---

[Mesa-dev] [PATCH 02/14] swr: [rasterizer common] fix include for Intel compiler

--- src/gallium/drivers/swr/rasterizer/common/os.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index 370c619..45517f6 100644 ---

Re: [Mesa-dev] [PATCH] swr: switch from overriding -march to selecting features

On 17 June 2016 at 14:06, Chuck Atkins wrote: > Using these adjusted flags, I can verify SWR running on Intel SandyBridge, > Intel Haswell, and AMD Interlagos. > Not only building but running as well (on AMD hardware) - nice :-) If any issues arise one could tweak things

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

Please understand me right, we are not talking about desktop hardware and libraries, only about embedded in case of GL ES. What's common for desktop usually uncommon for embedded and vice versa. We are currently ship libraries from many silicon vendors: Imagination RGX, Mali, Vivante, nVidia - all

[Mesa-dev] [PATCH 00/11] Make more use of state already tracked in the VAO.

From: Mathias Fröhlich Hi, The first two patches fix a bug in tracking the VAO internal state. The majority of the changeset makes more use of the state currently tracked in the VAO and transitions to use more of the first order information found in the VAO instead of

[Mesa-dev] [PATCH 01/11] mesa: Add flush_vertices argument to _mesa_bind_vertex_buffer.

From: Mathias Fröhlich Similar to _mesa_update_array_format add an argument to avoid calling FLUSH_VERTICES in certain cases. This will be used with the following change. Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/common/meta.c |

[Mesa-dev] [PATCH 02/11] mesa: Unbind deleted vbo using _mesa_bind_vertex_buffer.

From: Mathias Fröhlich When a vertex buffer object gets deleted, it is unbound at the VAO. To do this use _mesa_bind_vertex_buffer instead of plain unreferencing the buffer object. This keeps the VAOs internal state consistent. In this case it showed up with

[Mesa-dev] [PATCH 11/11] mesa: Remove set but not used gl_client_array::Stride.

From: Mathias Fröhlich The field is only read for printing today and there it was probably a leftover. Signed-off-by: Mathias Fröhlich --- src/mesa/main/mtypes.h | 1 - src/mesa/main/varray.c | 1 -

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

On 17 June 2016 at 18:20, Ian Romanick wrote: > From: Ian Romanick > > Khronos recommends that the GLES 3.1 library also be called libGLESv2. > It also requires that functions be statically linkable from that > library. > > NOTE: Mesa has supported

Re: [Mesa-dev] [PATCH] st/mesa: Remove tautological check (v2)

Hi Erik, Thanks for your feedback. Can you suggest a better subject? After some thinking, should I cast gl_buffer_index before calling the function? Thanks Francesco Il 17 giu 2016 12:39, "Erik Faye-Lund" ha scritto: > Now the subject no longer makes any sense. > > On Thu,

[Mesa-dev] [PATCH 12/14] swr: [rasterizer jitter] add support for component packing for 'odd' formats

Add early-out if no components are enabled. Add asserts. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 27 ++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp

[Mesa-dev] [PATCH 05/14] swr: [rasterizer jitter] cleanup supporting different llvm versions

--- src/gallium/drivers/swr/Makefile.am| 2 + .../drivers/swr/rasterizer/jitter/JitManager.cpp | 33 +--- .../drivers/swr/rasterizer/jitter/JitManager.h | 22 --- .../drivers/swr/rasterizer/jitter/blend_jit.cpp| 13 ++-

[Mesa-dev] [PATCH 11/14] swr: [rasterizer core] track whether GS outputs viewport array index

So we can skip the index gather in PA. --- src/gallium/drivers/swr/rasterizer/core/state.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/core/state.h b/src/gallium/drivers/swr/rasterizer/core/state.h index 29048f1..bfa9929 100644 ---

[Mesa-dev] [PATCH 08/14] swr: [rasterizer core] stop single threaded crash exit crash

Function static destructors were getting called by exit handlers before context teardown. --- src/gallium/drivers/swr/rasterizer/core/api.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp

[Mesa-dev] [PATCH 13/14] swr: [rasterizer core] use wrap-around safe compares for dependency checking

Move drawIDs from 64-bit to 32-bit to increase perf. --- src/gallium/drivers/swr/rasterizer/core/api.cpp| 4 +- src/gallium/drivers/swr/rasterizer/core/context.h | 6 +-- .../drivers/swr/rasterizer/core/ringbuffer.h | 8 ++-- .../drivers/swr/rasterizer/core/threads.cpp| 54

[Mesa-dev] [PATCH 07/14] swr: [rasterizer jitter] small fetch jit cleanup

Handle SGV stores separate from the stream fetch code. Because of this change, there is a potential to jit an extra unused store. --- .../drivers/swr/rasterizer/jitter/fetch_jit.cpp| 170 + 1 file changed, 36 insertions(+), 134 deletions(-) diff --git

[Mesa-dev] [PATCH 10/14] swr: [rasterizer core] GS viewport array index attribute

Only adds the attribute mapping to the jitter; no implementation yet. --- src/gallium/drivers/swr/rasterizer/core/knobs.h | 2 +- src/gallium/drivers/swr/rasterizer/core/state.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/knobs.h

[Mesa-dev] [PATCH 06/14] swr: [rasterizer core] remove old comment

--- src/gallium/drivers/swr/rasterizer/core/frontend.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/core/frontend.cpp b/src/gallium/drivers/swr/rasterizer/core/frontend.cpp index 6e1bc0e..f86f8fa 100644 ---

[Mesa-dev] [PATCH 04/14] swr: [rasterizer jitter] unitialized component fix in fetch jit

Was trying to store an extra uninitialized component. Only affects component packing, which isn't enabled (yet). --- src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/fetch_jit.cpp

[Mesa-dev] [PATCH 09/11] vbo: Use the VAO array enabled flags in vbo_exec_array.

From: Mathias Fröhlich Instead of gl_client_array::Enabled inside a VAO, directly use the gl_vertex_attrib_array::Enabled value which is the origin of the above. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c | 15

[Mesa-dev] [PATCH 08/11] vbo: Walk the VAO in check_array_data.

From: Mathias Fröhlich Only a debugging function, but move away from gl_client_array and use the first order information from the VAO. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c | 49

[Mesa-dev] [PATCH 04/11] vbo: Walk the VAO to see if all varyings are in vbos.

From: Mathias Fröhlich In vbo_draw_transform_feedback we currently look at exec->array.inputs to determine if all varying vertex attributes reside in vbos. But the vbo_bind_arrays call only happens past the vbo_all_varyings_in_vbos query. Thus we may work on a stale set

[Mesa-dev] [PATCH 10/11] mesa: Remove set but not used gl_client_array::Enabled.

From: Mathias Fröhlich The way it is used today does not care about the Enabled flag anymore. Signed-off-by: Mathias Fröhlich --- src/mesa/main/mtypes.h | 1 - src/mesa/main/varray.c | 1 -

[Mesa-dev] [PATCH 07/11] vbo: Walk the VAO in print_draw_arrays.

From: Mathias Fröhlich Only a debugging function, but move away from gl_client_array and use the first order information from the VAO. Also make use of gl_vert_attrib_name. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c |

[Mesa-dev] [PATCH 06/11] mesa: Walk the VAO in _mesa_print_arrays.

From: Mathias Fröhlich Only a debugging function, but move away from gl_client_array and use the first order information from the VAO. Also make use of gl_vert_attrib_name. Signed-off-by: Mathias Fröhlich --- src/mesa/main/varray.c | 52

[Mesa-dev] [PATCH 05/11] vbo: Walk the VAO to check for mapped buffers.

From: Mathias Fröhlich Similarily to _mesa_all_varyings_in_vbos walk the VAO to check if we have an illegal mapped buffer object instead of walking all gl_client_arrays. Signed-off-by: Mathias Fröhlich --- src/mesa/vbo/vbo_exec_array.c | 33

Re: [Mesa-dev] [RFC 2/7] pipe-loader-drm: Add common pipe_screen refcounting

Hi Rob, On 17 June 2016 at 18:45, Rob Herring wrote: > struct pipe_screen { > + int refcnt; Can you please use struct pipe_reference throughout and the respective pipe_reference API from src/gallium/auxiliary/util/u_inlines.h. Thank you very much for doing this ! Emil

Re: [Mesa-dev] [PATCH v2] swr: Update screen->context pointer with multiple contexts.

Reviewed-by: Tim Rowley > On Jun 17, 2016, at 12:14 PM, Bruce Cherniak wrote: > > A pipe pointer in the screen allows for access to current device context > in flush_frontbuffer and resource_destroy. This wasn't tracking current > context

Re: [Mesa-dev] [PATCH 09/14] swr: [rasterizer core] conservative rasterization frontend support

Good spotting. Whoops, will do that. -Tim > On Jun 17, 2016, at 2:59 PM, Emil Velikov wrote: > > On 17 June 2016 at 20:25, Tim Rowley wrote: > >> create mode 100644 src/gallium/drivers/swr/rasterizer/core/conservativeRast.h >> > Please

[Mesa-dev] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

From: Ian Romanick Khronos recommends that the GLES 3.1 library also be called libGLESv2. It also requires that functions be statically linkable from that library. NOTE: Mesa has supported the EGL_KHR_get_all_proc_addresses extension since at least Mesa 10.5, so

[Mesa-dev] [RFC 0/7] Common pipe screen ref counting

I needed to add screen ref counting to vc4 driver, so rather than yet another copy of the same fd hashing and ref counting code, I implemented it in the pipe-loader. AFAICT, the pipe-loader is the only place the winsys create screen functions are called and seemed to be the best location to

[Mesa-dev] [PATCH 2/2] radeonsi: use trapezoid distribution for tess on Fiji and Polaris

From: Nicolai Hähnle This yields a small performance improvement in Unigine Heaven. --- src/gallium/drivers/radeonsi/si_state.c | 22 +- src/gallium/drivers/radeonsi/si_state_shaders.c | 10 +++--- 2 files changed, 24 insertions(+), 8

Re: [Mesa-dev] [RFC 0/7] Common pipe screen ref counting

Clearly a good idea to move this into common code, but there is just one important thing you are missing here. We intentional export the *_winsys_create() in the created libraries to have only one global file descriptor for all libraries. See the following files as well:

[Mesa-dev] [PATCH 1/2] radeonsi/sid: add Fiji+ tesselation distribution mode

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/sid.h | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/sid.h b/src/gallium/drivers/radeonsi/sid.h index a6d5c05..1363a44 100644 ---

Re: [Mesa-dev] [PATCH 23/64] isl/state: Only set cube face enables if usage includes CUBE_BIT

Patches 22 and 23 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 31/64] genxml: Put append counter fields before MCS in RENDER_SURFACE_STATE on gen7

Granted you fix patch 28 so that it builds, patches 28 through 31 are Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] egl/x11_dri3: provide an authentication function

To support WL_bind_wayland_display an authentication function needs to be provided but this was not being done for this platform as it's not strictly necessary. However, as this isn't an optional function there's the potential for a segfault to occur if authentication is mistakenly performed.

[Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

Now that the pipe-loader is reference counting the screen creation, it is unnecessary to do in it the winsys/driver. Signed-off-by: Rob Herring Cc: "Marek Olšák" Cc: Ilia Mirkin --- src/gallium/drivers/r300/r300_screen.c|

[Mesa-dev] [RFC 2/7] pipe-loader-drm: Add common pipe_screen refcounting

Some gallium drivers have implemented reference counting of pipe_screen to avoid creating multiple screens for a device. Move this into the pipe-loader where it can be shared. Not completely sure, but it should not necessary to dup() the fd as dri2_create_screen does that for us already.

[Mesa-dev] [RFC 4/7] Revert "virgl: mark function as static"

This reverts commit e7a27f70b91e202ad9afc3e67e1080572d4d4a0b. Cc: Emil Velikov Cc: Dave Airlie --- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [RFC 2/7] pipe-loader-drm: Add common pipe_screen refcounting

On Fri, Jun 17, 2016 at 2:23 PM, Emil Velikov wrote: > Hi Rob, > > On 17 June 2016 at 18:45, Rob Herring wrote: > >> struct pipe_screen { >> + int refcnt; > Can you please use struct pipe_reference throughout and the respective > pipe_reference API

Re: [Mesa-dev] [PATCH 27/64] isl/state: Add assertions for buffer surface restrictions

Acked-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 26/64] isl/state: Don't set SurfacePitch for gen9 1-D textures

Patch 26 is Reviewed-by: Chad Versace ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC 7/7] radeon: remove screen ref counting

On Fri, Jun 17, 2016 at 1:45 PM, Emil Velikov wrote: > On 17 June 2016 at 18:45, Rob Herring wrote: >> Now that the pipe-loader is reference counting the screen creation, it >> is unnecessary to do in it the winsys/driver. [...] >> -static unsigned

Re: [Mesa-dev] [PATCH 05/14] swr: [rasterizer jitter] cleanup supporting different llvm versions

Looks like some major rework of this commit is in order; I’ll get on it. > On Jun 17, 2016, at 3:36 PM, Emil Velikov wrote: > > Hi Tim, > > Does this commit allows us to have generic generated files or it's > solely workaround the VPERMD intrinsic argument swap ?

Re: [Mesa-dev] [PATCH] st/vdpau: use bicubic filter for scaling

Hi Christian, Thanks for the review. I don't understand the compositor code fully yet. How can I create a unscaled image with it? Regards, Nayan. On Fri, Jun 17, 2016 at 9:15 PM, Christian König wrote: > Really nice work. I now understand where your problem is with

[Mesa-dev] [Bug 96410] [Perf] Pre validate _mesa_sampler_uniforms_pipeline_are_valid like _mesa_sampler_uniforms_are_valid

https://bugs.freedesktop.org/show_bug.cgi?id=96410 --- Comment #2 from Timothy Arceri --- (In reply to gregory.hainaut from comment #1) > Currently looking at the code of single program flow namely > _mesa_update_shader_textures_used > > The current check fails to detect

[Mesa-dev] [PATCH] egl: Fix the bad surface attributes combination checking for pbuffers.

Fixes a regression induced by commit a0674ce5: When EGL_TEXTURE_FORMAT and EGL_TEXTURE_TARGET were both specified (and both != EGL_NO_TEXTURE), an error was instantly triggered, before the other one had even a chance to be checked, which is obviously not the intended behaviour. Signed-off-by:

Re: [Mesa-dev] [PATCH] mesa: remove remaining tabs in api_validate.c

On Fri, 2016-06-17 at 16:09 +0200, ⚛ wrote: > Hello. Are you editing those files by hand? Recently as I've come across tabs I do a quick check to see how many are in the file, if its not many then I remove them. I don't think there would be much interests in doing a batch conversion as this

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

On 17 June 2016 at 22:22, Jason Ekstrand wrote: > On Fri, Jun 17, 2016 at 2:09 PM, Emil Velikov > wrote: >> >> On 17 June 2016 at 21:12, Mike Gorchak wrote: >> > Please understand me right, we are not talking about

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

On Fri, Jun 17, 2016 at 5:48 PM, Emil Velikov wrote: > On 17 June 2016 at 22:22, Jason Ekstrand wrote: >> On Fri, Jun 17, 2016 at 2:09 PM, Emil Velikov >> wrote: >>> >>> On 17 June 2016 at 21:12, Mike Gorchak

Re: [Mesa-dev] [PATCH 02/11] nir: Add a pass for propagating invariant decorations

On Friday, June 17, 2016 1:53:19 PM PDT Jason Ekstrand wrote: > This pass is similar to propagate_invariance in the GLSL compiler. The > real "output" of this pass is that any algebraic operations which are > eventually consumed by an invariant variable get marked as "exact". > > Signed-off-by:

[Mesa-dev] [PATCH] virgl: add exported dmabuf to BO hash table

Exported dmabufs can get imported by the same process, but the handle was not getting added to the hash table on export. Add the handle to the hash table on export. Cc: Dave Airlie Signed-off-by: Rob Herring ---

[Mesa-dev] [PATCH 2/5] anv/dump: Use anv_minify instead of hand-rolling it

--- src/intel/vulkan/anv_dump.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c index 307e501..ffb892c 100644 --- a/src/intel/vulkan/anv_dump.c +++ b/src/intel/vulkan/anv_dump.c @@ -36,11 +36,10 @@

[Mesa-dev] [PATCH 0/5] anv: add better debug resourde dumping

A while ago while debugging some driver errors, I added a basic image dumping mechanism to dump images to PPM files. This little series improves things and adds support for dumping the framebuffer at the end of every renderpass. With these patches, you can dump rendering for a frame as follows:

[Mesa-dev] [PATCH 4/5] anv/dump: Add a barrier for the source image

--- src/intel/vulkan/anv_dump.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c index 0fee93c..59a6f2a 100644 --- a/src/intel/vulkan/anv_dump.c +++ b/src/intel/vulkan/anv_dump.c @@ -90,6 +90,28 @@

[Mesa-dev] [PATCH 3/5] anv/dump: Refactor the guts into helpers

--- src/intel/vulkan/anv_dump.c | 224 +++- 1 file changed, 139 insertions(+), 85 deletions(-) diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c index ffb892c..0fee93c 100644 --- a/src/intel/vulkan/anv_dump.c +++

[Mesa-dev] [PATCH 5/5] anv/dump: Add support for dumping framebuffers

--- src/intel/vulkan/anv_dump.c| 127 + src/intel/vulkan/anv_private.h | 10 +++ src/intel/vulkan/genX_cmd_buffer.c | 4 ++ 3 files changed, 141 insertions(+) diff --git a/src/intel/vulkan/anv_dump.c b/src/intel/vulkan/anv_dump.c index

[Mesa-dev] [PATCH 02/11] nir: Add a pass for propagating invariant decorations

This pass is similar to propagate_invariance in the GLSL compiler. The real "output" of this pass is that any algebraic operations which are eventually consumed by an invariant variable get marked as "exact". Signed-off-by: Jason Ekstrand Cc: "12.0"

[Mesa-dev] [PATCH 09/11] anv: Add an allocator for scratch buffers

Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Francisco Jerez --- src/intel/vulkan/anv_allocator.c | 76 src/intel/vulkan/anv_private.h | 13 +++ 2 files changed, 89

[Mesa-dev] [PATCH 10/11] genxml: Make ScratchSpaceBasePointer an address instead of an offset

While we're here, we also fixup MEDIA_VFE_STATE and rename the field in 3DSTATE_VS on gen6-7.5 to be consistent with the others. Signed-off-by: Jason Ekstrand Cc: "12.0" Cc: Francisco Jerez ---

[Mesa-dev] [PATCH 11/11] anv: Use different BOs for different scratch sizes and stages

This solves a race condition where we can end up having different stages stomp on each other because they're all trying to scratch in the same BO but they have different views of its layout. Signed-off-by: Jason Ekstrand Cc: "12.0" Cc:

[Mesa-dev] [PATCH 01/11] anv: Add support for INTEL_DEBUG=sync, state

Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/intel/vulkan/gen8_cmd_buffer.c | 9 + src/intel/vulkan/genX_cmd_buffer.c | 9 + 2 files changed, 18 insertions(+) diff --git a/src/intel/vulkan/gen8_cmd_buffer.c

Re: [Mesa-dev] [PATCH 01/11] anv: Add support for INTEL_DEBUG=sync, state

On Friday, June 17, 2016 1:53:18 PM PDT Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Cc: "12.0" > --- > src/intel/vulkan/gen8_cmd_buffer.c | 9 + > src/intel/vulkan/genX_cmd_buffer.c | 9 + > 2 files changed, 18

Re: [Mesa-dev] [Mesa-stable] [PATCH] mapi: Export all GLES 3.1 functions in libGLESv2.so

On Friday, June 17, 2016 5:58:21 PM PDT Ilia Mirkin wrote: > On Fri, Jun 17, 2016 at 5:48 PM, Emil Velikov > wrote: > > On 17 June 2016 at 22:22, Jason Ekstrand wrote: > >> On Fri, Jun 17, 2016 at 2:09 PM, Emil Velikov >

Re: [Mesa-dev] [PATCH 15/64] isl/state: Return an extent3d from the halign/valign helper

On Thu, Jun 16, 2016 at 10:57 AM, Chad Versace wrote: > On Thu 16 Jun 2016, Jason Ekstrand wrote: > > On Thu, Jun 16, 2016 at 10:39 AM, Chad Versace > > wrote: > > > > > On Sat 11 Jun 2016, Jason Ekstrand wrote: > > > > --- > > > >

  1   2   >