Re: [Mesa-dev] [PATCH 2/6] nv50/ir: add LIMM form of mad to gm107

2016-10-08 18:12 GMT+02:00 Samuel Pitoiset : > Usually we prefix with gm107/ir, gk110/ir, etc... > > More comments below. > > On 10/08/2016 05:43 PM, Karol Herbst wrote: >> >> Signed-off-by: Karol Herbst >> --- >>

Re: [Mesa-dev] [PATCH 3/6] nv50/ir: replace post_ra_dead by Instruction::isDead

2016-10-08 18:39 GMT+02:00 Samuel Pitoiset : > > > On 10/08/2016 05:43 PM, Karol Herbst wrote: >> >> Signed-off-by: Karol Herbst >> --- >> src/gallium/drivers/nouveau/codegen/nv50_ir.h| 2 +- >>

[Mesa-dev] [PATCH v2 1/6] gk110/ir: add LIMM form of mad

v2: renamed commit reordered modifiers add assert(dst == src2) Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 50 ++ 1 file changed, 33 insertions(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH v2 3/6] nv50/ir: replace post_ra_dead by Instruction::isDead

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir.h| 2 +- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 20 +++- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git

[Mesa-dev] [PATCH v2 0/6] nv50/ir: PostRaConstantFolding improvements

This series reworks the structure of the pass to make it easier to add more optimisations to it. Still have to run a full piglit on my gk106 with this, but g80, gk110 and gm107 should be tested as well, but I can't. v2: swaped the last two commits changes for shader-db: total instructions in

[Mesa-dev] [PATCH v2 4/6] nv50/ir: restructure postraconstantfolding pass

we might want to add more folding passes here, so make it a bit more generic v2: leave the comment and reword commit message Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 120 +++-- 1 file changed, 62 insertions(+),

[Mesa-dev] [PATCH v2 6/6] nv50/ra: always prefer def == src2 for mad/sad

improves the post ra mad folding pass: total instructions in shared programs : 2811662 -> 2808429 (-0.11%) total gprs used in shared programs: 379273 -> 379236 (-0.01%) total local used in shared programs : 9505 -> 9505 (0.00%) total bytes used in shared programs : 25773432 -> 25743616

[Mesa-dev] [PATCH v2 5/6] nv50/ir: implement mad post ra folding for nvc0+

changes for GpuTest /test=pixmark_piano /benchmark /no_scorebox /msaa=0 /benchmark_duration_ms=6 /width=1024 /height=640: score: 1026 -> 1044 changes for shader-db: total instructions in shared programs : 2818606 -> 2811662 (-0.25%) total gprs used in shared programs: 379273 -> 379273

[Mesa-dev] [PATCH v2 2/6] gm107/ir: add LIMM form of mad

v2: renamed commit reordered modifiers add assert(dst == src2) Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 35 -- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] nv50/ir: only stick one preret per function

On Sun, Oct 9, 2016 at 7:53 AM, Samuel Pitoiset wrote: > > > On 10/09/2016 06:12 AM, Ilia Mirkin wrote: >> >> A function with multiple returns would have had multiple preret settings >> at the top of the function. While this is unlikely to have caused issues >> since we

[Mesa-dev] [Bug 98172] Concurrent call to glClientWaitSync results in segfault in one of the waiters.

https://bugs.freedesktop.org/show_bug.cgi?id=98172 shinji.suz...@gmail.com changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.

[Mesa-dev] [PATCH] st/nine: Memset pipe_resource templates

Fixes regression introduced by ecd6fce2611e88ff8468a354cff8eda39f260a31 and is more future proof than just clearing the next field. Other nine usages did already zero out the templates. Signed-off-by: Axel Davy --- src/gallium/state_trackers/nine/device9.c| 6 ++

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

https://bugs.freedesktop.org/show_bug.cgi?id=98169 --- Comment #1 from Christoph Haag --- I also noticed that the cpufrequency graphs (cpufreq-cur-cpu0) always show 0 in unigine heaven. They work correctly in glxgears, so perhaps it's caused by the same thing unigine heaven

Re: [Mesa-dev] [PATCH] nv50/ir: only stick one preret per function

On 10/09/2016 06:12 AM, Ilia Mirkin wrote: A function with multiple returns would have had multiple preret settings at the top of the function. While this is unlikely to have caused issues since we don't use funcitons in earnest, it could have in some cases s/funcitons/functions/ :) This

[Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

https://bugs.freedesktop.org/show_bug.cgi?id=98169 Bug ID: 98169 Summary: lm_sensors hud option crashes unigine heaven Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] nv50/ir: optimize ADD(SHL(a, b), c) to SHLADD(a, b, c)

On 10/08/2016 10:09 PM, Ilia Mirkin wrote: On Sat, Oct 8, 2016 at 3:55 PM, Samuel Pitoiset wrote: total instructions in shared programs :2286901 -> 2284473 (-0.11%) total gprs used in shared programs:335256 -> 335273 (0.01%) total local used in shared programs

Re: [Mesa-dev] [PATCH] nv50/ir: optimize ADD(SHL(a, b), c) to SHLADD(a, b, c)

On 10/08/2016 10:04 PM, Karol Herbst wrote: looks great, a few comments below Thanks! 2016-10-08 21:55 GMT+02:00 Samuel Pitoiset : total instructions in shared programs :2286901 -> 2284473 (-0.11%) total gprs used in shared programs:335256 -> 335273 (0.01%)

[Mesa-dev] [PATCH 2/2] nvc0: enable GLSL 4.5

This exposes OpenGL 4.5 on Fermi and Kepler GPUs. Maxwell still only exposes OpenGL 4.1 because I need to finish my instructions scheduler calculator. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH 1/2] nvc0: enable ARB_enhanced_layouts

All ARB_enhanced_layouts piglit tests pass without any changes in our compiler. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [Bug 98169] lm_sensors hud option crashes unigine heaven

> Comment # 1 on bug 98169 from Christoph Haag > > I also noticed that the cpufrequency graphs (cpufreq-cur-cpu0) always show 0 > in > unigine heaven. > > They work correctly in glxgears, so perhaps it's caused by the same thing > unigine heaven does. I'll open a bugzilla account tomorrow

Re: [Mesa-dev] [PATCH] nv50/ir: optimize ADD(SHL(a, b), c) to SHLADD(a, b, c)

2016-10-09 13:58 GMT+02:00 Samuel Pitoiset : > > > On 10/08/2016 10:04 PM, Karol Herbst wrote: >> >> looks great, a few comments below > > > Thanks! > >> >> 2016-10-08 21:55 GMT+02:00 Samuel Pitoiset : >>> >>> total instructions in shared

[Mesa-dev] [Bug 98133] GetSynciv should raise an error if bufSize < 0

https://bugs.freedesktop.org/show_bug.cgi?id=98133 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Mesa-dev] [PATCH 10/22] intel/blorp: Add an entrypoint for clearing depth and stencil

On Fri, Oct 07, 2016 at 09:41:08PM -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > src/intel/blorp/blorp.h | 10 > src/intel/blorp/blorp_clear.c | 58 > +++ > 2 files changed, 68 insertions(+) > >

Re: [Mesa-dev] [PATCH 10/22] intel/blorp: Add an entrypoint for clearing depth and stencil

On Oct 9, 2016 10:48 PM, "Pohjolainen, Topi" wrote: > > On Fri, Oct 07, 2016 at 09:41:08PM -0700, Jason Ekstrand wrote: > > Signed-off-by: Jason Ekstrand > > --- > > src/intel/blorp/blorp.h | 10 > > src/intel/blorp/blorp_clear.c

Re: [Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

On 10 October 2016 at 13:25, Dave Airlie wrote: > From: Dave Airlie > > This is a bit of a hack due to how llvm currently handles > spilling in it's shader ABI. Currently llvm amdgpu backend > uses relocations to patch the shader with the address of > the

Re: [Mesa-dev] [PATCH] android: intel/genxml: add rules to generate xml headers

On Sun, Oct 9, 2016 at 3:13 AM, Mauro Rossi wrote: > Hi Jason, > > I'm sending a patch to add rules for Android, > even if those headers are not yet used there > they are inducing a minor building error on Android. > These XML includes shouldn't be used for anything in

Re: [Mesa-dev] [PATCH 01/22] intel/blorp: Make the Z component of the primitive adjustable

On Fri, Oct 07, 2016 at 09:40:59PM -0700, Jason Ekstrand wrote: > We want to be able to start slow depth clears. This allows us to adjust I think you are missing a word or two here, s/start/start using/? Otherwise Reviewed-by: Topi Pohjolainen > the depth we're

Re: [Mesa-dev] [PATCH 11/22] intel/blorp: Add a flag to make blorp not re-emit dept/stencil buffers

On Fri, Oct 07, 2016 at 09:41:09PM -0700, Jason Ekstrand wrote: > In Vulkan, we want to be able to use blorp to perform clears inside of a > render pass. If blorp stomps the depth/stencil buffers packets then we'll > have to re-emit them. This gets tricky when secondary command buffers get >

[Mesa-dev] [PATCH 2/2] [RFC] radv: add scratch support for spilling.

From: Dave Airlie This is a bit of a hack due to how llvm currently handles spilling in it's shader ABI. Currently llvm amdgpu backend uses relocations to patch the shader with the address of the tmpring. The driver loads the shader and patches the relocations. However for

[Mesa-dev] [PATCH 1/2] radv: start using defines for the user sgpr offsets

From: Dave Airlie This adds some comments and adds defines for the user sgprs, so that we can move them around easier later and not have to change/revalidate every one of these. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 7

[Mesa-dev] [PATCH] GlBlitFramebuffer Specification Fix

The specification says that if the depth AND stencil formats do not match, not or. This fixes bug #97921. --- src/mesa/main/blit.c | 46 +++--- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index

[Mesa-dev] [Bug 98135] dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.transform_feedback_varyings wants a different GL error code

https://bugs.freedesktop.org/show_bug.cgi?id=98135 Tapani Pälli changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |lem...@gmail.com

[Mesa-dev] radv shader spilling support

This is a bit of a workaround to how llvm does spilling, and we should fix llvm, I'm just not good enough yet, and this will get us further with CTS tests for now. Details in patch 2. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 07/22] intel/blorp: Emit more complete DEPTH_STENCIL state

On Fri, Oct 07, 2016 at 09:41:05PM -0700, Jason Ekstrand wrote: > This should now set the pipeline up properly for doing depth and/or stencil > clears by plumbing through depth/stencil test values. If you like you could also say that color calculator state is now emitted also for blorp operations

Re: [Mesa-dev] [PATCH] ddebug: add missing pipe_context::clear_texture()

On 09.10.2016 21:19, Samuel Pitoiset wrote: This fixes a crash while replaying a trace from F1 2015. I think clear_texture should be handled in dd_draw.c with the draw and other clear functions. Nicolai Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH] ddebug: add missing pipe_context::clear_texture()

This fixes a crash while replaying a trace from F1 2015. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/ddebug/dd_context.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/gallium/drivers/ddebug/dd_context.c

[Mesa-dev] [PATCH] nvc0: fix valid range for shader buffers

When offset != 0, the valid range was wrong because the second argument of util_range_add() is end, not size. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_compute.c| 1 + src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 1 +

Re: [Mesa-dev] [PATCH 1/2] nvc0: enable ARB_enhanced_layouts

Reviewed-by: Edward O'Callaghan On 10/09/2016 10:48 PM, Samuel Pitoiset wrote: > All ARB_enhanced_layouts piglit tests pass without any changes > in our compiler. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] st/nine: Memset pipe_resource templates

Acked-by: Edward O'Callaghan On 10/09/2016 11:26 PM, Axel Davy wrote: > Fixes regression introduced by > ecd6fce2611e88ff8468a354cff8eda39f260a31 > and is more future proof than just clearing the next > field. > > Other nine usages did already zero out the

Re: [Mesa-dev] [PATCH] nv50/ir: optimize ADD(SHL(a, b), c) to SHLADD(a, b, c)

On Sun, Oct 9, 2016 at 3:28 PM, Karol Herbst wrote: > 2016-10-09 13:58 GMT+02:00 Samuel Pitoiset : >> >> >> On 10/08/2016 10:04 PM, Karol Herbst wrote: >>> >>> looks great, a few comments below >> >> >> Thanks! >> >>> >>> 2016-10-08 21:55

Re: [Mesa-dev] [PATCH] nv50/ir: optimize ADD(SHL(a, b), c) to SHLADD(a, b, c)

2016-10-09 21:34 GMT+02:00 Ilia Mirkin : > On Sun, Oct 9, 2016 at 3:28 PM, Karol Herbst wrote: >> 2016-10-09 13:58 GMT+02:00 Samuel Pitoiset : >>> >>> >>> On 10/08/2016 10:04 PM, Karol Herbst wrote: looks great, a

Re: [Mesa-dev] [PATCH 00/15] GLSL memory allocation rework for faster compilation

On 10/08/2016 06:58 PM, Jason Ekstrand wrote: FYI, we use ralloc for a lot more than just the glsl compiler so the first few changes make me a bit nervous. There was someone working on making our driver more I undefined-memory-friendly but I don't know what happened to those patches.

[Mesa-dev] [PATCH] android: intel/genxml: add rules to generate xml headers

Hi Jason, I'm sending a patch to add rules for Android, even if those headers are not yet used there they are inducing a minor building error on Android. Cheers and congratulations for your nice presentation on vulkan at XDC2016 Mauro >From 52c9b2d9a7d7fc962d7a8c30fc412387a74bf554 Mon Sep 17